From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Paul Mundt <lethal@linux-sh.org>,
Tony Lindgren <tony@atomide.com>,
Mike Frysinger <vapier@gentoo.org>,
linux-sh@vger.kernel.org, linux-omap@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] regulator: Provide dummy supply support
Date: Sat, 29 Oct 2011 18:42:02 +0100 [thread overview]
Message-ID: <20111029174202.GA9646@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20111028224757.GG23421@pengutronix.de>
On Sat, Oct 29, 2011 at 12:47:57AM +0200, Sascha Hauer wrote:
> My main concern with the fixed regulator is that it needs quite much
> boilerplate code just to say that we have no regulator at all for a
> given device. That could also be handled with a helper function which
> registers a fixed regulator and only takes the regulator_consumer_supply
> as an argument. Would that be ok for you?
All you're actually doing in this code is adding a function to register
a new type of regulator which is exactly equivalent to what the existing
regulators provide - there's nothing particularly wrong with the helper
function but defining an entirely new regulator type for it doesn't seem
useful.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Paul Mundt <lethal@linux-sh.org>,
Tony Lindgren <tony@atomide.com>,
Mike Frysinger <vapier@gentoo.org>,
linux-sh@vger.kernel.org, linux-omap@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] regulator: Provide dummy supply support
Date: Sat, 29 Oct 2011 17:42:02 +0000 [thread overview]
Message-ID: <20111029174202.GA9646@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20111028224757.GG23421@pengutronix.de>
On Sat, Oct 29, 2011 at 12:47:57AM +0200, Sascha Hauer wrote:
> My main concern with the fixed regulator is that it needs quite much
> boilerplate code just to say that we have no regulator at all for a
> given device. That could also be handled with a helper function which
> registers a fixed regulator and only takes the regulator_consumer_supply
> as an argument. Would that be ok for you?
All you're actually doing in this code is adding a function to register
a new type of regulator which is exactly equivalent to what the existing
regulators provide - there's nothing particularly wrong with the helper
function but defining an entirely new regulator type for it doesn't seem
useful.
next prev parent reply other threads:[~2011-10-29 17:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 20:26 [PATCH] regulator: provide dummy supply support Sascha Hauer
2011-10-28 20:26 ` Sascha Hauer
2011-10-28 20:26 ` [PATCH] regulator: Provide " Sascha Hauer
2011-10-28 20:26 ` Sascha Hauer
2011-10-28 21:59 ` Mark Brown
2011-10-28 21:59 ` Mark Brown
2011-10-28 22:47 ` Sascha Hauer
2011-10-28 22:47 ` Sascha Hauer
2011-10-28 23:16 ` Mike Frysinger
2011-10-28 23:16 ` Mike Frysinger
2011-10-29 17:42 ` Mark Brown [this message]
2011-10-29 17:42 ` Mark Brown
2011-11-01 17:50 ` Mike Frysinger
2011-11-01 17:50 ` Mike Frysinger
2011-11-01 18:27 ` Mark Brown
2011-11-01 18:27 ` Mark Brown
2011-11-02 10:03 ` Sascha Hauer
2011-11-02 10:03 ` Sascha Hauer
2011-11-02 10:41 ` Mark Brown
2011-11-02 10:41 ` Mark Brown
2011-11-02 14:29 ` Sascha Hauer
2011-11-02 14:29 ` Sascha Hauer
2011-10-28 21:57 ` [PATCH] regulator: provide " Mark Brown
2011-10-28 21:57 ` Mark Brown
2011-10-28 23:22 ` Mike Frysinger
2011-10-28 23:22 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111029174202.GA9646@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=lethal@linux-sh.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lrg@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=tony@atomide.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.