* [PATCH] mmc: omap_hsmmc: fix compile break
@ 2011-10-29 23:44 Vikram Pandita
2011-10-30 0:39 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Vikram Pandita @ 2011-10-29 23:44 UTC (permalink / raw)
To: linux-omap; +Cc: Vikram Pandita
From: Vikram Pandita <vikram.pandita@ti.com>
omap_hsmmc.c: In function 'omap_hsmmc_protect_card':
omap_hsmmc.c:1273: error: 'pr_info' undeclared (first use in this function)
omap_hsmmc.c:1273: error: (Each undeclared identifier is reported only once
omap_hsmmc.c:1273: error: for each function it appears in.)
omap_hsmmc.c:1273: error: expected ';' before string constant
omap_hsmmc.c:1275: error: expected statement before ')' token
Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
---
drivers/mmc/host/omap_hsmmc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index e8ff123..101cd31 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1270,7 +1270,7 @@ static void omap_hsmmc_protect_card(struct omap_hsmmc_host *host)
}
} else {
if (!host->protect_card) {
- pr_info"%s: cover is open, "
+ pr_info("%s: cover is open, "
"card is now inaccessible\n",
mmc_hostname(host->mmc));
host->protect_card = 1;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: omap_hsmmc: fix compile break
2011-10-29 23:44 [PATCH] mmc: omap_hsmmc: fix compile break Vikram Pandita
@ 2011-10-30 0:39 ` Marek Vasut
2011-10-30 6:24 ` Pandita, Vikram
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2011-10-30 0:39 UTC (permalink / raw)
To: Vikram Pandita; +Cc: linux-omap
> From: Vikram Pandita <vikram.pandita@ti.com>
>
> omap_hsmmc.c: In function 'omap_hsmmc_protect_card':
> omap_hsmmc.c:1273: error: 'pr_info' undeclared (first use in this function)
> omap_hsmmc.c:1273: error: (Each undeclared identifier is reported only once
> omap_hsmmc.c:1273: error: for each function it appears in.)
> omap_hsmmc.c:1273: error: expected ';' before string constant
> omap_hsmmc.c:1275: error: expected statement before ')' token
>
> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> ---
> drivers/mmc/host/omap_hsmmc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index e8ff123..101cd31 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -1270,7 +1270,7 @@ static void omap_hsmmc_protect_card(struct
> omap_hsmmc_host *host) }
> } else {
> if (!host->protect_card) {
> - pr_info"%s: cover is open, "
> + pr_info("%s: cover is open, "
> "card is now inaccessible\n",
> mmc_hostname(host->mmc));
> host->protect_card = 1;
Hey,
please care to check mailing list next time before you submit patch. This is
already fixed for about five hours now. Actually, the last patch submitted to
the mailing list fixes exactly this problem:
[PATCH] omap_hsmmc: fix missing parenthesis in pr_info
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: omap_hsmmc: fix compile break
2011-10-30 0:39 ` Marek Vasut
@ 2011-10-30 6:24 ` Pandita, Vikram
0 siblings, 0 replies; 3+ messages in thread
From: Pandita, Vikram @ 2011-10-30 6:24 UTC (permalink / raw)
To: Marek Vasut; +Cc: linux-omap
On Sat, Oct 29, 2011 at 5:39 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
>
> > From: Vikram Pandita <vikram.pandita@ti.com>
> >
> > omap_hsmmc.c: In function 'omap_hsmmc_protect_card':
> > omap_hsmmc.c:1273: error: 'pr_info' undeclared (first use in this function)
> > omap_hsmmc.c:1273: error: (Each undeclared identifier is reported only once
> > omap_hsmmc.c:1273: error: for each function it appears in.)
> > omap_hsmmc.c:1273: error: expected ';' before string constant
> > omap_hsmmc.c:1275: error: expected statement before ')' token
> >
> > Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> > ---
> > drivers/mmc/host/omap_hsmmc.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> > index e8ff123..101cd31 100644
> > --- a/drivers/mmc/host/omap_hsmmc.c
> > +++ b/drivers/mmc/host/omap_hsmmc.c
> > @@ -1270,7 +1270,7 @@ static void omap_hsmmc_protect_card(struct
> > omap_hsmmc_host *host) }
> > } else {
> > if (!host->protect_card) {
> > - pr_info"%s: cover is open, "
> > + pr_info("%s: cover is open, "
> > "card is now inaccessible\n",
> > mmc_hostname(host->mmc));
> > host->protect_card = 1;
>
> Hey,
>
> please care to check mailing list next time before you submit patch.
Cool down sir, no need to sound like hell broke loose.
If its already there, i may have missed it.
Please ignore.
> This is
> already fixed for about five hours now. Actually, the last patch submitted to
> the mailing list fixes exactly this problem:
>
> [PATCH] omap_hsmmc: fix missing parenthesis in pr_info
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-30 6:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-29 23:44 [PATCH] mmc: omap_hsmmc: fix compile break Vikram Pandita
2011-10-30 0:39 ` Marek Vasut
2011-10-30 6:24 ` Pandita, Vikram
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.