From: nikai@nikai.net (Nicolas Kaiser)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [TRIVIAL] ARM: pxa: Fix typo 'CONFIG_BACKLIGHT_PWM__MODULE'
Date: Sun, 30 Oct 2011 10:23:31 +0100 [thread overview]
Message-ID: <20111030102331.682dfd6e@absol.kitzblitz> (raw)
In-Reply-To: <201110300035.27985.marek.vasut@gmail.com>
* Marek Vasut <marek.vasut@gmail.com>:
> > On Tue, 11 Oct 2011, Paul Bolle wrote:
> > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > > ---
> > > Untested (I don't think I've got the hardware, nor have I got the
> > > toolchain at hand, etc.).
> > >
> > > arch/arm/mach-pxa/colibri-pxa270-income.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-pxa/colibri-pxa270-income.c
> > > b/arch/arm/mach-pxa/colibri-pxa270-income.c index 80538b8..248804b
> > > 100644
> > > --- a/arch/arm/mach-pxa/colibri-pxa270-income.c
> > > +++ b/arch/arm/mach-pxa/colibri-pxa270-income.c
> > > @@ -183,7 +183,7 @@ static inline void income_lcd_init(void) {}
> > >
> > > /***********************************************************************
> > > *******
> > >
> > > * Backlight
> > > ***********************************************************************
> > > *******/
> > >
> > > -#if defined(CONFIG_BACKLIGHT_PWM) ||
> > > defined(CONFIG_BACKLIGHT_PWM__MODULE) +#if defined(CONFIG_BACKLIGHT_PWM)
> > > || defined(CONFIG_BACKLIGHT_PWM_MODULE)
> > >
> > > static struct platform_pwm_backlight_data income_backlight_data = {
> > >
> > > .pwm_id = 0,
> > > .max_brightness = 0x3ff,
> >
> > I'd like to have this at least compile-tested, adding some CCs.
>
> The change is visually ok, add my:
>
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
I now remember you already acked this change last year:
https://lkml.org/lkml/2010/12/4/41
Sorry that I forgot to resend the patch.
Best regards,
Nicolas Kaiser
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Kaiser <nikai@nikai.net>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: Paul Bolle <pebolle@tiscali.nl>,
linux-kernel@vger.kernel.org, Eric Miao <eric.y.miao@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH] [TRIVIAL] ARM: pxa: Fix typo 'CONFIG_BACKLIGHT_PWM__MODULE'
Date: Sun, 30 Oct 2011 10:23:31 +0100 [thread overview]
Message-ID: <20111030102331.682dfd6e@absol.kitzblitz> (raw)
In-Reply-To: <201110300035.27985.marek.vasut@gmail.com>
* Marek Vasut <marek.vasut@gmail.com>:
> > On Tue, 11 Oct 2011, Paul Bolle wrote:
> > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > > ---
> > > Untested (I don't think I've got the hardware, nor have I got the
> > > toolchain at hand, etc.).
> > >
> > > arch/arm/mach-pxa/colibri-pxa270-income.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-pxa/colibri-pxa270-income.c
> > > b/arch/arm/mach-pxa/colibri-pxa270-income.c index 80538b8..248804b
> > > 100644
> > > --- a/arch/arm/mach-pxa/colibri-pxa270-income.c
> > > +++ b/arch/arm/mach-pxa/colibri-pxa270-income.c
> > > @@ -183,7 +183,7 @@ static inline void income_lcd_init(void) {}
> > >
> > > /***********************************************************************
> > > *******
> > >
> > > * Backlight
> > > ***********************************************************************
> > > *******/
> > >
> > > -#if defined(CONFIG_BACKLIGHT_PWM) ||
> > > defined(CONFIG_BACKLIGHT_PWM__MODULE) +#if defined(CONFIG_BACKLIGHT_PWM)
> > > || defined(CONFIG_BACKLIGHT_PWM_MODULE)
> > >
> > > static struct platform_pwm_backlight_data income_backlight_data = {
> > >
> > > .pwm_id = 0,
> > > .max_brightness = 0x3ff,
> >
> > I'd like to have this at least compile-tested, adding some CCs.
>
> The change is visually ok, add my:
>
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
I now remember you already acked this change last year:
https://lkml.org/lkml/2010/12/4/41
Sorry that I forgot to resend the patch.
Best regards,
Nicolas Kaiser
next prev parent reply other threads:[~2011-10-30 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 15:31 [PATCH] [TRIVIAL] ARM: pxa: Fix typo 'CONFIG_BACKLIGHT_PWM__MODULE' Paul Bolle
2011-10-13 8:25 ` Jiri Kosina
2011-10-29 19:28 ` Jiri Kosina
2011-10-29 19:28 ` Jiri Kosina
2011-10-29 22:35 ` Marek Vasut
2011-10-29 22:35 ` Marek Vasut
2011-10-30 9:23 ` Nicolas Kaiser [this message]
2011-10-30 9:23 ` Nicolas Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111030102331.682dfd6e@absol.kitzblitz \
--to=nikai@nikai.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.