[Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35460

Eugeni Dodonov <eugeni@dodonov.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|chris@chris-wilson.co.uk    |dri-devel@lists.freedesktop
                   |                            |.org

--- Comment #6 from Eugeni Dodonov <eugeni@dodonov.net> 2011-09-08 15:56:11 PDT ---
This issue is affecting a hardware component which is not being actively worked
on anymore.

Moving the assignee to the dri-devel list as contact, to give this issue a
better coverage.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35460

Chris Wilson <chris@chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WORKSFORME

--- Comment #7 from Chris Wilson <chris@chris-wilson.co.uk> 2011-10-30 05:44:20 PDT ---
I've just tried to reproduce this running firefox+chromium+others under e17
using SNA. I'm pretty certain this was the tiling bugs we fixed early.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35460

--- Comment #8 from Bruno <bonbons67@internet.lu> 2011-10-30 05:55:23 PDT ---
(In reply to comment #7)
> I've just tried to reproduce this running firefox+chromium+others under e17
> using SNA. I'm pretty certain this was the tiling bugs we fixed early.

I've not seen them recently either, except for sporadically a pixel line with
with white/gray pixels in the e17 cursor. (always at same place of the cursor,
more or less middle in height).
Might be there is one tiling bug remaining around cursor handling.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Re: [Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[Daniel Vetter]

> --- Comment #8 from Bruno <bonbons67@internet.lu> 2011-10-30 05:55:23 PDT ---
> I've not seen them recently either, except for sporadically a pixel line with
> with white/gray pixels in the e17 cursor. (always at same place of the cursor,
> more or less middle in height).
> Might be there is one tiling bug remaining around cursor handling.

Cursors on gen2 are stored in physical mem. On a quick lock we're indeed
missing the clflush that should be there. Let me whip up a patch.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

[Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35460

--- Comment #9 from Daniel Vetter <daniel@ffwll.ch> 2011-10-30 06:44:19 PDT ---
> --- Comment #8 from Bruno <bonbons67@internet.lu> 2011-10-30 05:55:23 PDT ---
> I've not seen them recently either, except for sporadically a pixel line with
> with white/gray pixels in the e17 cursor. (always at same place of the cursor,
> more or less middle in height).
> Might be there is one tiling bug remaining around cursor handling.

Cursors on gen2 are stored in physical mem. On a quick lock we're indeed
missing the clflush that should be there. Let me whip up a patch.
-Daniel

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35460

--- Comment #10 from Daniel Vetter <daniel@ffwll.ch> 2011-10-30 06:46:37 PDT ---
Created attachment 52913
  --> https://bugs.freedesktop.org/attachment.cgi?id=52913
clflush phys objects to fix cursor corruptions

Test-feedback highly appreciated.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35460

Daniel Vetter <daniel@ffwll.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52913|0                           |1
        is obsolete|                            |

--- Comment #11 from Daniel Vetter <daniel@ffwll.ch> 2011-10-30 08:42:04 PDT ---
Created attachment 52920
  --> https://bugs.freedesktop.org/attachment.cgi?id=52920
clflush phys objects to fix cursor corruptions

Chris Wilson pointed out that I'm missing memory barriers.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35460

--- Comment #12 from Bruno <bonbons67@internet.lu> 2011-11-02 11:24:34 PDT ---
(In reply to comment #10 with patch from comment #11)
> Created attachment 52920 [details] [review]
> 
> Test-feedback highly appreciated.

Running now for two days with the patch, no negative effect seen though some
more time will be needed to produce a solid answer whether it fixes the cursors
as the corruption is not that regular (at least no noticed any cursor
corruption since I applied the patch).

Will report back in a week or so unless I see corruption in which case I will
report earlier.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35460

--- Comment #13 from Bruno <bonbons67@internet.lu> 2011-11-12 02:39:23 PST ---
A good week later I've not seen the cursor corruptions nor other issues.
Please apply patch in attachment 52920 with
  Tested-and-reported-by: Bruno Prémont <bonbons@linux-vserver.org>

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35460

Daniel Vetter <daniel@ffwll.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52920|0                           |1
        is obsolete|                            |

--- Comment #14 from Daniel Vetter <daniel@ffwll.ch> 2011-11-29 09:30:35 PST ---
Created attachment 53954
  --> https://bugs.freedesktop.org/attachment.cgi?id=53954
use wmb to flush the wc cache

Hi Bruno, can you please test whether this patch works, too. I think this is
the better solution, on reconsideration the last patch is a bit confusing and
might fix the issue just as a side-effect.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35460

--- Comment #15 from Bruno <bonbons67@internet.lu> 2011-12-08 01:50:04 PST ---
(In reply to comment #14)
> Created attachment 53954 [details] [review]
> use wmb to flush the wc cache
> 
> Hi Bruno, can you please test whether this patch works, too. I think this is
> the better solution, on reconsideration the last patch is a bit confusing and
> might fix the issue just as a side-effect.

Hi Daniel,

Running for a week now with this patch instead of the other one and have not
seen cursor corruptions.

Thanks for your efforts!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35460

--- Comment #16 from Bruno <bonbons67@internet.lu> 2011-12-09 06:46:26 PST ---
(In reply to comment #15 and comment #14 with attachment 53954)
> > use wmb to flush the wc cache
>
> Running for a week now with this patch instead of the other one and have not
> seen cursor corruptions.

Well, today I had the 8-pixel-line curruption on a cursor and interestingly it
survived cursor switches between enlightenment (colorful arrow - corrupted) and
gnumeric (cell '+' cursor), but passing over claws-mail caused enlightenment
cursor to no have corruption enymore.

Does the hardware store multiple cursors or somehow have multiple cursor
buffers around which can get corrupted and remain corrupted (double-buffering
on cursors)?

Bruno

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35460

--- Comment #17 from Chris Wilson <chris@chris-wilson.co.uk> 2011-12-09 07:25:13 PST ---
No, we don't buffer cursors. A single cursor bo is updated every time its image
changes. (Whilst possible, I don't it is an interesting optimisation to cache
the bo for a variety of cursors.)

This could just be a bad bit of RAM, bad cache, or signs of incoherency... Can
you retry Daniel's original overkill patch and see if this corruption ever
turns up? Though I think we can safely say that the current mb is an
improvement.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35460] [855GM] Corruptions with linux-2.6.38 & xf-video-intel-2.14.901

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35460

--- Comment #18 from Bruno <bonbons67@internet.lu> 2012-01-05 13:41:16 PST ---
(In reply to comment #17)
> No, we don't buffer cursors. A single cursor bo is updated every time its image
> changes. (Whilst possible, I don't it is an interesting optimisation to cache
> the bo for a variety of cursors.)
> 
> This could just be a bad bit of RAM, bad cache, or signs of incoherency... Can
> you retry Daniel's original overkill patch and see if this corruption ever
> turns up? Though I think we can safely say that the current mb is an
> improvement.

The overkill patch also has the corrupted cursor happen sporadically.

As the corrupted cursor survives cursor shape switches (e.g. on moving across
windows) it must be some intermediate buffer that gets filled with corrupted
data and stays that way until recycled.
I don't know if/who of enlightenment or xorg-server does the caching (as you
say intel driver doesn't do it explicitly).

It seems to affect only the high-color cursors (at least I haven't seen
corruptions for black&white ones) so it could be some recoding missing a
barrier.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.