From: Oleg Nesterov <oleg@redhat.com>
To: Frantisek Hrbata <fhrbata@redhat.com>
Cc: rientjes@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
kosaki.motohiro@jp.fujitsu.com, minchan.kim@gmail.com,
stable@kernel.org, eteo@redhat.com, pmatouse@redhat.com
Subject: Re: [PATCH v2] oom: fix integer overflow of points in oom_badness
Date: Mon, 31 Oct 2011 18:42:38 +0100 [thread overview]
Message-ID: <20111031174238.GA7344@redhat.com> (raw)
In-Reply-To: <1320076569-23872-1-git-send-email-fhrbata@redhat.com>
On 10/31, Frantisek Hrbata wrote:
>
> unsigned int oom_badness(struct task_struct *p, struct mem_cgroup *mem,
> const nodemask_t *nodemask, unsigned long totalpages)
> {
> - int points;
> + long points;
Good catch. Imho this is the stable material.
Acked-by: Oleg Nesterov <oleg@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Frantisek Hrbata <fhrbata@redhat.com>
Cc: rientjes@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
kosaki.motohiro@jp.fujitsu.com, minchan.kim@gmail.com,
stable@kernel.org, eteo@redhat.com, pmatouse@redhat.com
Subject: Re: [PATCH v2] oom: fix integer overflow of points in oom_badness
Date: Mon, 31 Oct 2011 18:42:38 +0100 [thread overview]
Message-ID: <20111031174238.GA7344@redhat.com> (raw)
In-Reply-To: <1320076569-23872-1-git-send-email-fhrbata@redhat.com>
On 10/31, Frantisek Hrbata wrote:
>
> unsigned int oom_badness(struct task_struct *p, struct mem_cgroup *mem,
> const nodemask_t *nodemask, unsigned long totalpages)
> {
> - int points;
> + long points;
Good catch. Imho this is the stable material.
Acked-by: Oleg Nesterov <oleg@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-31 17:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 8:14 [PATCH] oom: fix integer overflow of points in oom_badness Frantisek Hrbata
2011-10-31 8:14 ` Frantisek Hrbata
2011-10-31 15:28 ` Oleg Nesterov
2011-10-31 15:28 ` Oleg Nesterov
2011-10-31 15:49 ` Frantisek Hrbata
2011-10-31 15:49 ` Frantisek Hrbata
2011-10-31 15:56 ` [PATCH v2] " Frantisek Hrbata
2011-10-31 15:56 ` Frantisek Hrbata
2011-10-31 14:18 ` KOSAKI Motohiro
2011-10-31 14:18 ` KOSAKI Motohiro
2011-10-31 17:42 ` Oleg Nesterov [this message]
2011-10-31 17:42 ` Oleg Nesterov
2011-10-31 18:22 ` David Rientjes
2011-10-31 18:22 ` David Rientjes
2011-12-02 17:45 ` [PATCH v2 RESEND] " Frantisek Hrbata
2011-12-02 17:45 ` Frantisek Hrbata
2011-12-02 19:00 ` Greg KH
2011-12-02 19:00 ` Greg KH
2011-12-02 20:46 ` Frantisek Hrbata
2011-12-02 20:46 ` Frantisek Hrbata
2011-12-08 3:44 ` David Rientjes
2011-12-08 3:44 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031174238.GA7344@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=eteo@redhat.com \
--cc=fhrbata@redhat.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=pmatouse@redhat.com \
--cc=rientjes@google.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.