All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tull Alan-R80115 <R80115@freescale.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC don't clobber platform DMA driver ops
Date: Tue, 1 Nov 2011 18:49:56 +0000	[thread overview]
Message-ID: <20111101184955.GJ10029@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <9E5C29D1DC97674D8FB0F7D26508F7861F05DB@039-SN1MPN1-005.039d.mgd.msft.net>

On Tue, Nov 01, 2011 at 06:46:52PM +0000, Tull Alan-R80115 wrote:

> This patch creates and populates a ops struct for each call to soc_pcm_new.

This isn't very idiomatic - a much more idiomatic solution would be to
add new indirection functions which do the lookups.  While it's probably
not going to make much difference for most things there's operations
like ioctl() which definitely don't look at all DMA specific in there.

  parent reply	other threads:[~2011-11-01 18:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-01 18:45 [PATCH] ASoC don't clobber platform DMA driver ops Alan Tull
     [not found] ` <9E5C29D1DC97674D8FB0F7D26508F7861F05DB@039-SN1MPN1-005.039d.mgd.msft.net>
2011-11-01 18:49   ` Mark Brown [this message]
     [not found]     ` <9E5C29D1DC97674D8FB0F7D26508F7861F0620@039-SN1MPN1-005.039d.mgd.msft.net>
2011-11-01 19:11       ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2011-11-01 21:05 Alan Tull
2011-11-02  3:40 ` Tabi Timur-B04825
2011-11-02 10:24   ` Mark Brown
2011-11-10 11:43 ` Mark Brown
2011-11-10 15:14   ` r80115
2011-11-10 15:16     ` Mark Brown
2011-11-10 15:20       ` r80115
2011-11-10 15:25         ` Mark Brown
2011-11-15 15:59 Alan Tull
2011-11-15 16:56 ` Tabi Timur-B04825
2011-11-15 17:22   ` r80115

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111101184955.GJ10029@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=R80115@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.