All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] net: Add back alignment for size for __alloc_skb
Date: Wed, 2 Nov 2011 16:19:17 -0700	[thread overview]
Message-ID: <20111102231917.GN31337@atomide.com> (raw)
In-Reply-To: <20111102.191716.1682282796914825621.davem@davemloft.net>

* David Miller <davem@davemloft.net> [111102 15:42]:
> c> 
> > The issue is calculation of skb->end, which is based upon calculated
> > 'size' variable.
> > 
> > skb->end determines alignment of skb_shared_info, which is where the
> > alignment problem is occuring for Tony.
> 
> Right, and SMP_CACHE_BYTES setting should save us in any case.
> 
> For ARM, SMP_CACHE_BYTES seems to be set to L1_CACHE_BYTES which in
> turn is set via ARM_L1_CACHE_SHIFT which can be set seemingly to any
> value but the defaults are 5 and 6 which should be OK.
> 
> So unless Tony is using a non-standard setting of ARM_L1_CACHE_SHIFT,
> this report is a bit mysterious.

This is happening at least with omap1_defconfig. In that case we have
ARM_L1_CACHE_SHIFT=5.

Regards,

Tony

  reply	other threads:[~2011-11-02 23:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-02 22:43 [PATCH] net: Add back alignment for size for __alloc_skb Tony Lindgren
2011-11-02 22:55 ` Eric Dumazet
2011-11-02 23:09   ` David Miller
2011-11-02 23:13     ` David Miller
2011-11-02 23:14     ` Eric Dumazet
2011-11-02 23:17       ` David Miller
2011-11-02 23:19         ` Tony Lindgren [this message]
2011-11-02 23:20           ` Eric Dumazet
2011-11-02 23:24             ` Tony Lindgren
2011-11-02 23:31               ` Eric Dumazet
2011-11-02 23:40                 ` Tony Lindgren
2011-11-03 22:09                   ` David Miller
2011-11-02 23:22           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111102231917.GN31337@atomide.com \
    --to=tony@atomide.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.