From: Eric Dumazet <eric.dumazet@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] net: Add back alignment for size for __alloc_skb
Date: Thu, 03 Nov 2011 00:31:19 +0100 [thread overview]
Message-ID: <4EB1D2C7.2070700@gmail.com> (raw)
In-Reply-To: <20111102232403.GO31337@atomide.com>
On 03/11/2011 00:24, Tony Lindgren wrote:
>
> Seems to be SLOB for omap1_defconfig.
>
> Tony
OK this makes sense now
Your patch is absolutely needed, I completely forgot about SLOB :(
since, kmalloc(386) on SLOB gives exactly ksize=386 bytes, not nearest
power of two.
[ 60.305763] malloc(size=385)->ffff880112c11e38 ksize=386 -> nsize=2
[ 60.305921] malloc(size=385)->ffff88007c92ce28 ksize=386 -> nsize=2
[ 60.306898] malloc(size=656)->ffff88007c44ad28 ksize=656 -> nsize=272
[ 60.325385] malloc(size=656)->ffff88007c575868 ksize=656 -> nsize=272
[ 60.325531] malloc(size=656)->ffff88011c777230 ksize=656 -> nsize=272
[ 60.325701] malloc(size=656)->ffff880114011008 ksize=656 -> nsize=272
[ 60.346716] malloc(size=385)->ffff880114142008 ksize=386 -> nsize=2
[ 60.346900] malloc(size=385)->ffff88011c777690 ksize=386 -> nsize=2
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Thanks !
next prev parent reply other threads:[~2011-11-02 23:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 22:43 [PATCH] net: Add back alignment for size for __alloc_skb Tony Lindgren
2011-11-02 22:55 ` Eric Dumazet
2011-11-02 23:09 ` David Miller
2011-11-02 23:13 ` David Miller
2011-11-02 23:14 ` Eric Dumazet
2011-11-02 23:17 ` David Miller
2011-11-02 23:19 ` Tony Lindgren
2011-11-02 23:20 ` Eric Dumazet
2011-11-02 23:24 ` Tony Lindgren
2011-11-02 23:31 ` Eric Dumazet [this message]
2011-11-02 23:40 ` Tony Lindgren
2011-11-03 22:09 ` David Miller
2011-11-02 23:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB1D2C7.2070700@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.