From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
spi-devel-general@lists.sourceforge.net,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2 v4] atmel/spi: fix missing probe
Date: Thu, 3 Nov 2011 22:47:56 +0000 [thread overview]
Message-ID: <20111103224756.GT12913@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1320343060-18710-1-git-send-email-plagnioj@jcrosoft.com>
On Fri, Nov 04, 2011 at 01:57:40AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Commit 940ab889 "drivercore: Add helper macro for platform_driver boilerplate"
> converted this driver to use module_platform_driver, but due to the use
> of platform_driver_probe(), this resulted in the call to atmel_spi_probe being
> lost. Place the call to this function into the driver structure.
Let me say again, this should not be the first patch in the series.
If you're trying to fix a bug don't introduce a new bug by fixing
another bug.
If you did this with, say, the VM or FS subsystem, you'll have this
patch reverted.
Moreover, it's bad practice to do "fixes" in this way, especially when
it's trivial to do it _right_ as I've already mentioned several times.
I still maintain that it should be _one_ patch fixing these issues, not
two.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2 v4] atmel/spi: fix missing probe
Date: Thu, 3 Nov 2011 22:47:56 +0000 [thread overview]
Message-ID: <20111103224756.GT12913@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1320343060-18710-1-git-send-email-plagnioj@jcrosoft.com>
On Fri, Nov 04, 2011 at 01:57:40AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Commit 940ab889 "drivercore: Add helper macro for platform_driver boilerplate"
> converted this driver to use module_platform_driver, but due to the use
> of platform_driver_probe(), this resulted in the call to atmel_spi_probe being
> lost. Place the call to this function into the driver structure.
Let me say again, this should not be the first patch in the series.
If you're trying to fix a bug don't introduce a new bug by fixing
another bug.
If you did this with, say, the VM or FS subsystem, you'll have this
patch reverted.
Moreover, it's bad practice to do "fixes" in this way, especially when
it's trivial to do it _right_ as I've already mentioned several times.
I still maintain that it should be _one_ patch fixing these issues, not
two.
next prev parent reply other threads:[~2011-11-03 22:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 17:41 [PATCH 1/2] atmel/spi: fix missing probe Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 17:41 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 17:41 ` [PATCH 2/2] atmel/spi: fix section missmatch Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 17:41 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1320342082-18573-1-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
2011-11-03 17:50 ` [PATCH 1/2] atmel/spi: fix missing probe Daniel Mack
2011-11-03 17:50 ` Daniel Mack
2011-11-03 17:56 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 17:56 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 17:57 ` [PATCH 1/2 v4] " Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 17:57 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-03 22:47 ` Russell King - ARM Linux [this message]
2011-11-03 22:47 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111103224756.GT12913@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.