From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Padmavathi Venna <padma.v@samsung.com>
Cc: padma.kvr@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
ben-linux@fluff.org, linux@arm.linux.org.uk,
ian@opensource.wolfsonmicro.com, dp@opensource.wolfsonmicro.com,
jassisinghbrar@gmail.com
Subject: Re: [PATCH 6/6] ARM: S3C64XX: Modified according to SPI consolidation work.
Date: Fri, 4 Nov 2011 10:57:11 +0000 [thread overview]
Message-ID: <20111104105710.GA12134@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1320410634-10788-7-git-send-email-padma.v@samsung.com>
On Fri, Nov 04, 2011 at 08:43:54AM -0400, Padmavathi Venna wrote:
> +#ifdef CONFIG_S3C64XX_DEV_SPI0
> +static struct s3c64xx_spi_info crag6410_spi0_pdata __initdata = {
> + .cfg_gpio = s3c64xx_spi0_cfg_gpio,
> + .fifo_lvl_mask = 0x7f,
> + .rx_lvl_offset = 13,
> + .tx_st_done = 21,
> +};
> +#endif
It seems like a step backwards to have all this stuff in the individual
machines - most of this (everything except cfg_gpio pretty much) is a
property of the SoC silicon so should be somewhere central for the SoC.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] ARM: S3C64XX: Modified according to SPI consolidation work.
Date: Fri, 4 Nov 2011 10:57:11 +0000 [thread overview]
Message-ID: <20111104105710.GA12134@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1320410634-10788-7-git-send-email-padma.v@samsung.com>
On Fri, Nov 04, 2011 at 08:43:54AM -0400, Padmavathi Venna wrote:
> +#ifdef CONFIG_S3C64XX_DEV_SPI0
> +static struct s3c64xx_spi_info crag6410_spi0_pdata __initdata = {
> + .cfg_gpio = s3c64xx_spi0_cfg_gpio,
> + .fifo_lvl_mask = 0x7f,
> + .rx_lvl_offset = 13,
> + .tx_st_done = 21,
> +};
> +#endif
It seems like a step backwards to have all this stuff in the individual
machines - most of this (everything except cfg_gpio pretty much) is a
property of the SoC silicon so should be somewhere central for the SoC.
next prev parent reply other threads:[~2011-11-04 10:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 12:43 [PATCH 0/6] SPI platform device consolidation Padmavathi Venna
2011-11-04 12:43 ` Padmavathi Venna
2011-11-04 12:43 ` [PATCH 1/6] ARM: SAMSUNG: Consolidation of SPI platform devices to plat-samsung Padmavathi Venna
2011-11-04 12:43 ` Padmavathi Venna
2011-11-15 7:08 ` Kukjin Kim
2011-11-15 7:08 ` Kukjin Kim
2011-11-17 1:39 ` padma venkat
2011-11-17 1:39 ` padma venkat
2011-11-04 12:43 ` [PATCH 2/6] ARM: S3C64XX: Modified files for SPI consolidation work Padmavathi Venna
2011-11-04 12:43 ` Padmavathi Venna
2011-11-04 12:43 ` [PATCH 3/6] ARM: S5PC100: " Padmavathi Venna
2011-11-04 12:43 ` Padmavathi Venna
2011-11-04 12:43 ` [PATCH 4/6] ARM: S5P64X0: " Padmavathi Venna
2011-11-04 12:43 ` Padmavathi Venna
2011-11-04 12:43 ` [PATCH 5/6] ARM: S5PV210: " Padmavathi Venna
2011-11-04 12:43 ` Padmavathi Venna
2011-11-04 12:43 ` [PATCH 6/6] ARM: S3C64XX: Modified according to " Padmavathi Venna
2011-11-04 12:43 ` Padmavathi Venna
2011-11-04 10:57 ` Mark Brown [this message]
2011-11-04 10:57 ` Mark Brown
[not found] ` <CAAgF-Bcj3vm50YOU4Sq4cGrOE8EHixjOuFrQq-MR6FVLf7Dekg@mail.gmail.com>
2011-11-15 7:09 ` Kukjin Kim
2011-11-15 7:09 ` Kukjin Kim
2011-11-17 1:41 ` padma venkat
2011-11-17 1:41 ` padma venkat
2011-11-05 3:32 ` [PATCH 0/6] SPI platform device consolidation Kukjin Kim
2011-11-05 3:32 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111104105710.GA12134@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ben-linux@fluff.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=ian@opensource.wolfsonmicro.com \
--cc=jassisinghbrar@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.