From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
kernel-janitors@vger.kernel.org, xen-devel@lists.xensource.com,
virtualization@lists.linux-foundation.org
Subject: Re: [patch 1/2] xen-gntalloc: integer overflow in
Date: Fri, 04 Nov 2011 18:35:54 +0000 [thread overview]
Message-ID: <20111104183554.GA1616@phenom.dumpdata.com> (raw)
In-Reply-To: <20111104182408.GD5796@elgon.mountain>
On Fri, Nov 04, 2011 at 09:24:08PM +0300, Dan Carpenter wrote:
> On 32 bit systems a high value of op.count could lead to an integer
> overflow in the kzalloc() and gref_ids would be smaller than
> expected. If the you triggered another integer overflow in
> "if (gref_size + op.count > limit)" then you'd probably get memory
> corruption inside add_grefs().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Great! Keep them coming! Will push for stable and 3.2.
>
> diff --git a/drivers/xen/gntalloc.c b/drivers/xen/gntalloc.c
> index f6832f4..23c60cf 100644
> --- a/drivers/xen/gntalloc.c
> +++ b/drivers/xen/gntalloc.c
> @@ -280,7 +280,7 @@ static long gntalloc_ioctl_alloc(struct gntalloc_file_private_data *priv,
> goto out;
> }
>
> - gref_ids = kzalloc(sizeof(gref_ids[0]) * op.count, GFP_TEMPORARY);
> + gref_ids = kcalloc(op.count, sizeof(gref_ids[0]), GFP_TEMPORARY);
> if (!gref_ids) {
> rc = -ENOMEM;
> goto out;
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
kernel-janitors@vger.kernel.org, xen-devel@lists.xensource.com,
virtualization@lists.linux-foundation.org
Subject: Re: [patch 1/2] xen-gntalloc: integer overflow in gntalloc_ioctl_alloc()
Date: Fri, 4 Nov 2011 14:35:54 -0400 [thread overview]
Message-ID: <20111104183554.GA1616@phenom.dumpdata.com> (raw)
In-Reply-To: <20111104182408.GD5796@elgon.mountain>
On Fri, Nov 04, 2011 at 09:24:08PM +0300, Dan Carpenter wrote:
> On 32 bit systems a high value of op.count could lead to an integer
> overflow in the kzalloc() and gref_ids would be smaller than
> expected. If the you triggered another integer overflow in
> "if (gref_size + op.count > limit)" then you'd probably get memory
> corruption inside add_grefs().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Great! Keep them coming! Will push for stable and 3.2.
>
> diff --git a/drivers/xen/gntalloc.c b/drivers/xen/gntalloc.c
> index f6832f4..23c60cf 100644
> --- a/drivers/xen/gntalloc.c
> +++ b/drivers/xen/gntalloc.c
> @@ -280,7 +280,7 @@ static long gntalloc_ioctl_alloc(struct gntalloc_file_private_data *priv,
> goto out;
> }
>
> - gref_ids = kzalloc(sizeof(gref_ids[0]) * op.count, GFP_TEMPORARY);
> + gref_ids = kcalloc(op.count, sizeof(gref_ids[0]), GFP_TEMPORARY);
> if (!gref_ids) {
> rc = -ENOMEM;
> goto out;
next prev parent reply other threads:[~2011-11-04 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 18:24 [patch 1/2] xen-gntalloc: integer overflow in gntalloc_ioctl_alloc() Dan Carpenter
2011-11-04 18:24 ` Dan Carpenter
2011-11-04 18:35 ` Konrad Rzeszutek Wilk [this message]
2011-11-04 18:35 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111104183554.GA1616@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.