From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Olof Johansson <olof@lixom.net>
Cc: patches@linaro.org, tony@atomide.com,
devicetree-discuss@lists.ozlabs.org,
Rajendra Nayak <rnayak@ti.com>,
linux-kernel@vger.kernel.org, grant.likely@secretlab.ca,
linux-omap@vger.kernel.org, lrg@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data
Date: Fri, 4 Nov 2011 22:35:19 +0000 [thread overview]
Message-ID: <20111104223518.GC16978@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAOesGMjkcExKXhNN1nFGey=wBie0PQGp2XS_r-5Rr3X0p4eNhg@mail.gmail.com>
On Fri, Nov 04, 2011 at 03:16:12PM -0700, Olof Johansson wrote:
> On Fri, Nov 4, 2011 at 2:46 PM, Mark Brown
> >> Describing that in the device tree using regulator-specifiers
> >> shouldn't be too bad? The LDO will reference the DCDC as the parent
> >> supply (or input or whatever language you prefer). They don't have to
> >> be in the same topology, they will instead be under whatever
> >> controller/bus they are on for control -- i2c, etc.
> > That's not great as it means you've got a separate binding for supplies
> > that happen to be connected to another regulator from that used for
> > other supplies on the device which is particularly confusing in the
> > fairly common case where a regulator chip has multiple supplies. Using
> > the same method for binding all supplies seems much neater.
> I'm not following the above 100%, but I think you are saying that you
> would prefer to describe the regulator / power hierarchy in the
> functional topology instead of how the various regulators and supplies
> are organized on i2c busses and other controllers? And the obvious
> one that would be less than trivial to find a home for would be the
> top-level or freestanding fixed regulators that don't sit on a
> controlling bus.
No, that's not the issue at all. The issue is that we want a single way
of describing the supplies a device has regardless of their function
(which is what the existing stuff does).
Consider the case of a simple regulator with register control. It is
going to have a supply used for the regulator itself and almost
certainly also a separate digital buffer supply used to reference the
digital I/O. It seems bad to specify the first supply in a different
manner to the second, and there are more complex examples where a supply
can be both a regulator input and also a more general purpose supply.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data
Date: Fri, 4 Nov 2011 22:35:19 +0000 [thread overview]
Message-ID: <20111104223518.GC16978@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAOesGMjkcExKXhNN1nFGey=wBie0PQGp2XS_r-5Rr3X0p4eNhg@mail.gmail.com>
On Fri, Nov 04, 2011 at 03:16:12PM -0700, Olof Johansson wrote:
> On Fri, Nov 4, 2011 at 2:46 PM, Mark Brown
> >> Describing that in the device tree using regulator-specifiers
> >> shouldn't be too bad? The LDO will reference the DCDC as the parent
> >> supply (or input or whatever language you prefer). They don't have to
> >> be in the same topology, they will instead be under whatever
> >> controller/bus they are on for control -- i2c, etc.
> > That's not great as it means you've got a separate binding for supplies
> > that happen to be connected to another regulator from that used for
> > other supplies on the device which is particularly confusing in the
> > fairly common case where a regulator chip has multiple supplies. ?Using
> > the same method for binding all supplies seems much neater.
> I'm not following the above 100%, but I think you are saying that you
> would prefer to describe the regulator / power hierarchy in the
> functional topology instead of how the various regulators and supplies
> are organized on i2c busses and other controllers? And the obvious
> one that would be less than trivial to find a home for would be the
> top-level or freestanding fixed regulators that don't sit on a
> controlling bus.
No, that's not the issue at all. The issue is that we want a single way
of describing the supplies a device has regardless of their function
(which is what the existing stuff does).
Consider the case of a simple regulator with register control. It is
going to have a supply used for the regulator itself and almost
certainly also a separate digital buffer supply used to reference the
digital I/O. It seems bad to specify the first supply in a different
manner to the second, and there are more complex examples where a supply
can be both a regulator input and also a more general purpose supply.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Olof Johansson <olof@lixom.net>
Cc: Rajendra Nayak <rnayak@ti.com>,
grant.likely@secretlab.ca, patches@linaro.org, tony@atomide.com,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
lrg@ti.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data
Date: Fri, 4 Nov 2011 22:35:19 +0000 [thread overview]
Message-ID: <20111104223518.GC16978@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAOesGMjkcExKXhNN1nFGey=wBie0PQGp2XS_r-5Rr3X0p4eNhg@mail.gmail.com>
On Fri, Nov 04, 2011 at 03:16:12PM -0700, Olof Johansson wrote:
> On Fri, Nov 4, 2011 at 2:46 PM, Mark Brown
> >> Describing that in the device tree using regulator-specifiers
> >> shouldn't be too bad? The LDO will reference the DCDC as the parent
> >> supply (or input or whatever language you prefer). They don't have to
> >> be in the same topology, they will instead be under whatever
> >> controller/bus they are on for control -- i2c, etc.
> > That's not great as it means you've got a separate binding for supplies
> > that happen to be connected to another regulator from that used for
> > other supplies on the device which is particularly confusing in the
> > fairly common case where a regulator chip has multiple supplies. Using
> > the same method for binding all supplies seems much neater.
> I'm not following the above 100%, but I think you are saying that you
> would prefer to describe the regulator / power hierarchy in the
> functional topology instead of how the various regulators and supplies
> are organized on i2c busses and other controllers? And the obvious
> one that would be less than trivial to find a home for would be the
> top-level or freestanding fixed regulators that don't sit on a
> controlling bus.
No, that's not the issue at all. The issue is that we want a single way
of describing the supplies a device has regardless of their function
(which is what the existing stuff does).
Consider the case of a simple regulator with register control. It is
going to have a supply used for the regulator itself and almost
certainly also a separate digital buffer supply used to reference the
digital I/O. It seems bad to specify the first supply in a different
manner to the second, and there are more complex examples where a supply
can be both a regulator input and also a more general purpose supply.
next prev parent reply other threads:[~2011-11-04 22:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 13:24 [PATCH v4 1/4] regulator: helper routine to extract regulator_init_data Rajendra Nayak
2011-10-27 13:24 ` Rajendra Nayak
2011-10-27 13:24 ` Rajendra Nayak
2011-11-04 20:29 ` Olof Johansson
2011-11-04 20:29 ` Olof Johansson
2011-11-04 20:29 ` Olof Johansson
[not found] ` <20111104202905.GA3918-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2011-11-04 21:14 ` Mark Brown
2011-11-04 21:14 ` Mark Brown
2011-11-04 21:14 ` Mark Brown
2011-11-04 21:22 ` Olof Johansson
2011-11-04 21:22 ` Olof Johansson
2011-11-04 21:22 ` Olof Johansson
2011-11-04 21:29 ` Mark Brown
2011-11-04 21:29 ` Mark Brown
2011-11-04 21:29 ` Mark Brown
2011-11-04 21:34 ` Olof Johansson
2011-11-04 21:34 ` Olof Johansson
2011-11-04 21:34 ` Olof Johansson
2011-11-04 21:46 ` Mark Brown
2011-11-04 21:46 ` Mark Brown
2011-11-04 22:16 ` Olof Johansson
2011-11-04 22:16 ` Olof Johansson
2011-11-04 22:35 ` Mark Brown [this message]
2011-11-04 22:35 ` Mark Brown
2011-11-04 22:35 ` Mark Brown
2011-11-04 22:50 ` Olof Johansson
2011-11-04 22:50 ` Olof Johansson
2011-11-04 22:50 ` Olof Johansson
2011-11-07 6:27 ` Rajendra Nayak
2011-11-07 6:27 ` Rajendra Nayak
[not found] ` <20111104212216.GA5756-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2011-11-07 6:27 ` Rajendra Nayak
2011-11-07 6:27 ` Rajendra Nayak
2011-11-07 6:27 ` Rajendra Nayak
2011-11-07 6:23 ` Rajendra Nayak
2011-11-07 6:23 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111104223518.GC16978@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=olof@lixom.net \
--cc=patches@linaro.org \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.