All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lennart Poettering <mzxreary@0pointer.de>
To: Davidlohr Bueso <dave@gnu.org>
Cc: Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [RFC PATCH] tmpfs: support user quotas
Date: Sun, 6 Nov 2011 23:10:38 +0100	[thread overview]
Message-ID: <20111106221038.GB11672@tango.0pointer.de> (raw)
In-Reply-To: <1320614101.3226.5.camel@offbook>

On Sun, 06.11.11 18:15, Davidlohr Bueso (dave@gnu.org) wrote:

> From: Davidlohr Bueso <dave@gnu.org>
> 
> This patch adds a new RLIMIT_TMPFSQUOTA resource limit to restrict an individual user's quota across all mounted tmpfs filesystems.
> It's well known that a user can easily fill up commonly used directories (like /tmp, /dev/shm) causing programs to break through DoS.

Thanks a lot for this work! One comment without looking at the patch in detail:

> +	if (atomic_long_read(&user->shmem_bytes) + len > 
> +	    rlimit(RLIMIT_TMPFSQUOTA))
> +		return -ENOSPC;

This should be EDQUOT "Disk quota exceeded", not ENOSPC "No space left
on device".

Lennart

-- 
Lennart Poettering - Red Hat, Inc.

WARNING: multiple messages have this Message-ID (diff)
From: Lennart Poettering <mzxreary@0pointer.de>
To: Davidlohr Bueso <dave@gnu.org>
Cc: Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [RFC PATCH] tmpfs: support user quotas
Date: Sun, 6 Nov 2011 23:10:38 +0100	[thread overview]
Message-ID: <20111106221038.GB11672@tango.0pointer.de> (raw)
In-Reply-To: <1320614101.3226.5.camel@offbook>

On Sun, 06.11.11 18:15, Davidlohr Bueso (dave@gnu.org) wrote:

> From: Davidlohr Bueso <dave@gnu.org>
> 
> This patch adds a new RLIMIT_TMPFSQUOTA resource limit to restrict an individual user's quota across all mounted tmpfs filesystems.
> It's well known that a user can easily fill up commonly used directories (like /tmp, /dev/shm) causing programs to break through DoS.

Thanks a lot for this work! One comment without looking at the patch in detail:

> +	if (atomic_long_read(&user->shmem_bytes) + len > 
> +	    rlimit(RLIMIT_TMPFSQUOTA))
> +		return -ENOSPC;

This should be EDQUOT "Disk quota exceeded", not ENOSPC "No space left
on device".

Lennart

-- 
Lennart Poettering - Red Hat, Inc.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-11-06 22:10 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-06 21:15 [RFC PATCH] tmpfs: support user quotas Davidlohr Bueso
2011-11-06 21:15 ` Davidlohr Bueso
2011-11-06 22:10 ` Lennart Poettering [this message]
2011-11-06 22:10   ` Lennart Poettering
2011-11-07  7:31 ` Christoph Hellwig
2011-11-07  7:31   ` Christoph Hellwig
2011-11-07 11:29   ` Lennart Poettering
2011-11-07 11:29     ` Lennart Poettering
2011-11-07 14:20     ` Davidlohr Bueso
2011-11-07 14:20       ` Davidlohr Bueso
2011-11-07 13:58       ` Alan Cox
2011-11-07 13:58         ` Alan Cox
2011-11-07 14:27         ` Kay Sievers
2011-11-07 14:27           ` Kay Sievers
2011-11-07 22:53           ` Alan Cox
2011-11-07 22:53             ` Alan Cox
2011-11-07 22:57             ` Glauber Costa
2011-11-07 22:57               ` Glauber Costa
2011-11-07 23:07             ` Lennart Poettering
2011-11-07 23:07               ` Lennart Poettering
2011-11-07 23:43               ` Alan Cox
2011-11-07 23:43                 ` Alan Cox
2011-11-08  0:25                 ` Lennart Poettering
2011-11-08  0:25                   ` Lennart Poettering
2011-11-08  0:46                   ` Alan Cox
2011-11-08  0:46                     ` Alan Cox
2011-11-07 14:30         ` Lennart Poettering
2011-11-07 14:30           ` Lennart Poettering
2011-11-07 22:15           ` KOSAKI Motohiro
2011-11-07 22:15             ` KOSAKI Motohiro
2011-11-07 22:37             ` Kay Sievers
2011-11-07 22:37               ` Kay Sievers
2011-11-08  0:33               ` KOSAKI Motohiro
2011-11-08  0:33                 ` KOSAKI Motohiro
2011-11-07 23:01           ` Alan Cox
2011-11-07 23:01             ` Alan Cox
2011-11-07  9:11 ` Valdis.Kletnieks
2011-11-07 14:49   ` Davidlohr Bueso
2011-11-07 14:49     ` Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111106221038.GB11672@tango.0pointer.de \
    --to=mzxreary@0pointer.de \
    --cc=akpm@linux-foundation.org \
    --cc=dave@gnu.org \
    --cc=hughd@google.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.