From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Linux PM list <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Kevin Hilman <khilman@ti.com>,
jean.pihet@newoldbits.com
Subject: [PATCH 7/7] PM / Domains: Automatically update overoptimistic latency information
Date: Mon, 07 Nov 2011 00:10:38 +0000 [thread overview]
Message-ID: <201111070110.38976.rjw@sisk.pl> (raw)
In-Reply-To: <201111070101.33960.rjw@sisk.pl>
From: Rafael J. Wysocki <rjw@sisk.pl>
Measure the time of execution of the .start(), .save_state()
and .restore_state() PM domain device callbacks and if the result
is greater than the corresponding latency value stored in the
device's struct generic_pm_domain_data object, replace the inaccurate
value with the measured time.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/base/power/domain.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
Index: linux/drivers/base/power/domain.c
=================================--- linux.orig/drivers/base/power/domain.c
+++ linux/drivers/base/power/domain.c
@@ -32,6 +32,17 @@
__ret; \
})
+#define GENPD_DEV_TIMED_CALLBACK(genpd, type, callback, dev, latency) \
+({ \
+ ktime_t __start = ktime_get(); \
+ type __retval = GENPD_DEV_CALLBACK(genpd, type, callback, dev); \
+ s64 __elapsed = ktime_to_ns(ktime_sub(ktime_get(), __start)); \
+ struct generic_pm_domain_data *__gpd_data = dev_gpd_data(dev); \
+ if (__elapsed > __gpd_data->td.latency) \
+ __gpd_data->td.latency = __elapsed; \
+ __retval; \
+})
+
static LIST_HEAD(gpd_list);
static DEFINE_MUTEX(gpd_list_lock);
@@ -53,17 +64,20 @@ static int genpd_stop_dev(struct generic
static int genpd_start_dev(struct generic_pm_domain *genpd, struct device *dev)
{
- return GENPD_DEV_CALLBACK(genpd, int, start, dev);
+ return GENPD_DEV_TIMED_CALLBACK(genpd, int, start, dev,
+ start_latency_ns);
}
static int genpd_save_dev(struct generic_pm_domain *genpd, struct device *dev)
{
- return GENPD_DEV_CALLBACK(genpd, int, save_state, dev);
+ return GENPD_DEV_TIMED_CALLBACK(genpd, int, save_state, dev,
+ save_state_latency_ns);
}
static int genpd_restore_dev(struct generic_pm_domain *genpd, struct device *dev)
{
- return GENPD_DEV_CALLBACK(genpd, int, restore_state, dev);
+ return GENPD_DEV_TIMED_CALLBACK(genpd, int, restore_state, dev,
+ restore_state_latency_ns);
}
static bool genpd_sd_counter_dec(struct generic_pm_domain *genpd)
WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Linux PM list <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Linux-sh list" <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Kevin Hilman <khilman@ti.com>,
jean.pihet@newoldbits.com
Subject: [PATCH 7/7] PM / Domains: Automatically update overoptimistic latency information
Date: Mon, 7 Nov 2011 01:10:38 +0100 [thread overview]
Message-ID: <201111070110.38976.rjw@sisk.pl> (raw)
In-Reply-To: <201111070101.33960.rjw@sisk.pl>
From: Rafael J. Wysocki <rjw@sisk.pl>
Measure the time of execution of the .start(), .save_state()
and .restore_state() PM domain device callbacks and if the result
is greater than the corresponding latency value stored in the
device's struct generic_pm_domain_data object, replace the inaccurate
value with the measured time.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/base/power/domain.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
Index: linux/drivers/base/power/domain.c
===================================================================
--- linux.orig/drivers/base/power/domain.c
+++ linux/drivers/base/power/domain.c
@@ -32,6 +32,17 @@
__ret; \
})
+#define GENPD_DEV_TIMED_CALLBACK(genpd, type, callback, dev, latency) \
+({ \
+ ktime_t __start = ktime_get(); \
+ type __retval = GENPD_DEV_CALLBACK(genpd, type, callback, dev); \
+ s64 __elapsed = ktime_to_ns(ktime_sub(ktime_get(), __start)); \
+ struct generic_pm_domain_data *__gpd_data = dev_gpd_data(dev); \
+ if (__elapsed > __gpd_data->td.latency) \
+ __gpd_data->td.latency = __elapsed; \
+ __retval; \
+})
+
static LIST_HEAD(gpd_list);
static DEFINE_MUTEX(gpd_list_lock);
@@ -53,17 +64,20 @@ static int genpd_stop_dev(struct generic
static int genpd_start_dev(struct generic_pm_domain *genpd, struct device *dev)
{
- return GENPD_DEV_CALLBACK(genpd, int, start, dev);
+ return GENPD_DEV_TIMED_CALLBACK(genpd, int, start, dev,
+ start_latency_ns);
}
static int genpd_save_dev(struct generic_pm_domain *genpd, struct device *dev)
{
- return GENPD_DEV_CALLBACK(genpd, int, save_state, dev);
+ return GENPD_DEV_TIMED_CALLBACK(genpd, int, save_state, dev,
+ save_state_latency_ns);
}
static int genpd_restore_dev(struct generic_pm_domain *genpd, struct device *dev)
{
- return GENPD_DEV_CALLBACK(genpd, int, restore_state, dev);
+ return GENPD_DEV_TIMED_CALLBACK(genpd, int, restore_state, dev,
+ restore_state_latency_ns);
}
static bool genpd_sd_counter_dec(struct generic_pm_domain *genpd)
next prev parent reply other threads:[~2011-11-07 0:10 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 0:01 [PATCH 0/7] PM / Domains: Per-device callbacks and PM QoS Rafael J. Wysocki
2011-11-07 0:01 ` Rafael J. Wysocki
2011-11-07 0:06 ` [PATCH 1/7] PM / Domains: Make it possible to use per-device start/stop routines Rafael J. Wysocki
2011-11-07 0:06 ` Rafael J. Wysocki
2011-11-08 9:30 ` [PATCH 1/7] PM / Domains: Make it possible to use per-device Guennadi Liakhovetski
2011-11-08 9:30 ` [PATCH 1/7] PM / Domains: Make it possible to use per-device start/stop routines Guennadi Liakhovetski
2011-11-08 20:38 ` Rafael J. Wysocki
2011-11-08 20:38 ` Rafael J. Wysocki
2011-11-07 0:06 ` [PATCH 2/7] PM / Domains: Make it possible to use per-device .active_wakeup() Rafael J. Wysocki
2011-11-07 0:06 ` Rafael J. Wysocki
2011-11-08 10:27 ` [PATCH 2/7] PM / Domains: Make it possible to use per-device Guennadi Liakhovetski
2011-11-08 10:27 ` [PATCH 2/7] PM / Domains: Make it possible to use per-device .active_wakeup() Guennadi Liakhovetski
2011-11-08 20:40 ` Rafael J. Wysocki
2011-11-08 20:40 ` Rafael J. Wysocki
2011-11-09 8:52 ` [PATCH 2/7] PM / Domains: Make it possible to use per-device Guennadi Liakhovetski
2011-11-09 8:52 ` [PATCH 2/7] PM / Domains: Make it possible to use per-device .active_wakeup() Guennadi Liakhovetski
2011-11-09 22:40 ` Rafael J. Wysocki
2011-11-09 22:40 ` Rafael J. Wysocki
2011-11-09 23:02 ` [PATCH 2/7] PM / Domains: Make it possible to use per-device Guennadi Liakhovetski
2011-11-09 23:02 ` [PATCH 2/7] PM / Domains: Make it possible to use per-device .active_wakeup() Guennadi Liakhovetski
2011-11-07 0:07 ` [PATCH 3/7] PM / Domains: Introduce "save/restore state" device callbacks Rafael J. Wysocki
2011-11-07 0:07 ` Rafael J. Wysocki
2011-11-07 0:08 ` [PATCH 4/7] PM / Domains: Rework system suspend callback routines Rafael J. Wysocki
2011-11-07 0:08 ` Rafael J. Wysocki
2012-02-17 19:29 ` Pavel Machek
2012-02-17 19:29 ` Pavel Machek
2012-02-17 20:57 ` Rafael J. Wysocki
2012-02-17 21:01 ` Rafael J. Wysocki
2011-11-07 0:08 ` [PATCH 5/7] PM / Domains: Add device stop governor function (v3) Rafael J. Wysocki
2011-11-07 0:08 ` Rafael J. Wysocki
2011-11-07 0:09 ` [PATCH 6/7] PM / Domains: Add default power off " Rafael J. Wysocki
2011-11-07 0:09 ` Rafael J. Wysocki
2011-11-07 0:10 ` Rafael J. Wysocki [this message]
2011-11-07 0:10 ` [PATCH 7/7] PM / Domains: Automatically update overoptimistic latency information Rafael J. Wysocki
2011-11-14 0:22 ` [update][PATCH 0/7] PM / Domains: Per-device callbacks and PM QoS Rafael J. Wysocki
2011-11-14 0:22 ` Rafael J. Wysocki
2011-11-14 0:23 ` [update][PATCH 1/7] PM / Domains: Make it possible to use per-device domain callbacks Rafael J. Wysocki
2011-11-14 0:23 ` Rafael J. Wysocki
2011-11-14 0:24 ` [update][PATCH 2/7] PM / Domains: Introduce "save/restore state" device callbacks Rafael J. Wysocki
2011-11-14 0:24 ` Rafael J. Wysocki
2011-11-14 0:25 ` [update][PATCH 3/7] PM / Domains: Rework system suspend callback routines Rafael J. Wysocki
2011-11-14 0:25 ` Rafael J. Wysocki
2011-11-14 0:26 ` [update][PATCH 4/7] PM / Runtime: Use device PM QoS constraints Rafael J. Wysocki
2011-11-14 0:26 ` Rafael J. Wysocki
2011-11-14 0:27 ` [update][PATCH 5/7] PM / Domains: Add device stop governor function (v4) Rafael J. Wysocki
2011-11-14 0:27 ` Rafael J. Wysocki
2011-11-14 0:27 ` [update][PATCH 6/7] PM / Domains: Add default power off " Rafael J. Wysocki
2011-11-14 0:27 ` Rafael J. Wysocki
2011-11-14 0:28 ` [update][PATCH 7/7] PM / Domains: Automatically update overoptimistic latency information Rafael J. Wysocki
2011-11-14 0:28 ` Rafael J. Wysocki
2011-11-19 13:56 ` [Update 2x][PATCH 0/7] PM / Domains: Per-device callbacks and PM QoS Rafael J. Wysocki
2011-11-19 13:56 ` Rafael J. Wysocki
2011-11-19 13:58 ` [Update 2x][PATCH 1/7] PM / Domains: Make it possible to use per-device domain callbacks Rafael J. Wysocki
2011-11-19 13:58 ` Rafael J. Wysocki
2011-11-19 13:59 ` [Update 2x][PATCH 2/7] PM / Domains: Introduce "save/restore state" device callbacks Rafael J. Wysocki
2011-11-19 13:59 ` Rafael J. Wysocki
2011-11-19 13:59 ` [Update 2x][PATCH 3/7] PM / Domains: Rework system suspend callback routines Rafael J. Wysocki
2011-11-19 13:59 ` Rafael J. Wysocki
2011-11-24 0:20 ` [Update 3x][PATCH 3/7] PM / Domains: Rework system suspend callback routines (v2) Rafael J. Wysocki
2011-11-24 0:20 ` Rafael J. Wysocki
2011-11-19 14:00 ` [Update 2x][PATCH 4/7] PM / Runtime: Use device PM QoS constraints Rafael J. Wysocki
2011-11-19 14:00 ` Rafael J. Wysocki
2011-11-30 23:20 ` [Update 3x][PATCH 4/7] PM / Runtime: Use device PM QoS constraints (v2) Rafael J. Wysocki
2011-11-30 23:20 ` Rafael J. Wysocki
2011-11-19 14:01 ` [Update 2x][PATCH 5/7] PM / Domains: Add device stop governor function (v4) Rafael J. Wysocki
2011-11-19 14:01 ` Rafael J. Wysocki
2011-11-19 14:01 ` [Update 2x][PATCH 6/7] PM / Domains: Add default power off " Rafael J. Wysocki
2011-11-19 14:01 ` Rafael J. Wysocki
2011-11-19 14:02 ` [Update 2x][PATCH 7/7] PM / Domains: Automatically update overoptimistic latency information Rafael J. Wysocki
2011-11-19 14:02 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111070110.38976.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=g.liakhovetski@gmx.de \
--cc=jean.pihet@newoldbits.com \
--cc=khilman@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.