From: Dave Chinner <david@fromorbit.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-fsdevel@vger.kernel.org, aelder@sgi.com, tytso@mit.edu,
hch@lst.de, xfs@oss.sgi.com
Subject: Re: [PATCH 1/9] xfstests: fsstress add command line style output for show_opts
Date: Tue, 8 Nov 2011 07:52:50 +1100 [thread overview]
Message-ID: <20111107205250.GG5534@dastard> (raw)
In-Reply-To: <1320342953-7973-1-git-send-email-dmonakhov@openvz.org>
On Thu, Nov 03, 2011 at 09:55:45PM +0400, Dmitry Monakhov wrote:
> Once some combination of seed+fs_ops result in regression it is
> reasonable to document that combination. It is usefull to dump
> that configuration in command line style. Later this line may be
> simply hardcoded in to regression test.
.....
> @@ -345,7 +345,10 @@ int main(int argc, char **argv)
> zero_freq();
> break;
> case 'S':
> - show_ops(0, NULL);
> + i = 0;
> + if (optarg[0] == 'c')
> + i = 1;
> + show_ops(1, NULL);
I don't think that does what it is supposed to do...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, hch@lst.de,
aelder@sgi.com, tytso@mit.edu
Subject: Re: [PATCH 1/9] xfstests: fsstress add command line style output for show_opts
Date: Tue, 8 Nov 2011 07:52:50 +1100 [thread overview]
Message-ID: <20111107205250.GG5534@dastard> (raw)
In-Reply-To: <1320342953-7973-1-git-send-email-dmonakhov@openvz.org>
On Thu, Nov 03, 2011 at 09:55:45PM +0400, Dmitry Monakhov wrote:
> Once some combination of seed+fs_ops result in regression it is
> reasonable to document that combination. It is usefull to dump
> that configuration in command line style. Later this line may be
> simply hardcoded in to regression test.
.....
> @@ -345,7 +345,10 @@ int main(int argc, char **argv)
> zero_freq();
> break;
> case 'S':
> - show_ops(0, NULL);
> + i = 0;
> + if (optarg[0] == 'c')
> + i = 1;
> + show_ops(1, NULL);
I don't think that does what it is supposed to do...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2011-11-07 20:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 17:55 [PATCH 1/9] xfstests: fsstress add command line style output for show_opts Dmitry Monakhov
2011-11-03 17:55 ` Dmitry Monakhov
2011-11-03 17:55 ` [PATCH 2/9] xfstests: freeze fsstress options for 117'th Dmitry Monakhov
2011-11-03 17:55 ` Dmitry Monakhov
2011-11-03 17:55 ` [PATCH 3/9] xfstests: add fallocate support to fsstress Dmitry Monakhov
2011-11-03 17:55 ` Dmitry Monakhov
2011-11-03 17:55 ` [PATCH 4/9] xfstests: fsstress add FS_IOC_{SET, GET}FLAGS operations v2 Dmitry Monakhov
2011-11-03 17:55 ` [PATCH 4/9] xfstests: fsstress add FS_IOC_{SET,GET}FLAGS " Dmitry Monakhov
2011-11-03 17:55 ` [PATCH 5/9] xfstests: add fiemap operation to fsstress Dmitry Monakhov
2011-11-03 17:55 ` Dmitry Monakhov
2011-11-03 17:55 ` [PATCH 6/9] xfstests: add a new test that runs fsstress under ENOSPC conditions Dmitry Monakhov
2011-11-03 17:55 ` Dmitry Monakhov
2011-11-07 13:25 ` David Sterba
2011-11-07 13:25 ` David Sterba
2011-11-07 13:31 ` Dmitry Monakhov
2011-11-07 13:31 ` Dmitry Monakhov
2011-11-08 17:01 ` David Sterba
2011-11-08 17:01 ` David Sterba
2011-11-08 17:04 ` Christoph Hellwig
2011-11-08 17:04 ` Christoph Hellwig
2011-11-03 17:55 ` [PATCH 7/9] xfstests: add a new quota " Dmitry Monakhov
2011-11-03 17:55 ` Dmitry Monakhov
2011-11-03 19:39 ` Christoph Hellwig
2011-11-03 19:39 ` Christoph Hellwig
2011-11-07 6:15 ` Dmitry Monakhov
2011-11-07 6:15 ` Dmitry Monakhov
2011-11-03 17:55 ` [PATCH 8/9] xfstress: add regression testcase for d583fb87a3ff0 Dmitry Monakhov
2011-11-03 17:55 ` Dmitry Monakhov
2011-11-03 17:55 ` [PATCH 9/9] xfstress: Test data journaling flag switch for a single file Dmitry Monakhov
2011-11-03 17:55 ` Dmitry Monakhov
2011-11-07 20:52 ` Dave Chinner [this message]
2011-11-07 20:52 ` [PATCH 1/9] xfstests: fsstress add command line style output for show_opts Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107205250.GG5534@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=dmonakhov@openvz.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.