From: Greg KH <greg@kroah.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Claudio Scordino <claudio@evidence.eu.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
alan@linux.intel.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jesper Nilsson <Jesper.Nilsson@axis.com>,
Mikael Starvik <mikael.starvik@axis.com>,
Darron Black <darron@griffin.net>
Subject: Re: [PATCH] RS485: fix inconsistencies in the meaning of some variables
Date: Tue, 8 Nov 2011 06:24:32 -0800 [thread overview]
Message-ID: <20111108142432.GA11293@kroah.com> (raw)
In-Reply-To: <20111108134804.07095c5d@lxorguk.ukuu.org.uk>
On Tue, Nov 08, 2011 at 01:48:04PM +0000, Alan Cox wrote:
> > The modifications that I have proposed are very minimal, and most
> > user-space code should continue to work without any difference. Any Cris
> > user-space code will continue to work, because we didn't change the
> > behavior of the driver. For Atmel user-space code, instead, the behavior
> > of the driver changes only if flags are not set and delay variables
> > contain a value different than 0 (which, hopefully, is not a very common
> > situation). That's the reason why I preferred to not change the names of
> > the variables, even if better names would be desirable.
>
> We have inconsistency between implementations. We don't have a change in
> implementation. There isn't any way to resolve that except by fixing the
> deviating implementation and doing it promptly.
>
> With my tty hat on I'm quite happy with this patch. The sooner it is
> upstream the better.
Ok, I'll push to get it to Linus for the next rc release.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] RS485: fix inconsistencies in the meaning of some variables
Date: Tue, 8 Nov 2011 06:24:32 -0800 [thread overview]
Message-ID: <20111108142432.GA11293@kroah.com> (raw)
In-Reply-To: <20111108134804.07095c5d@lxorguk.ukuu.org.uk>
On Tue, Nov 08, 2011 at 01:48:04PM +0000, Alan Cox wrote:
> > The modifications that I have proposed are very minimal, and most
> > user-space code should continue to work without any difference. Any Cris
> > user-space code will continue to work, because we didn't change the
> > behavior of the driver. For Atmel user-space code, instead, the behavior
> > of the driver changes only if flags are not set and delay variables
> > contain a value different than 0 (which, hopefully, is not a very common
> > situation). That's the reason why I preferred to not change the names of
> > the variables, even if better names would be desirable.
>
> We have inconsistency between implementations. We don't have a change in
> implementation. There isn't any way to resolve that except by fixing the
> deviating implementation and doing it promptly.
>
> With my tty hat on I'm quite happy with this patch. The sooner it is
> upstream the better.
Ok, I'll push to get it to Linus for the next rc release.
greg k-h
next prev parent reply other threads:[~2011-11-08 14:24 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 14:28 [PATCH] atmel_serial: RS485: receiving enabled when sending data Bernhard Roth
2011-08-15 14:28 ` Bernhard Roth
2011-08-22 21:18 ` Greg KH
2011-08-22 21:18 ` Greg KH
2011-08-23 8:30 ` Claudio Scordino
2011-08-23 8:30 ` Claudio Scordino
2011-08-23 8:30 ` Claudio Scordino
2011-08-23 9:30 ` Russell King - ARM Linux
2011-08-23 9:30 ` Russell King - ARM Linux
2011-08-23 9:30 ` Russell King - ARM Linux
2011-08-23 10:06 ` Claudio Scordino
2011-08-23 10:06 ` Claudio Scordino
2011-08-23 10:14 ` Alan Cox
2011-08-23 10:14 ` Alan Cox
2011-08-23 10:21 ` Russell King - ARM Linux
2011-08-23 10:21 ` Russell King - ARM Linux
2011-08-23 10:21 ` Russell King - ARM Linux
2011-08-23 15:39 ` Greg KH
2011-08-23 15:39 ` Greg KH
2011-08-23 15:39 ` Greg KH
2011-08-24 7:48 ` Claudio Scordino
2011-08-24 7:48 ` Claudio Scordino
2011-11-04 8:19 ` [PATCH] RS485: fix inconsistencies in the meaning of some variables Claudio Scordino
2011-11-04 8:19 ` Claudio Scordino
2011-11-04 10:36 ` Jesper Nilsson
2011-11-04 10:36 ` Jesper Nilsson
2011-11-04 10:36 ` Jesper Nilsson
2011-11-08 9:30 ` Nicolas Ferre
2011-11-08 9:30 ` Nicolas Ferre
2011-11-08 9:59 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-08 9:59 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-08 9:59 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-08 10:48 ` Claudio Scordino
2011-11-08 10:48 ` Claudio Scordino
2011-11-08 13:48 ` Alan Cox
2011-11-08 13:48 ` Alan Cox
2011-11-08 14:24 ` Greg KH [this message]
2011-11-08 14:24 ` Greg KH
2011-11-09 14:51 ` Claudio Scordino
2011-11-09 14:51 ` Claudio Scordino
2011-11-13 21:53 ` Wolfram Sang
2011-11-13 21:53 ` Wolfram Sang
2011-11-14 0:37 ` Darron Black
2011-11-14 0:37 ` Darron Black
2011-11-14 0:37 ` Darron Black
2011-11-14 11:11 ` Nicolas Ferre
2011-11-14 11:11 ` Nicolas Ferre
2011-11-14 12:07 ` Alan Cox
2011-11-14 12:07 ` Alan Cox
2011-11-14 8:22 ` Claudio Scordino
2011-11-14 8:22 ` Claudio Scordino
2011-11-14 12:18 ` Nicolas Ferre
2011-11-14 12:18 ` Nicolas Ferre
2011-11-08 15:02 ` Nicolas Ferre
2011-11-08 15:02 ` Nicolas Ferre
2011-11-08 15:45 ` Claudio Scordino
2011-11-08 15:45 ` Claudio Scordino
2011-11-08 16:34 ` Jesper Nilsson
2011-11-08 16:34 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108142432.GA11293@kroah.com \
--to=greg@kroah.com \
--cc=Jesper.Nilsson@axis.com \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=claudio@evidence.eu.com \
--cc=darron@griffin.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mikael.starvik@axis.com \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.