From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 15/16] ARM: LPAE: add support for ATAG_MEM64
Date: Tue, 8 Nov 2011 16:59:05 +0000 [thread overview]
Message-ID: <20111108165905.GF10506@arm.com> (raw)
In-Reply-To: <4EB95ECB.8060905@codeaurora.org>
On Tue, Nov 08, 2011 at 04:54:35PM +0000, Stephen Boyd wrote:
> On 11/7/2011 8:16 AM, Catalin Marinas wrote:
> > diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
> > index 7e7977a..223af71 100644
> > --- a/arch/arm/kernel/setup.c
> > +++ b/arch/arm/kernel/setup.c
> > @@ -638,6 +638,29 @@ static int __init parse_tag_mem32(const struct tag *tag)
> >
> > __tagtable(ATAG_MEM, parse_tag_mem32);
> >
> > +static int __init parse_tag_mem64(const struct tag *tag)
> > +{
> > + /* We only use 32-bits for the size. */
> > + unsigned long size;
> > + phys_addr_t start, end;
> > +
> > + start = tag->u.mem64.start;
> > + size = tag->u.mem64.size;
> > + end = start + size;
> > +
> > + /* Ensure that the memory region is in range. */
> > + if (end & ~PHYS_MASK)
> > + pr_warning("Ignoring out-of-range mem64 tag (%.8llx-%.8llx)\n",
>
> Can you add 0x (or #) here so we can see the 0x hex part?
There are some inconsistencies across the kernel, we just used the
printk format found in sanity_check_meminfo(). I don't have a problem
with changing this, though maybe some separate clean-up patch would be
better.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Will Deacon <Will.Deacon@arm.com>
Subject: Re: [PATCH v8 15/16] ARM: LPAE: add support for ATAG_MEM64
Date: Tue, 8 Nov 2011 16:59:05 +0000 [thread overview]
Message-ID: <20111108165905.GF10506@arm.com> (raw)
In-Reply-To: <4EB95ECB.8060905@codeaurora.org>
On Tue, Nov 08, 2011 at 04:54:35PM +0000, Stephen Boyd wrote:
> On 11/7/2011 8:16 AM, Catalin Marinas wrote:
> > diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
> > index 7e7977a..223af71 100644
> > --- a/arch/arm/kernel/setup.c
> > +++ b/arch/arm/kernel/setup.c
> > @@ -638,6 +638,29 @@ static int __init parse_tag_mem32(const struct tag *tag)
> >
> > __tagtable(ATAG_MEM, parse_tag_mem32);
> >
> > +static int __init parse_tag_mem64(const struct tag *tag)
> > +{
> > + /* We only use 32-bits for the size. */
> > + unsigned long size;
> > + phys_addr_t start, end;
> > +
> > + start = tag->u.mem64.start;
> > + size = tag->u.mem64.size;
> > + end = start + size;
> > +
> > + /* Ensure that the memory region is in range. */
> > + if (end & ~PHYS_MASK)
> > + pr_warning("Ignoring out-of-range mem64 tag (%.8llx-%.8llx)\n",
>
> Can you add 0x (or #) here so we can see the 0x hex part?
There are some inconsistencies across the kernel, we just used the
printk format found in sanity_check_meminfo(). I don't have a problem
with changing this, though maybe some separate clean-up patch would be
better.
--
Catalin
next prev parent reply other threads:[~2011-11-08 16:59 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 16:16 [PATCH v8 00/16] ARM: Add support for the Large Physical Address Extensions Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 01/16] ARM: pgtable: switch to use pgtable-nopud.h Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 02/16] ARM: pgtable: Fix compiler warning in ioremap.c introduced by nopud Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-10 22:42 ` Russell King - ARM Linux
2011-11-10 22:42 ` Russell King - ARM Linux
2011-11-07 16:16 ` [PATCH v8 03/16] ARM: LPAE: Move page table maintenance macros to pgtable-2level.h Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 04/16] ARM: LPAE: Move the FSR definitions to separate files Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-10 22:45 ` Russell King - ARM Linux
2011-11-10 22:45 ` Russell King - ARM Linux
2011-11-10 23:44 ` Tony Lindgren
2011-11-10 23:44 ` Tony Lindgren
2011-11-07 16:16 ` [PATCH v8 05/16] ARM: LPAE: Factor out classic-MMU specific code into proc-v7-2level.S Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 06/16] ARM: LPAE: add ISBs around MMU enabling code Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 07/16] ARM: LPAE: Introduce the 3-level page table format definitions Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-10 21:53 ` Nicolas Pitre
2011-11-10 21:53 ` Nicolas Pitre
2011-11-11 10:49 ` Catalin Marinas
2011-11-11 10:49 ` Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 08/16] ARM: LPAE: Page table maintenance for the 3-level format Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-10 21:59 ` Nicolas Pitre
2011-11-10 21:59 ` Nicolas Pitre
2011-11-11 10:54 ` Catalin Marinas
2011-11-11 10:54 ` Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 09/16] ARM: LPAE: MMU setup for the 3-level page table format Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-10 22:24 ` Nicolas Pitre
2011-11-10 22:24 ` Nicolas Pitre
2011-11-10 22:38 ` Russell King - ARM Linux
2011-11-10 22:38 ` Russell King - ARM Linux
2011-11-11 11:17 ` Catalin Marinas
2011-11-11 11:17 ` Catalin Marinas
2011-11-11 11:00 ` Catalin Marinas
2011-11-11 11:00 ` Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 10/16] ARM: LPAE: Invalidate the TLB before freeing the PMD Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 11/16] ARM: LPAE: Add fault handling support Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-10 22:46 ` Russell King - ARM Linux
2011-11-10 22:46 ` Russell King - ARM Linux
2011-11-07 16:16 ` [PATCH v8 12/16] ARM: LPAE: Add context switching support Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 13/16] ARM: LPAE: Add identity mapping support for the 3-level page table format Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-10 22:55 ` Russell King - ARM Linux
2011-11-10 22:55 ` Russell King - ARM Linux
2011-11-11 11:36 ` Catalin Marinas
2011-11-11 11:36 ` Catalin Marinas
2011-11-11 11:58 ` Will Deacon
2011-11-11 11:58 ` Will Deacon
2011-11-07 16:16 ` [PATCH v8 14/16] ARM: LPAE: mark memory banks with start > ULONG_MAX as highmem Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-09 20:41 ` Nicolas Pitre
2011-11-09 20:41 ` Nicolas Pitre
2011-11-07 16:16 ` [PATCH v8 15/16] ARM: LPAE: add support for ATAG_MEM64 Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-08 16:54 ` Stephen Boyd
2011-11-08 16:54 ` Stephen Boyd
2011-11-08 16:59 ` Catalin Marinas [this message]
2011-11-08 16:59 ` Catalin Marinas
2011-11-08 23:38 ` Nicolas Pitre
2011-11-08 23:38 ` Nicolas Pitre
2011-11-09 0:24 ` Will Deacon
2011-11-09 0:24 ` Will Deacon
2011-11-09 10:44 ` Catalin Marinas
2011-11-09 10:44 ` Catalin Marinas
2011-11-07 16:16 ` [PATCH v8 16/16] ARM: LPAE: Add the Kconfig entries Catalin Marinas
2011-11-07 16:16 ` Catalin Marinas
2011-11-10 22:57 ` Russell King - ARM Linux
2011-11-10 22:57 ` Russell King - ARM Linux
2011-11-11 11:46 ` Catalin Marinas
2011-11-11 11:46 ` Catalin Marinas
2011-11-11 13:24 ` Russell King - ARM Linux
2011-11-11 13:24 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108165905.GF10506@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.