[PATCH mips-next] MIPS: Alchemy: pci: fix build: missing module.h

[PATCH mips-next] MIPS: Alchemy: pci: fix build: missing module.h

[Manuel Lauss]

fixes:
pci-alchemy.c:487:12: error: 'THIS_MODULE' undeclared here [...]

Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
---
This is a new one in 3.2-rc1.

 arch/mips/pci/pci-alchemy.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/mips/pci/pci-alchemy.c b/arch/mips/pci/pci-alchemy.c
index 4ee5710..b7779a3 100644
--- a/arch/mips/pci/pci-alchemy.c
+++ b/arch/mips/pci/pci-alchemy.c
@@ -12,6 +12,7 @@
 #include <linux/platform_device.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
+#include <linux/module.h>
 #include <linux/vmalloc.h>
 
 #include <asm/mach-au1x00/au1000.h>
-- 
1.7.7.2

Re: [PATCH mips-next] MIPS: Alchemy: pci: fix build: missing module.h

[Ralf Baechle]

Thanks, applied.

  Ralf

Re: [PATCH mips-next] MIPS: Alchemy: pci: fix build: missing module.h

[Ralf Baechle]

On Wed, Nov 09, 2011 at 07:10:06PM +0000, Ralf Baechle wrote:

> Thanks, applied.

And reverted again - in the new world of modules it should have included
<linux/export.h>, see http://lwn.net/Articles/453517/ for some background.

  Ralf

[PATCH V2] MIPS: Alchemy: pci: fix build: missing export.h

[Manuel Lauss]

fixes:
pci-alchemy.c:487:12: error: 'THIS_MODULE' undeclared here [...]

Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
---
V2: export.h instead of module.h

 arch/mips/pci/pci-alchemy.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/mips/pci/pci-alchemy.c b/arch/mips/pci/pci-alchemy.c
index 4ee5710..b5ce041 100644
--- a/arch/mips/pci/pci-alchemy.c
+++ b/arch/mips/pci/pci-alchemy.c
@@ -7,6 +7,7 @@
  * Support for all devices (greater than 16) added by David Gathright.
  */
 
+#include <linux/export.h>
 #include <linux/types.h>
 #include <linux/pci.h>
 #include <linux/platform_device.h>
-- 
1.7.7.2

Re: [PATCH V2] MIPS: Alchemy: pci: fix build: missing export.h

[Ralf Baechle]

On Thu, Nov 10, 2011 at 07:52:59PM +0100, Manuel Lauss wrote:

> fixes:
> pci-alchemy.c:487:12: error: 'THIS_MODULE' undeclared here [...]
> 
> Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
> ---
> V2: export.h instead of module.h

Already fixed by:

commit 91ffb85340c7994219ded8781376ae8d2d9d9c37
Author: Ralf Baechle <ralf@linux-mips.org>
Date:   Thu Nov 10 14:15:57 2011 +0000

    MIPS: Fix build errors due to missing inclusion of <linux/export.h>.
    
    Signed-off-by: Ralf Baechle <ralf@linux-mips.org>


Thanks anyway!

  Ralf