From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 02/20] serial: sh-sci: clean up white space
Date: Fri, 11 Nov 2011 03:47:08 +0000 [thread overview]
Message-ID: <20111111034708.GE29807@linux-sh.org> (raw)
In-Reply-To: <87y5vn9y5r.wl%kuninori.morimoto.gx@renesas.com>
On Thu, Nov 10, 2011 at 07:25:33PM -0800, Kuninori Morimoto wrote:
> > On Thu, Nov 10, 2011 at 06:43:31PM -0800, Kuninori Morimoto wrote:
> > > #define SCxSR_ERRORS(port) (to_sci_port(port)->cfg->error_mask)
> > >
> > > -#if defined(CONFIG_CPU_SUBTYPE_SH7705) || \
> > > - defined(CONFIG_CPU_SUBTYPE_SH7720) || \
> > > - defined(CONFIG_CPU_SUBTYPE_SH7721) || \
> > > - defined(CONFIG_ARCH_SH73A0) || \
> > > - defined(CONFIG_ARCH_SH7367) || \
> > > - defined(CONFIG_ARCH_SH7377) || \
> > > - defined(CONFIG_ARCH_SH7372)
> > > +#if defined(CONFIG_CPU_SUBTYPE_SH7705) ||\
> > > + defined(CONFIG_CPU_SUBTYPE_SH7720) ||\
> > > + defined(CONFIG_CPU_SUBTYPE_SH7721) ||\
> > > + defined(CONFIG_ARCH_SH73A0) ||\
> > > + defined(CONFIG_ARCH_SH7367) ||\
> > > + defined(CONFIG_ARCH_SH7377) ||\
> > > + defined(CONFIG_ARCH_SH7372)
> > > # define SCxSR_RDxF_CLEAR(port) (sci_in(port, SCxSR) & 0xfffc)
> > > # define SCxSR_ERROR_CLEAR(port) (sci_in(port, SCxSR) & 0xfd73)
> > > # define SCxSR_TDxE_CLEAR(port) (sci_in(port, SCxSR) & 0xffdf)
> >
> > Err, no. I don't see this as an improvement, and I don't really see what
> > you think the issue with the first format is, either.
>
> OK. this is not important. please drop it.
> but [PATCH 11/20] ARM: mach-shmobile: R-Mobile A1 support.
> is depend on this patch.
> I will re-post it.
>
Not a big deal, I will just fix it up by hand.
next prev parent reply other threads:[~2011-11-11 3:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 2:43 [PATCH 02/20] serial: sh-sci: clean up white space Kuninori Morimoto
2011-11-11 3:05 ` Paul Mundt
2011-11-11 3:25 ` Kuninori Morimoto
2011-11-11 3:47 ` Paul Mundt [this message]
2011-11-11 3:51 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111111034708.GE29807@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.