[PATCH 02/20] serial: sh-sci: clean up white space

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 02/20] serial: sh-sci: clean up white space
@ 2011-11-11  2:43 Kuninori Morimoto
  2011-11-11  3:05 ` Paul Mundt
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2011-11-11  2:43 UTC (permalink / raw)
  To: linux-sh

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/tty/serial/sh-sci.h |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/tty/serial/sh-sci.h b/drivers/tty/serial/sh-sci.h
index e9bed03..ab6be55 100644
--- a/drivers/tty/serial/sh-sci.h
+++ b/drivers/tty/serial/sh-sci.h
@@ -11,13 +11,13 @@
 
 #define SCxSR_ERRORS(port)	(to_sci_port(port)->cfg->error_mask)
 
-#if defined(CONFIG_CPU_SUBTYPE_SH7705) || \
-    defined(CONFIG_CPU_SUBTYPE_SH7720) || \
-    defined(CONFIG_CPU_SUBTYPE_SH7721) || \
-    defined(CONFIG_ARCH_SH73A0) || \
-    defined(CONFIG_ARCH_SH7367) || \
-    defined(CONFIG_ARCH_SH7377) || \
-    defined(CONFIG_ARCH_SH7372)
+#if	defined(CONFIG_CPU_SUBTYPE_SH7705) ||\
+	defined(CONFIG_CPU_SUBTYPE_SH7720) ||\
+	defined(CONFIG_CPU_SUBTYPE_SH7721) ||\
+	defined(CONFIG_ARCH_SH73A0) ||\
+	defined(CONFIG_ARCH_SH7367) ||\
+	defined(CONFIG_ARCH_SH7377) ||\
+	defined(CONFIG_ARCH_SH7372)
 # define SCxSR_RDxF_CLEAR(port)	 (sci_in(port, SCxSR) & 0xfffc)
 # define SCxSR_ERROR_CLEAR(port) (sci_in(port, SCxSR) & 0xfd73)
 # define SCxSR_TDxE_CLEAR(port)	 (sci_in(port, SCxSR) & 0xffdf)
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 02/20] serial: sh-sci: clean up white space
  2011-11-11  2:43 [PATCH 02/20] serial: sh-sci: clean up white space Kuninori Morimoto
@ 2011-11-11  3:05 ` Paul Mundt
  2011-11-11  3:25 ` Kuninori Morimoto
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Paul Mundt @ 2011-11-11  3:05 UTC (permalink / raw)
  To: linux-sh

On Thu, Nov 10, 2011 at 06:43:31PM -0800, Kuninori Morimoto wrote:
>  #define SCxSR_ERRORS(port)	(to_sci_port(port)->cfg->error_mask)
>  
> -#if defined(CONFIG_CPU_SUBTYPE_SH7705) || \
> -    defined(CONFIG_CPU_SUBTYPE_SH7720) || \
> -    defined(CONFIG_CPU_SUBTYPE_SH7721) || \
> -    defined(CONFIG_ARCH_SH73A0) || \
> -    defined(CONFIG_ARCH_SH7367) || \
> -    defined(CONFIG_ARCH_SH7377) || \
> -    defined(CONFIG_ARCH_SH7372)
> +#if	defined(CONFIG_CPU_SUBTYPE_SH7705) ||\
> +	defined(CONFIG_CPU_SUBTYPE_SH7720) ||\
> +	defined(CONFIG_CPU_SUBTYPE_SH7721) ||\
> +	defined(CONFIG_ARCH_SH73A0) ||\
> +	defined(CONFIG_ARCH_SH7367) ||\
> +	defined(CONFIG_ARCH_SH7377) ||\
> +	defined(CONFIG_ARCH_SH7372)
>  # define SCxSR_RDxF_CLEAR(port)	 (sci_in(port, SCxSR) & 0xfffc)
>  # define SCxSR_ERROR_CLEAR(port) (sci_in(port, SCxSR) & 0xfd73)
>  # define SCxSR_TDxE_CLEAR(port)	 (sci_in(port, SCxSR) & 0xffdf)

Err, no. I don't see this as an improvement, and I don't really see what
you think the issue with the first format is, either.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 02/20] serial: sh-sci: clean up white space
  2011-11-11  2:43 [PATCH 02/20] serial: sh-sci: clean up white space Kuninori Morimoto
  2011-11-11  3:05 ` Paul Mundt
@ 2011-11-11  3:25 ` Kuninori Morimoto
  2011-11-11  3:47 ` Paul Mundt
  2011-11-11  3:51 ` Kuninori Morimoto
  3 siblings, 0 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2011-11-11  3:25 UTC (permalink / raw)
  To: linux-sh


Hi Paul

Thank you for checking.

> On Thu, Nov 10, 2011 at 06:43:31PM -0800, Kuninori Morimoto wrote:
> >  #define SCxSR_ERRORS(port)	(to_sci_port(port)->cfg->error_mask)
> >  
> > -#if defined(CONFIG_CPU_SUBTYPE_SH7705) || \
> > -    defined(CONFIG_CPU_SUBTYPE_SH7720) || \
> > -    defined(CONFIG_CPU_SUBTYPE_SH7721) || \
> > -    defined(CONFIG_ARCH_SH73A0) || \
> > -    defined(CONFIG_ARCH_SH7367) || \
> > -    defined(CONFIG_ARCH_SH7377) || \
> > -    defined(CONFIG_ARCH_SH7372)
> > +#if	defined(CONFIG_CPU_SUBTYPE_SH7705) ||\
> > +	defined(CONFIG_CPU_SUBTYPE_SH7720) ||\
> > +	defined(CONFIG_CPU_SUBTYPE_SH7721) ||\
> > +	defined(CONFIG_ARCH_SH73A0) ||\
> > +	defined(CONFIG_ARCH_SH7367) ||\
> > +	defined(CONFIG_ARCH_SH7377) ||\
> > +	defined(CONFIG_ARCH_SH7372)
> >  # define SCxSR_RDxF_CLEAR(port)	 (sci_in(port, SCxSR) & 0xfffc)
> >  # define SCxSR_ERROR_CLEAR(port) (sci_in(port, SCxSR) & 0xfd73)
> >  # define SCxSR_TDxE_CLEAR(port)	 (sci_in(port, SCxSR) & 0xffdf)
> 
> Err, no. I don't see this as an improvement, and I don't really see what
> you think the issue with the first format is, either.

OK. this is not important. please drop it.
but [PATCH 11/20] ARM: mach-shmobile: R-Mobile A1 support.
is depend on this patch.
I will re-post it.

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 02/20] serial: sh-sci: clean up white space
  2011-11-11  2:43 [PATCH 02/20] serial: sh-sci: clean up white space Kuninori Morimoto
  2011-11-11  3:05 ` Paul Mundt
  2011-11-11  3:25 ` Kuninori Morimoto
@ 2011-11-11  3:47 ` Paul Mundt
  2011-11-11  3:51 ` Kuninori Morimoto
  3 siblings, 0 replies; 5+ messages in thread
From: Paul Mundt @ 2011-11-11  3:47 UTC (permalink / raw)
  To: linux-sh

On Thu, Nov 10, 2011 at 07:25:33PM -0800, Kuninori Morimoto wrote:
> > On Thu, Nov 10, 2011 at 06:43:31PM -0800, Kuninori Morimoto wrote:
> > >  #define SCxSR_ERRORS(port)	(to_sci_port(port)->cfg->error_mask)
> > >  
> > > -#if defined(CONFIG_CPU_SUBTYPE_SH7705) || \
> > > -    defined(CONFIG_CPU_SUBTYPE_SH7720) || \
> > > -    defined(CONFIG_CPU_SUBTYPE_SH7721) || \
> > > -    defined(CONFIG_ARCH_SH73A0) || \
> > > -    defined(CONFIG_ARCH_SH7367) || \
> > > -    defined(CONFIG_ARCH_SH7377) || \
> > > -    defined(CONFIG_ARCH_SH7372)
> > > +#if	defined(CONFIG_CPU_SUBTYPE_SH7705) ||\
> > > +	defined(CONFIG_CPU_SUBTYPE_SH7720) ||\
> > > +	defined(CONFIG_CPU_SUBTYPE_SH7721) ||\
> > > +	defined(CONFIG_ARCH_SH73A0) ||\
> > > +	defined(CONFIG_ARCH_SH7367) ||\
> > > +	defined(CONFIG_ARCH_SH7377) ||\
> > > +	defined(CONFIG_ARCH_SH7372)
> > >  # define SCxSR_RDxF_CLEAR(port)	 (sci_in(port, SCxSR) & 0xfffc)
> > >  # define SCxSR_ERROR_CLEAR(port) (sci_in(port, SCxSR) & 0xfd73)
> > >  # define SCxSR_TDxE_CLEAR(port)	 (sci_in(port, SCxSR) & 0xffdf)
> > 
> > Err, no. I don't see this as an improvement, and I don't really see what
> > you think the issue with the first format is, either.
> 
> OK. this is not important. please drop it.
> but [PATCH 11/20] ARM: mach-shmobile: R-Mobile A1 support.
> is depend on this patch.
> I will re-post it.
> 
Not a big deal, I will just fix it up by hand.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 02/20] serial: sh-sci: clean up white space
  2011-11-11  2:43 [PATCH 02/20] serial: sh-sci: clean up white space Kuninori Morimoto
                   ` (2 preceding siblings ...)
  2011-11-11  3:47 ` Paul Mundt
@ 2011-11-11  3:51 ` Kuninori Morimoto
  3 siblings, 0 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2011-11-11  3:51 UTC (permalink / raw)
  To: linux-sh


Hi Paul

> > OK. this is not important. please drop it.
> > but [PATCH 11/20] ARM: mach-shmobile: R-Mobile A1 support.
> > is depend on this patch.
> > I will re-post it.
> > 
> Not a big deal, I will just fix it up by hand.

Thank you

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-11-11  3:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-11  2:43 [PATCH 02/20] serial: sh-sci: clean up white space Kuninori Morimoto
2011-11-11  3:05 ` Paul Mundt
2011-11-11  3:25 ` Kuninori Morimoto
2011-11-11  3:47 ` Paul Mundt
2011-11-11  3:51 ` Kuninori Morimoto

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.