From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: ville.syrjala@linux.intel.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/7] drm: plane: Fix size of formats memcpy()
Date: Fri, 11 Nov 2011 08:22:19 -0800 [thread overview]
Message-ID: <20111111082219.58ea375b@jbarnes-desktop> (raw)
In-Reply-To: <1321027447-17921-3-git-send-email-ville.syrjala@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 906 bytes --]
On Fri, 11 Nov 2011 18:04:02 +0200
ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_crtc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 7058ed3..d3b884e 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -563,7 +563,7 @@ int drm_plane_init(struct drm_device *dev, struct drm_plane *plane,
> return -ENOMEM;
> }
>
> - memcpy(plane->format_types, formats, format_count);
> + memcpy(plane->format_types, formats, sizeof(uint32_t) * format_count);
> plane->format_count = format_count;
> plane->possible_crtcs = possible_crtcs;
>
Duh thank you.
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2011-11-11 16:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 16:04 drm plane fixes and additional checks ville.syrjala
2011-11-11 16:04 ` [PATCH 1/7] drm: Zero initialize drm_mode_fb_cmd2 in legacy addfb ioctl handler ville.syrjala
2011-11-11 16:55 ` Jesse Barnes
2011-11-11 16:04 ` [PATCH 2/7] drm: plane: Fix size of formats memcpy() ville.syrjala
2011-11-11 16:22 ` Jesse Barnes [this message]
2011-11-11 16:04 ` [PATCH 3/7] drm: plane: Clear plane.crtc and plane.fb after disable_plane() ville.syrjala
2011-11-11 16:56 ` Jesse Barnes
2011-11-11 16:04 ` [PATCH 4/7] drm: plane: Check source coordinates ville.syrjala
2011-11-11 16:24 ` Jesse Barnes
2011-11-11 17:18 ` Ville Syrjälä
2011-11-11 17:20 ` Jesse Barnes
2011-11-11 16:04 ` [PATCH 5/7] drm: plane: Check crtc coodrinates against integer overflows in setplane ioctl ville.syrjala
2011-11-11 17:01 ` Jesse Barnes
2011-11-11 17:11 ` Ville Syrjälä
2011-11-11 17:21 ` Jesse Barnes
2011-11-11 16:04 ` [PATCH 6/7] drm: plane: Make 'formats' parameter to drm_plane_init() const ville.syrjala
2011-11-11 16:25 ` Jesse Barnes
2011-11-11 16:04 ` [PATCH 7/7] drm: plane: Check that the fb pixel format is supported by the plane ville.syrjala
2011-11-11 16:25 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111111082219.58ea375b@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.