Re: [PATCH 6/7] drm: plane: Make 'formats' parameter to drm_plane_init() const

[Jesse Barnes <jbarnes@virtuousgeek.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1689 bytes --]

On Fri, 11 Nov 2011 18:04:06 +0200
ville.syrjala@linux.intel.com wrote:

> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/drm_crtc.c |    2 +-
>  include/drm/drm_crtc.h     |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 2410a9a..27d46b1 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -548,7 +548,7 @@ EXPORT_SYMBOL(drm_encoder_cleanup);
>  int drm_plane_init(struct drm_device *dev, struct drm_plane *plane,
>  		   unsigned long possible_crtcs,
>  		   const struct drm_plane_funcs *funcs,
> -		   uint32_t *formats, uint32_t format_count)
> +		   const uint32_t *formats, uint32_t format_count)
>  {
>  	mutex_lock(&dev->mode_config.mutex);
>  
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index 84db125..49dc288 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -727,7 +727,7 @@ extern int drm_plane_init(struct drm_device *dev,
>  			  struct drm_plane *plane,
>  			  unsigned long possible_crtcs,
>  			  const struct drm_plane_funcs *funcs,
> -			  uint32_t *formats, uint32_t format_count);
> +			  const uint32_t *formats, uint32_t format_count);
>  extern void drm_plane_cleanup(struct drm_plane *plane);
>  
>  extern void drm_encoder_cleanup(struct drm_encoder *encoder);

Yeah good fix.  I made the structure const at ickle's request (once I
stopped assigning it directly) but didn't update the prototype.

-- 
Jesse Barnes, Intel Open Source Technology Center

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel