From: Wei Wang2 <wei.wang2@amd.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH 2 of 6] amd iommu: Cleanup iommu pci capabilites detection
Date: Fri, 11 Nov 2011 11:16:27 +0100 [thread overview]
Message-ID: <201111111116.28286.wei.wang2@amd.com> (raw)
In-Reply-To: <4EBCF9E30200007800060600@nat28.tlf.novell.com>
On Friday 11 November 2011 10:33:07 Jan Beulich wrote:
> >>> On 09.11.11 at 16:50, Wei Wang <wei.wang2@amd.com> wrote:
> >
> > # HG changeset patch
> > # User Wei Wang <wei.wang2@amd.com>
> > # Date 1320851997 -3600
> > # Node ID 4b115815bc13e4f2a3a178f3de7477ecf46cb44b
> > # Parent 4769713326a876c25bdc0f9d1f90594f90fba9c5
> > amd iommu: Cleanup iommu pci capabilites detection.
> > * Define new structure to represent capability block.
> > * Remove unnecessary read for unused information.
> > * Add sanity check into get_iommu_capabilities.
> > * iommu capability offset is 16 bit not 8 bit, fix that.
>
> Does this imply that the capability can reside in extended config space?
> If so, all code paths using this will need revisiting with regard to
> extended config space possibly being inaccessible until early Dom0
> initialization.
Jan,
This is just an inconsistency issue with iommu specification as in IVHD
header, it has been defined as 16 bit value. In reality, both current and
next generation amd iommu will not have this capability in extended pci
config space.
Thanks,
Wei
> Jan
>
> > Signed-off-by: Wei Wang <wei.wang2@amd.com>
next prev parent reply other threads:[~2011-11-11 10:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 15:50 [PATCH 0 of 6] amd iommu: cleanup codes Wei Wang
2011-11-09 15:50 ` [PATCH 1 of 6] amd iommu: Use pci access function to detect msi capabilities Wei Wang
2011-11-09 15:50 ` [PATCH 2 of 6] amd iommu: Cleanup iommu pci capabilites detection Wei Wang
2011-11-11 9:33 ` Jan Beulich
2011-11-11 10:16 ` Wei Wang2 [this message]
2011-11-09 15:50 ` [PATCH 3 of 6] amd iommu: Simplify IVHD device flag handling Wei Wang
2011-11-09 15:50 ` [PATCH 4 of 6] amd iommu: Disable debug output for early DTE update Wei Wang
2011-11-09 15:51 ` [PATCH 5 of 6] amd iommu: Compress hyper-transport flags into a single byte Wei Wang
2011-11-09 15:51 ` [PATCH 6 of 6] amd iommu: Introduce iommu_has_cap() function Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111111116.28286.wei.wang2@amd.com \
--to=wei.wang2@amd.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.