All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP: Introduce local common.h files
Date: Fri, 11 Nov 2011 08:43:53 -0800	[thread overview]
Message-ID: <20111111164352.GE31337@atomide.com> (raw)
In-Reply-To: <20111111161727.GS15294@n2100.arm.linux.org.uk>

* Russell King - ARM Linux <linux@arm.linux.org.uk> [111111 07:42]:
> On Thu, Nov 10, 2011 at 03:33:47PM -0800, Tony Lindgren wrote:
> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [111110 13:54]:
> > > Thanks, merged that into the series.  The updated OMAP patch updated is
> > > below, which has been moved to part 2.  Lastly, the final patch of part
> > > 2 has been updated to delete the empty arch_reset(), so OMAP is now
> > > entirely free of arch_reset() references.  This leaves a total of 12
> > > references left to nobble.
> > 
> > Great, good to hear.
> 
> I've added this to the patch, as these no longer need to include this
> header.

OK thanks.

Tony
 
> diff --git a/arch/arm/mach-omap1/board-voiceblue.c b/arch/arm/mach-omap1/board-voiceblue.c
> index fb61434..f83a502d 100644
> --- a/arch/arm/mach-omap1/board-voiceblue.c
> +++ b/arch/arm/mach-omap1/board-voiceblue.c
> @@ -28,7 +28,6 @@
>  #include <linux/export.h>
>  
>  #include <mach/hardware.h>
> -#include <mach/system.h>
>  #include <asm/mach-types.h>
>  #include <asm/mach/arch.h>
>  #include <asm/mach/map.h>
> diff --git a/arch/arm/mach-omap1/reset.c b/arch/arm/mach-omap1/reset.c
> index 8b1cc6e..91d199b 100644
> --- a/arch/arm/mach-omap1/reset.c
> +++ b/arch/arm/mach-omap1/reset.c
> @@ -5,7 +5,6 @@
>  #include <linux/io.h>
>  
>  #include <mach/hardware.h>
> -#include <mach/system.h>
>  #include <plat/prcm.h>
>  
>  void omap1_restart(char mode, const char *cmd)
> diff --git a/arch/arm/mach-omap2/prcm.c b/arch/arm/mach-omap2/prcm.c
> index b6c8cb5..626acfa 100644
> --- a/arch/arm/mach-omap2/prcm.c
> +++ b/arch/arm/mach-omap2/prcm.c
> @@ -25,7 +25,6 @@
>  #include <linux/delay.h>
>  #include <linux/export.h>
>  
> -#include <mach/system.h>
>  #include "common.h"
>  #include <plat/prcm.h>
>  #include <plat/irqs.h>
> 

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: Introduce local common.h files
Date: Fri, 11 Nov 2011 08:43:53 -0800	[thread overview]
Message-ID: <20111111164352.GE31337@atomide.com> (raw)
In-Reply-To: <20111111161727.GS15294@n2100.arm.linux.org.uk>

* Russell King - ARM Linux <linux@arm.linux.org.uk> [111111 07:42]:
> On Thu, Nov 10, 2011 at 03:33:47PM -0800, Tony Lindgren wrote:
> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [111110 13:54]:
> > > Thanks, merged that into the series.  The updated OMAP patch updated is
> > > below, which has been moved to part 2.  Lastly, the final patch of part
> > > 2 has been updated to delete the empty arch_reset(), so OMAP is now
> > > entirely free of arch_reset() references.  This leaves a total of 12
> > > references left to nobble.
> > 
> > Great, good to hear.
> 
> I've added this to the patch, as these no longer need to include this
> header.

OK thanks.

Tony
 
> diff --git a/arch/arm/mach-omap1/board-voiceblue.c b/arch/arm/mach-omap1/board-voiceblue.c
> index fb61434..f83a502d 100644
> --- a/arch/arm/mach-omap1/board-voiceblue.c
> +++ b/arch/arm/mach-omap1/board-voiceblue.c
> @@ -28,7 +28,6 @@
>  #include <linux/export.h>
>  
>  #include <mach/hardware.h>
> -#include <mach/system.h>
>  #include <asm/mach-types.h>
>  #include <asm/mach/arch.h>
>  #include <asm/mach/map.h>
> diff --git a/arch/arm/mach-omap1/reset.c b/arch/arm/mach-omap1/reset.c
> index 8b1cc6e..91d199b 100644
> --- a/arch/arm/mach-omap1/reset.c
> +++ b/arch/arm/mach-omap1/reset.c
> @@ -5,7 +5,6 @@
>  #include <linux/io.h>
>  
>  #include <mach/hardware.h>
> -#include <mach/system.h>
>  #include <plat/prcm.h>
>  
>  void omap1_restart(char mode, const char *cmd)
> diff --git a/arch/arm/mach-omap2/prcm.c b/arch/arm/mach-omap2/prcm.c
> index b6c8cb5..626acfa 100644
> --- a/arch/arm/mach-omap2/prcm.c
> +++ b/arch/arm/mach-omap2/prcm.c
> @@ -25,7 +25,6 @@
>  #include <linux/delay.h>
>  #include <linux/export.h>
>  
> -#include <mach/system.h>
>  #include "common.h"
>  #include <plat/prcm.h>
>  #include <plat/irqs.h>
> 

  reply	other threads:[~2011-11-11 16:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-06 13:52 Pet Peaves about Platform code, and arch_reset Russell King - ARM Linux
2011-11-06 13:52 ` Russell King - ARM Linux
2011-11-08  0:45 ` Tony Lindgren
2011-11-08  0:45   ` Tony Lindgren
2011-11-09 21:46   ` Tony Lindgren
2011-11-09 21:46     ` Tony Lindgren
2011-11-11  1:17     ` Shawn Guo
2011-11-11  1:17       ` Shawn Guo
2011-11-10 20:17   ` [PATCH] ARM: OMAP: Introduce local common.h files Tony Lindgren
2011-11-10 20:17     ` Tony Lindgren
2011-11-10 20:23     ` Russell King - ARM Linux
2011-11-10 20:23       ` Russell King - ARM Linux
2011-11-10 21:50       ` Tony Lindgren
2011-11-10 21:50         ` Tony Lindgren
2011-11-10 22:29         ` Russell King - ARM Linux
2011-11-10 22:29           ` Russell King - ARM Linux
2011-11-10 23:33           ` Tony Lindgren
2011-11-10 23:33             ` Tony Lindgren
2011-11-11 16:17             ` Russell King - ARM Linux
2011-11-11 16:17               ` Russell King - ARM Linux
2011-11-11 16:43               ` Tony Lindgren [this message]
2011-11-11 16:43                 ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111111164352.GE31337@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.