From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Todd Broch <tbroch@chromium.org>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
Francois Romieu <romieu@fr.zoreil.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] r8169: add module param for control of ASPM disable
Date: Sat, 12 Nov 2011 04:59:36 +0000 [thread overview]
Message-ID: <20111112045935.GA24292@srcf.ucam.org> (raw)
In-Reply-To: <1321052755-15368-1-git-send-email-tbroch@chromium.org>
On Fri, Nov 11, 2011 at 03:05:55PM -0800, Todd Broch wrote:
> ASPM has been disabled in this driver by default as its been
> implicated in stability issues on at least one platform. This CL adds
> a module parameter to allow control of ASPM disable. The default
> value is to enable ASPM again as its provides signficant (200mW) power
> savings on the platform I tested.
The default is then to break some hardware. That's not reasonable.
Instead, we need to identify which chip versions are broken and limit
the blacklist to them.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-11-12 4:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 23:05 [PATCH] r8169: add module param for control of ASPM disable Todd Broch
2011-11-12 4:59 ` Matthew Garrett [this message]
2011-11-12 10:46 ` Francois Romieu
[not found] ` <CA+iF6Rog3ptpmQZzhcRODmZUKN18_uw5t9xfpQjbJ86qKUA0eQ@mail.gmail.com>
2011-11-15 16:32 ` Matthew Garrett
2011-11-17 9:37 ` Francois Romieu
[not found] ` <CA+iF6RqKScip+6w-tzo3sF+hEsYDUefED29KEBrx5TDaZaTEbA@mail.gmail.com>
2011-11-17 21:26 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111112045935.GA24292@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
--cc=tbroch@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.