From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Todd Broch <tbroch@chromium.org>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
netdev@vger.kernel.org, Hayes Wang <hayeswang@realtek.com>
Subject: Re: [PATCH] r8169: add module param for control of ASPM disable
Date: Thu, 17 Nov 2011 21:26:33 +0000 [thread overview]
Message-ID: <20111117212633.GA21564@srcf.ucam.org> (raw)
In-Reply-To: <CA+iF6RqKScip+6w-tzo3sF+hEsYDUefED29KEBrx5TDaZaTEbA@mail.gmail.com>
On Thu, Nov 17, 2011 at 01:20:46PM -0800, Todd Broch wrote:
> Looking a bit more at the driver a lot of configuration / feature choice is
> tied to mac_version. Would this be a better solution (partial patch ...
> will submit properly later)
I'd be mildly surprised if the mac's the relevant constraint here,
although it's possible. This patch is almost certainly safe, but if
you're able to check with the hardware vendor you're working with that
would be even better.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2011-11-17 21:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 23:05 [PATCH] r8169: add module param for control of ASPM disable Todd Broch
2011-11-12 4:59 ` Matthew Garrett
2011-11-12 10:46 ` Francois Romieu
[not found] ` <CA+iF6Rog3ptpmQZzhcRODmZUKN18_uw5t9xfpQjbJ86qKUA0eQ@mail.gmail.com>
2011-11-15 16:32 ` Matthew Garrett
2011-11-17 9:37 ` Francois Romieu
[not found] ` <CA+iF6RqKScip+6w-tzo3sF+hEsYDUefED29KEBrx5TDaZaTEbA@mail.gmail.com>
2011-11-17 21:26 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117212633.GA21564@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
--cc=tbroch@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.