All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@avionic-design.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] tegra2: Avoid warnings if CONFIG_SYS_TEXT_BASE is redefined.
Date: Mon, 14 Nov 2011 18:23:04 +0100	[thread overview]
Message-ID: <20111114172304.GA349@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <CAPnjgZ1wJN0b6_TSnsuwxwSZUbgtvc0GCORJnP-sdxjxiZyBVg@mail.gmail.com>

* Simon Glass wrote:
> Hi Stephen,
> 
> On Mon, Nov 14, 2011 at 9:09 AM, Stephen Warren <swarren@nvidia.com> wrote:
> > Thierry Reding wrote at Monday, November 14, 2011 6:22 AM:
> >> If a board configuration file redefines CONFIG_SYS_TEXT_BASE, the U-Boot
> >> build system will usually define it explicitly on the compiler command-
> >> line, which will cause the define in tegra2-common.h to emit a
> >> redefinition warning.
> >>
> >> To allow boards to redefine CONFIG_SYS_TEXT_BASE, tegra2-common.h now
> >> only defines CONFIG_SYS_TEXT_BASE when it isn't already defined by the
> >> board configuration or the command-line respectively.
> >
> > Instead of doing this, wouldn't it make sense to just switch all Tegra
> > boards to TEXT_BASE=00108000 to match NVIDIA's flashing tool's assumptions?
> > That way, no board would need to override TEXT_BASE at all.
> >
> > These assumptions are true for all boards in the standard flashing tool
> > builds; it's just that non-standard builds exist for some boards (those
> > that happened to be upstreamed to U-Boot first) that allow use of 00e08000
> > instead.
> >
> > Tom, Simon, what are your thoughts here?
> 
> I was going to say the same thing.

Okay, I can integrate that into the second version. Or would you prefer a
separate patch?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111114/8084b31f/attachment.pgp 

  reply	other threads:[~2011-11-14 17:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14 13:21 [U-Boot] [PATCH 1/4] tegra2: Avoid warnings if CONFIG_SYS_TEXT_BASE is redefined Thierry Reding
2011-11-14 13:21 ` [U-Boot] [PATCH 2/4] tegra2: Add common Avionic Design Tamonten support Thierry Reding
2011-11-14 13:21 ` [U-Boot] [PATCH 3/4] tegra2: Add Avionic Design Plutux support Thierry Reding
2011-11-14 13:21 ` [U-Boot] [PATCH 4/4] tegra2: Add Avionic Design Medcom support Thierry Reding
2011-11-14 17:09 ` [U-Boot] [PATCH 1/4] tegra2: Avoid warnings if CONFIG_SYS_TEXT_BASE is redefined Stephen Warren
2011-11-14 17:16   ` Simon Glass
2011-11-14 17:23     ` Thierry Reding [this message]
2011-11-14 17:31       ` Simon Glass
2011-11-14 19:31       ` Tom Warren
2011-11-14 19:40         ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111114172304.GA349@avionic-0098.adnet.avionic-design.de \
    --to=thierry.reding@avionic-design.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.