All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
	Joerg Roedel <Joerg.Roedel@amd.com>,
	iommu@lists.linux-foundation.org, Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, Cousson Benoit <b-cousson@ti.com>,
	Kevin Hilman <khilman@ti.com>,
	Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [RFC 4/5] ARM: OMAP3: bind omap3isp_device to its iommu device
Date: Mon, 14 Nov 2011 13:01:35 -0800	[thread overview]
Message-ID: <20111114210134.GN31337@atomide.com> (raw)
In-Reply-To: <201111091017.18860.laurent.pinchart@ideasonboard.com>

* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [111109 00:42]:
> Hi Ohad,
> 
> On Sunday 25 September 2011 12:58:56 Ohad Ben-Cohen wrote:
> > Bind OMAP3's isp device to the isp's dedicated iommu, by setting
> > the device's archdata iommu member.
> > 
> > This way omap3isp will be able to use the generic IOMMU API without
> > having to call any omap-specific binding method.
> > 
> > Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Acked-by: Tony Lindgren <tony@atomide.com>
 
> > ---
> >  arch/arm/mach-omap2/devices.c |    7 +++++++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> > index 1077ad6..44122f7 100644
> > --- a/arch/arm/mach-omap2/devices.c
> > +++ b/arch/arm/mach-omap2/devices.c
> > @@ -28,6 +28,7 @@
> >  #include <plat/mcbsp.h>
> >  #include <mach/gpio.h>
> >  #include <plat/mmc.h>
> > +#include <plat/iommu.h>
> >  #include <plat/dma.h>
> >  #include <plat/omap_hwmod.h>
> >  #include <plat/omap_device.h>
> > @@ -207,9 +208,15 @@ static struct platform_device omap3isp_device = {
> >  	.resource	= omap3isp_resources,
> >  };
> > 
> > +static struct omap_iommu_arch_data omap3_isp_iommu = {
> > +	.name = "isp",
> > +};
> > +
> >  int omap3_init_camera(struct isp_platform_data *pdata)
> >  {
> >  	omap3isp_device.dev.platform_data = pdata;
> > +	omap3isp_device.dev.archdata.iommu = &omap3_isp_iommu;
> > +
> >  	return platform_device_register(&omap3isp_device);
> >  }
> 
> -- 
> Regards,
> 
> Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 4/5] ARM: OMAP3: bind omap3isp_device to its iommu device
Date: Mon, 14 Nov 2011 13:01:35 -0800	[thread overview]
Message-ID: <20111114210134.GN31337@atomide.com> (raw)
In-Reply-To: <201111091017.18860.laurent.pinchart@ideasonboard.com>

* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [111109 00:42]:
> Hi Ohad,
> 
> On Sunday 25 September 2011 12:58:56 Ohad Ben-Cohen wrote:
> > Bind OMAP3's isp device to the isp's dedicated iommu, by setting
> > the device's archdata iommu member.
> > 
> > This way omap3isp will be able to use the generic IOMMU API without
> > having to call any omap-specific binding method.
> > 
> > Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Acked-by: Tony Lindgren <tony@atomide.com>
 
> > ---
> >  arch/arm/mach-omap2/devices.c |    7 +++++++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> > index 1077ad6..44122f7 100644
> > --- a/arch/arm/mach-omap2/devices.c
> > +++ b/arch/arm/mach-omap2/devices.c
> > @@ -28,6 +28,7 @@
> >  #include <plat/mcbsp.h>
> >  #include <mach/gpio.h>
> >  #include <plat/mmc.h>
> > +#include <plat/iommu.h>
> >  #include <plat/dma.h>
> >  #include <plat/omap_hwmod.h>
> >  #include <plat/omap_device.h>
> > @@ -207,9 +208,15 @@ static struct platform_device omap3isp_device = {
> >  	.resource	= omap3isp_resources,
> >  };
> > 
> > +static struct omap_iommu_arch_data omap3_isp_iommu = {
> > +	.name = "isp",
> > +};
> > +
> >  int omap3_init_camera(struct isp_platform_data *pdata)
> >  {
> >  	omap3isp_device.dev.platform_data = pdata;
> > +	omap3isp_device.dev.archdata.iommu = &omap3_isp_iommu;
> > +
> >  	return platform_device_register(&omap3isp_device);
> >  }
> 
> -- 
> Regards,
> 
> Laurent Pinchart

  parent reply	other threads:[~2011-11-14 21:01 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-25 10:58 [RFC 0/5] OMAP groundwork for IOMMU-based DMA API Ohad Ben-Cohen
2011-09-25 10:58 ` Ohad Ben-Cohen
2011-09-25 10:58 ` Ohad Ben-Cohen
2011-09-25 10:58 ` [RFC 1/5] ARM: dev_archdata: add private iommu extension Ohad Ben-Cohen
2011-09-25 10:58   ` Ohad Ben-Cohen
2011-09-27  1:30   ` Grant Likely
2011-09-27  1:30     ` Grant Likely
2011-10-02 18:48     ` Ohad Ben-Cohen
2011-10-02 18:48       ` Ohad Ben-Cohen
2011-10-02 18:48       ` Ohad Ben-Cohen
2011-10-05  9:26   ` Ohad Ben-Cohen
2011-10-05  9:26     ` Ohad Ben-Cohen
2011-10-13  9:15     ` Ohad Ben-Cohen
2011-10-13  9:15       ` Ohad Ben-Cohen
2011-10-13 10:42       ` Russell King - ARM Linux
2011-10-13 10:42         ` Russell King - ARM Linux
2011-10-13 11:55         ` Ohad Ben-Cohen
2011-10-13 11:55           ` Ohad Ben-Cohen
2011-10-13 11:55           ` Ohad Ben-Cohen
2011-09-25 10:58 ` [RFC 2/5] ARM: OMAP: omap_device: add a method to set iommu private archdata Ohad Ben-Cohen
2011-09-25 10:58   ` Ohad Ben-Cohen
2011-09-26 22:53   ` Kevin Hilman
2011-09-26 22:53     ` Kevin Hilman
2011-09-26 22:53     ` Kevin Hilman
2011-09-27 18:09     ` Ohad Ben-Cohen
2011-09-27 18:09       ` Ohad Ben-Cohen
2011-09-27 18:09       ` Ohad Ben-Cohen
2011-10-04 18:15       ` Kevin Hilman
2011-10-04 18:15         ` Kevin Hilman
2011-10-04 19:54         ` Ohad Ben-Cohen
2011-10-04 19:54           ` Ohad Ben-Cohen
2011-10-04 20:29           ` Kevin Hilman
2011-10-04 20:29             ` Kevin Hilman
2011-10-05  7:01             ` Ohad Ben-Cohen
2011-10-05  7:01               ` Ohad Ben-Cohen
2011-10-04 21:40           ` Cousson, Benoit
2011-10-04 21:40             ` Cousson, Benoit
2011-10-04 21:40             ` Cousson, Benoit
2011-09-25 10:58 ` [RFC 3/5] ARM: OMAP: iommu: declare a private iommu binding struct Ohad Ben-Cohen
2011-09-25 10:58   ` Ohad Ben-Cohen
2011-11-14 21:01   ` Tony Lindgren
2011-11-14 21:01     ` Tony Lindgren
2011-09-25 10:58 ` [RFC 4/5] ARM: OMAP3: bind omap3isp_device to its iommu device Ohad Ben-Cohen
2011-09-25 10:58   ` Ohad Ben-Cohen
2011-11-09  9:17   ` Laurent Pinchart
2011-11-09  9:17     ` Laurent Pinchart
2011-11-09  9:29     ` Ohad Ben-Cohen
2011-11-09  9:29       ` Ohad Ben-Cohen
2011-11-14 21:01     ` Tony Lindgren [this message]
2011-11-14 21:01       ` Tony Lindgren
2011-09-25 10:58 ` [RFC 5/5] iommu/omap: eliminate the public omap_find_iommu_device() method Ohad Ben-Cohen
2011-09-25 10:58   ` Ohad Ben-Cohen
2011-09-27 11:46   ` Laurent Pinchart
2011-09-27 11:46     ` Laurent Pinchart
2011-11-09  8:50     ` Ohad Ben-Cohen
2011-11-09  8:50       ` Ohad Ben-Cohen
2011-11-09  9:17       ` Laurent Pinchart
2011-11-09  9:17         ` Laurent Pinchart
2011-11-14 21:02         ` Tony Lindgren
2011-11-14 21:02           ` Tony Lindgren
2011-11-15 10:39 ` [RFC 0/5] OMAP groundwork for IOMMU-based DMA API Roedel, Joerg
2011-11-15 10:39   ` Roedel, Joerg
2011-11-15 10:45   ` Ohad Ben-Cohen
2011-11-15 10:45     ` Ohad Ben-Cohen
2011-11-15 11:10     ` Roedel, Joerg
2011-11-15 11:10       ` Roedel, Joerg
2011-11-15 11:18       ` Ohad Ben-Cohen
2011-11-15 11:18         ` Ohad Ben-Cohen
2011-12-05 14:21   ` Ohad Ben-Cohen
2011-12-05 14:21     ` Ohad Ben-Cohen
2011-12-05 15:18     ` Roedel, Joerg
2011-12-05 15:18       ` Roedel, Joerg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111114210134.GN31337@atomide.com \
    --to=tony@atomide.com \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=Joerg.Roedel@amd.com \
    --cc=arnd@arndb.de \
    --cc=b-cousson@ti.com \
    --cc=grant.likely@secretlab.ca \
    --cc=iommu@lists.linux-foundation.org \
    --cc=khilman@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=ohad@wizery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.