* [PATCH] ASoC: Remove unused control_data and mutex fields from struct alc5632_priv
@ 2011-11-13 3:56 Axel Lin
2011-11-13 19:47 ` Leon Romanovsky
2011-11-14 21:43 ` Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Axel Lin @ 2011-11-13 3:56 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown, Andrey Danin, Liam, Leon Romanovsky, Girdwood
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/alc5632.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/alc5632.c b/sound/soc/codecs/alc5632.c
index ee6a497..bfb48ba 100644
--- a/sound/soc/codecs/alc5632.c
+++ b/sound/soc/codecs/alc5632.c
@@ -68,8 +68,6 @@ static const u16 alc5632_reg_defaults[] = {
/* codec private data */
struct alc5632_priv {
enum snd_soc_control_type control_type;
- void *control_data;
- struct mutex mutex;
u8 id;
unsigned int sysclk;
};
@@ -1092,9 +1090,7 @@ static int alc5632_i2c_probe(struct i2c_client *client,
}
i2c_set_clientdata(client, alc5632);
- alc5632->control_data = client;
alc5632->control_type = SND_SOC_I2C;
- mutex_init(&alc5632->mutex);
ret = snd_soc_register_codec(&client->dev,
&soc_codec_device_alc5632, &alc5632_dai, 1);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Remove unused control_data and mutex fields from struct alc5632_priv
2011-11-13 3:56 [PATCH] ASoC: Remove unused control_data and mutex fields from struct alc5632_priv Axel Lin
@ 2011-11-13 19:47 ` Leon Romanovsky
2011-11-14 21:21 ` Mark Brown
2011-11-14 21:43 ` Mark Brown
1 sibling, 1 reply; 5+ messages in thread
From: Leon Romanovsky @ 2011-11-13 19:47 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Axel Lin; +Cc: alsa-devel, Andrey Danin
On Sun, Nov 13, 2011 at 05:56, Axel Lin <axel.lin@gmail.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/codecs/alc5632.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/codecs/alc5632.c b/sound/soc/codecs/alc5632.c
> index ee6a497..bfb48ba 100644
> --- a/sound/soc/codecs/alc5632.c
> +++ b/sound/soc/codecs/alc5632.c
> @@ -68,8 +68,6 @@ static const u16 alc5632_reg_defaults[] = {
> /* codec private data */
> struct alc5632_priv {
> enum snd_soc_control_type control_type;
> - void *control_data;
> - struct mutex mutex;
> u8 id;
> unsigned int sysclk;
> };
> @@ -1092,9 +1090,7 @@ static int alc5632_i2c_probe(struct i2c_client *client,
> }
>
> i2c_set_clientdata(client, alc5632);
> - alc5632->control_data = client;
> alc5632->control_type = SND_SOC_I2C;
> - mutex_init(&alc5632->mutex);
>
> ret = snd_soc_register_codec(&client->dev,
> &soc_codec_device_alc5632, &alc5632_dai, 1);
> --
> 1.7.5.4
Thanks,
Mark, Liam do I need to sign Acked-Off-By on this type of patch?
--
Leon Romanovsky | Independent Linux Consultant
www.leon.nu | leon@leon.nu
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Remove unused control_data and mutex fields from struct alc5632_priv
2011-11-13 19:47 ` Leon Romanovsky
@ 2011-11-14 21:21 ` Mark Brown
2011-11-14 21:42 ` Leon Romanovsky
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2011-11-14 21:21 UTC (permalink / raw)
To: Leon Romanovsky; +Cc: Axel Lin, Andrey Danin, Liam Girdwood, alsa-devel
On Sun, Nov 13, 2011 at 09:47:59PM +0200, Leon Romanovsky wrote:
> Mark, Liam do I need to sign Acked-Off-By on this type of patch?
You don't have to but if you've reviewed patches that haven't yet been
applied it's always helpful to say so.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Remove unused control_data and mutex fields from struct alc5632_priv
2011-11-14 21:21 ` Mark Brown
@ 2011-11-14 21:42 ` Leon Romanovsky
0 siblings, 0 replies; 5+ messages in thread
From: Leon Romanovsky @ 2011-11-14 21:42 UTC (permalink / raw)
To: Mark Brown; +Cc: Axel Lin, Andrey Danin, Liam Girdwood, alsa-devel
On Mon, Nov 14, 2011 at 23:21, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Sun, Nov 13, 2011 at 09:47:59PM +0200, Leon Romanovsky wrote:
>
>> Mark, Liam do I need to sign Acked-Off-By on this type of patch?
>
> You don't have to but if you've reviewed patches that haven't yet been
> applied it's always helpful to say so.
Ok, in this case, I reviewed it and tested :)
Acked-off-by: Leon Romanovsky <leon@leon.nu>
--
Leon Romanovsky | Independent Linux Consultant
www.leon.nu | leon@leon.nu
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: Remove unused control_data and mutex fields from struct alc5632_priv
2011-11-13 3:56 [PATCH] ASoC: Remove unused control_data and mutex fields from struct alc5632_priv Axel Lin
2011-11-13 19:47 ` Leon Romanovsky
@ 2011-11-14 21:43 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2011-11-14 21:43 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Andrey Danin, Leon Romanovsky, Liam Girdwood
On Sun, Nov 13, 2011 at 11:56:28AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-11-14 21:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-13 3:56 [PATCH] ASoC: Remove unused control_data and mutex fields from struct alc5632_priv Axel Lin
2011-11-13 19:47 ` Leon Romanovsky
2011-11-14 21:21 ` Mark Brown
2011-11-14 21:42 ` Leon Romanovsky
2011-11-14 21:43 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.