From: Stephen Hemminger <shemminger@vyatta.com>
To: "Yan, Zheng" <zheng.z.yan@intel.com>
Cc: Martin Volf <martin.volf.42@gmail.com>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>,
"wcang@sfc.wide.ad.jp" <wcang@sfc.wide.ad.jp>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"shemminger@linux-foundation.org"
<shemminger@linux-foundation.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [Bridge] sky2 hw csum failure
Date: Tue, 15 Nov 2011 09:45:16 -0800 [thread overview]
Message-ID: <20111115094516.3eb54a1a@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <4EC23EE7.2010606@intel.com>
On Tue, 15 Nov 2011 18:28:55 +0800
"Yan, Zheng" <zheng.z.yan@intel.com> wrote:
> I re-tested the checksum code, both CHECKSUM_NONE and CHECKSUM_COMPLETE
> cases are OK. Maybe the bug is related to sky2.
>
> Regards
> Yan, Zheng
There are three types of receive checksumming:
1. Hardware does not do checksumming (CHECKSUM_NONE)
2. Hardware validates checksum (CHECKSUM_UNNECESSARY)
3. Hardware computes sum of bytes in skb (CHECKSUM_COMPLETE)
Most hardware does #2, but sky2 uses #3.
For the second case, the hardware does not look at headers but only
reports the one's complement value in ip_summed. It is up to the
protocol layers to adjust accordingly. This means if data is removed
or added the checksum needs to be adjusted.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <shemminger@vyatta.com>
To: "Yan, Zheng" <zheng.z.yan@intel.com>
Cc: Martin Volf <martin.volf.42@gmail.com>,
"shemminger@linux-foundation.org"
<shemminger@linux-foundation.org>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"wcang@sfc.wide.ad.jp" <wcang@sfc.wide.ad.jp>
Subject: Re: sky2 hw csum failure
Date: Tue, 15 Nov 2011 09:45:16 -0800 [thread overview]
Message-ID: <20111115094516.3eb54a1a@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <4EC23EE7.2010606@intel.com>
On Tue, 15 Nov 2011 18:28:55 +0800
"Yan, Zheng" <zheng.z.yan@intel.com> wrote:
> I re-tested the checksum code, both CHECKSUM_NONE and CHECKSUM_COMPLETE
> cases are OK. Maybe the bug is related to sky2.
>
> Regards
> Yan, Zheng
There are three types of receive checksumming:
1. Hardware does not do checksumming (CHECKSUM_NONE)
2. Hardware validates checksum (CHECKSUM_UNNECESSARY)
3. Hardware computes sum of bytes in skb (CHECKSUM_COMPLETE)
Most hardware does #2, but sky2 uses #3.
For the second case, the hardware does not look at headers but only
reports the one's complement value in ip_summed. It is up to the
protocol layers to adjust accordingly. This means if data is removed
or added the checksum needs to be adjusted.
next prev parent reply other threads:[~2011-11-15 17:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 9:03 [Bridge] sky2 hw csum failure Martin Volf
2011-11-15 9:05 ` Martin Volf
2011-11-15 10:27 ` [Bridge] " Yan, Zheng
2011-11-15 10:28 ` Yan, Zheng
2011-11-15 17:45 ` Stephen Hemminger [this message]
2011-11-15 17:45 ` Stephen Hemminger
2011-11-15 18:09 ` [Bridge] [RFT] bridge: checksum not updated after pull Stephen Hemminger
2011-11-15 18:09 ` Stephen Hemminger
2011-11-15 19:50 ` [Bridge] " Martin Volf
2011-11-15 19:51 ` Martin Volf
2011-11-16 22:47 ` [Bridge] " David Miller
2011-11-16 22:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111115094516.3eb54a1a@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=martin.volf.42@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=wcang@sfc.wide.ad.jp \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.