From: Vasiliy Kulikov <segoon@openwall.com>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: kernel-hardening@lists.openwall.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Alexey Dobriyan <adobriyan@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
"H. Peter Anvin" <hpa@zytor.com>, Greg KH <greg@kroah.com>,
Theodore Tso <tytso@mit.edu>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [kernel-hardening] Re: [RFC 1/3] procfs: parse mount options
Date: Tue, 15 Nov 2011 16:53:33 +0400 [thread overview]
Message-ID: <20111115125332.GA8486@albatros> (raw)
In-Reply-To: <CAM_iQpUAqDmP571R3NkYOmPC7yAEMaHTFmmQCm5hLUXV5Fh8xQ@mail.gmail.com>
Hi Américo,
On Tue, Nov 15, 2011 at 19:48 +0800, Américo Wang wrote:
> On Tue, Nov 15, 2011 at 7:21 PM, Vasiliy Kulikov <segoon@openwall.com> wrote:
> > +
> > +static int proc_parse_options(char *options, struct pid_namespace *pid)
> > +{
> > + char *p;
> > + substring_t args[MAX_OPT_ARGS];
> > + int option;
>
>
> 'option' is unused?
Right.
> > + switch (token) {
> > + default:
>
>
> This switch block reads odd...
It will be used in 2/3 patch.
> > + pr_err("proc: unrecognized mount option \"%s\" "
> > + "or missing value", p);
>
> "\n" is needed.
Correct. Thank you!
> > + return 0;
> > + }
> > + }
> > +
> > + return 1;
> > +}
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
WARNING: multiple messages have this Message-ID (diff)
From: Vasiliy Kulikov <segoon@openwall.com>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: kernel-hardening@lists.openwall.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Alexey Dobriyan <adobriyan@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
"H. Peter Anvin" <hpa@zytor.com>, Greg KH <greg@kroah.com>,
Theodore Tso <tytso@mit.edu>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC 1/3] procfs: parse mount options
Date: Tue, 15 Nov 2011 16:53:33 +0400 [thread overview]
Message-ID: <20111115125332.GA8486@albatros> (raw)
In-Reply-To: <CAM_iQpUAqDmP571R3NkYOmPC7yAEMaHTFmmQCm5hLUXV5Fh8xQ@mail.gmail.com>
Hi Américo,
On Tue, Nov 15, 2011 at 19:48 +0800, Américo Wang wrote:
> On Tue, Nov 15, 2011 at 7:21 PM, Vasiliy Kulikov <segoon@openwall.com> wrote:
> > +
> > +static int proc_parse_options(char *options, struct pid_namespace *pid)
> > +{
> > + char *p;
> > + substring_t args[MAX_OPT_ARGS];
> > + int option;
>
>
> 'option' is unused?
Right.
> > + switch (token) {
> > + default:
>
>
> This switch block reads odd...
It will be used in 2/3 patch.
> > + pr_err("proc: unrecognized mount option \"%s\" "
> > + "or missing value", p);
>
> "\n" is needed.
Correct. Thank you!
> > + return 0;
> > + }
> > + }
> > +
> > + return 1;
> > +}
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
next prev parent reply other threads:[~2011-11-15 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 11:21 [kernel-hardening] [RFC 1/3] procfs: parse mount options Vasiliy Kulikov
2011-11-15 11:21 ` Vasiliy Kulikov
2011-11-15 11:48 ` [kernel-hardening] " Américo Wang
2011-11-15 11:48 ` Américo Wang
2011-11-15 12:53 ` Vasiliy Kulikov [this message]
2011-11-15 12:53 ` Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111115125332.GA8486@albatros \
--to=segoon@openwall.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.