Build breakage in samsung-keypad driver

Build breakage in samsung-keypad driver

[Mark Brown]

Hi Dmitry,

Your commit 5862c02 (Input: samsung-keypad - enable compiling on other
platforms) breaks the build on any platform using the driver as you've
moved the header defining the platform data without updating any of the
users.  Whenever doing updates to platform data you really need to grep
the tree for users and make sure they're updated otherwise there will be
build breakage.

I also can't see the patch on the list...

Thanks,
Mark

Re: Build breakage in samsung-keypad driver

[Dmitry Torokhov]

Hi Mark,

On Tue, Nov 15, 2011 at 12:53:20PM +0000, Mark Brown wrote:
> Hi Dmitry,
> 
> Your commit 5862c02 (Input: samsung-keypad - enable compiling on other
> platforms) breaks the build on any platform using the driver as you've
> moved the header defining the platform data without updating any of the
> users.  Whenever doing updates to platform data you really need to grep
> the tree for users and make sure they're updated otherwise there will be
> build breakage.

Hmm, I haven't removed the original header though, I had plat/keypad.h
include the new linux/input/samsung-keypad.h so that it should be
transparent for all existing users.

Could you tell me exactly what breaks?

> 
> I also can't see the patch on the list...

Admittedly was buried in a separate thread, but:

http://www.spinics.net/lists/linux-samsung-soc/msg06578.html

Thanks.

-- 
Dmitry

Re: Build breakage in samsung-keypad driver

[Mark Brown]

On Tue, Nov 15, 2011 at 09:21:54AM -0800, Dmitry Torokhov wrote:

> Hmm, I haven't removed the original header though, I had plat/keypad.h
> include the new linux/input/samsung-keypad.h so that it should be
> transparent for all existing users.

> Could you tell me exactly what breaks?

You've not got the name of your new header correct:

arch/arm/plat-samsung/include/plat/keypad.h:16:11: error: unable to open 'linux/input/samsung_keypad.h'

Re: Build breakage in samsung-keypad driver

[Dmitry Torokhov]

On Tue, Nov 15, 2011 at 05:25:24PM +0000, Mark Brown wrote:
> On Tue, Nov 15, 2011 at 09:21:54AM -0800, Dmitry Torokhov wrote:
> 
> > Hmm, I haven't removed the original header though, I had plat/keypad.h
> > include the new linux/input/samsung-keypad.h so that it should be
> > transparent for all existing users.
> 
> > Could you tell me exactly what breaks?
> 
> You've not got the name of your new header correct:
> 
> arch/arm/plat-samsung/include/plat/keypad.h:16:11: error: unable to open 'linux/input/samsung_keypad.h'

Ahh... that explains it. I'll fix it up, sorry for the trouble.

-- 
Dmitry

Re: Build breakage in samsung-keypad driver

[Mark Brown]

On Tue, Nov 15, 2011 at 09:35:10AM -0800, Dmitry Torokhov wrote:
> On Tue, Nov 15, 2011 at 05:25:24PM +0000, Mark Brown wrote:

> > arch/arm/plat-samsung/include/plat/keypad.h:16:11: error: unable to open 'linux/input/samsung_keypad.h'

> Ahh... that explains it. I'll fix it up, sorry for the trouble.

Thanks!  I'd not actually checked what the error came from, I'd just
reverted the patch.