All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
Cc: Alex Elder <aelder@sgi.com>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	Christoph Hellwig <hch@infradead.org>,
	xfs-masters@oss.sgi.com, yrl.pp-manager.tt@hitachi.com
Subject: Re: [PATCH] [BUGFIX] xfs: use doalloc flag in xfs_qm_dqattach_one()
Date: Tue, 15 Nov 2011 14:23:14 -0600	[thread overview]
Message-ID: <20111115202314.GE29840@sgi.com> (raw)
In-Reply-To: <20111110013310.3408.41745.stgit@ltc219.sdl.hitachi.co.jp>

On Thu, Nov 10, 2011 at 10:33:10AM +0900, Mitsuo Hayasaka wrote:
> The doalloc arg in xfs_qm_dqattach_one() is a flag that indicates
> whether a new area to handle quota information will be allocated
> if needed. Originally, it was passed to xfs_qm_dqget(), but has
> been removed by the following commit (probably by mistake):
> 
> 	commit 8e9b6e7fa4544ea8a0e030c8987b918509c8ff47
> 	Author: Christoph Hellwig <hch@lst.de>
> 	Date:   Sun Feb 8 21:51:42 2009 +0100
> 
> 	xfs: remove the unused XFS_QMOPT_DQLOCK flag
> 
> As the result, xfs_qm_dqget() called from xfs_qm_dqattach_one()
> never allocates the new area even if it is needed.
> 
> This patch gives the doalloc arg to xfs_qm_dqget() in
> xfs_qm_dqattach_one() to fix this problem.
> 
> Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
> Cc: Alex Elder <aelder@sgi.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> ---
> 
>  fs/xfs/xfs_qm.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> index 9a0aa76..95ba6dc 100644
> --- a/fs/xfs/xfs_qm.c
> +++ b/fs/xfs/xfs_qm.c
> @@ -674,7 +674,8 @@ xfs_qm_dqattach_one(
>  	 * disk and we didn't ask it to allocate;
>  	 * ESRCH if quotas got turned off suddenly.
>  	 */
> -	error = xfs_qm_dqget(ip->i_mount, ip, id, type, XFS_QMOPT_DOWARN, &dqp);
> +	error = xfs_qm_dqget(ip->i_mount, ip, id, type,
> +			     doalloc | XFS_QMOPT_DOWARN, &dqp);
>  	if (error)
>  		return error;
>  

Looks like the only caller of xfs_qm_dqattach_one with XFS_QMOPT_DOALLOC
possibly set is xfs_qm_dqattach_locked, which does so based upon its
argument 'flags'.  AFAICS the only caller of xfs_qm_dqattach_locked that
sets this flag is xfs_qm_vop_dqalloc, which is called by
xfs_ioctl_setattr, xfs_setattr_nonsize, xfs_create, and xfs_symlink.

xfs_ioctl_setattr|xfs_setattr_nonsize|xfs_create|xfs_symlink
  xfs_qm_vop_dqalloc
    xfs_qm_dqattach_locked(ip, XFS_QMOPT_DQALLOC
      xfs_qm_dqattach_one

I tried a few things to see if I could hit a problem without the patch
but no luck.

Anyway... Looks good.

Reviewed-by: Ben Myers <bpm@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Ben Myers <bpm@sgi.com>
To: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
Cc: Alex Elder <aelder@sgi.com>,
	Christoph Hellwig <hch@infradead.org>,
	yrl.pp-manager.tt@hitachi.com, linux-kernel@vger.kernel.org,
	xfs@oss.sgi.com, xfs-masters@oss.sgi.com
Subject: Re: [PATCH] [BUGFIX] xfs: use doalloc flag in xfs_qm_dqattach_one()
Date: Tue, 15 Nov 2011 14:23:14 -0600	[thread overview]
Message-ID: <20111115202314.GE29840@sgi.com> (raw)
In-Reply-To: <20111110013310.3408.41745.stgit@ltc219.sdl.hitachi.co.jp>

On Thu, Nov 10, 2011 at 10:33:10AM +0900, Mitsuo Hayasaka wrote:
> The doalloc arg in xfs_qm_dqattach_one() is a flag that indicates
> whether a new area to handle quota information will be allocated
> if needed. Originally, it was passed to xfs_qm_dqget(), but has
> been removed by the following commit (probably by mistake):
> 
> 	commit 8e9b6e7fa4544ea8a0e030c8987b918509c8ff47
> 	Author: Christoph Hellwig <hch@lst.de>
> 	Date:   Sun Feb 8 21:51:42 2009 +0100
> 
> 	xfs: remove the unused XFS_QMOPT_DQLOCK flag
> 
> As the result, xfs_qm_dqget() called from xfs_qm_dqattach_one()
> never allocates the new area even if it is needed.
> 
> This patch gives the doalloc arg to xfs_qm_dqget() in
> xfs_qm_dqattach_one() to fix this problem.
> 
> Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
> Cc: Alex Elder <aelder@sgi.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> ---
> 
>  fs/xfs/xfs_qm.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> index 9a0aa76..95ba6dc 100644
> --- a/fs/xfs/xfs_qm.c
> +++ b/fs/xfs/xfs_qm.c
> @@ -674,7 +674,8 @@ xfs_qm_dqattach_one(
>  	 * disk and we didn't ask it to allocate;
>  	 * ESRCH if quotas got turned off suddenly.
>  	 */
> -	error = xfs_qm_dqget(ip->i_mount, ip, id, type, XFS_QMOPT_DOWARN, &dqp);
> +	error = xfs_qm_dqget(ip->i_mount, ip, id, type,
> +			     doalloc | XFS_QMOPT_DOWARN, &dqp);
>  	if (error)
>  		return error;
>  

Looks like the only caller of xfs_qm_dqattach_one with XFS_QMOPT_DOALLOC
possibly set is xfs_qm_dqattach_locked, which does so based upon its
argument 'flags'.  AFAICS the only caller of xfs_qm_dqattach_locked that
sets this flag is xfs_qm_vop_dqalloc, which is called by
xfs_ioctl_setattr, xfs_setattr_nonsize, xfs_create, and xfs_symlink.

xfs_ioctl_setattr|xfs_setattr_nonsize|xfs_create|xfs_symlink
  xfs_qm_vop_dqalloc
    xfs_qm_dqattach_locked(ip, XFS_QMOPT_DQALLOC
      xfs_qm_dqattach_one

I tried a few things to see if I could hit a problem without the patch
but no luck.

Anyway... Looks good.

Reviewed-by: Ben Myers <bpm@sgi.com>

  parent reply	other threads:[~2011-11-15 20:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-10  1:33 [PATCH] [BUGFIX] xfs: use doalloc flag in xfs_qm_dqattach_one() Mitsuo Hayasaka
2011-11-10  1:33 ` Mitsuo Hayasaka
2011-11-10  7:37 ` Christoph Hellwig
2011-11-10  7:37   ` Christoph Hellwig
2011-11-15 20:23 ` Ben Myers [this message]
2011-11-15 20:23   ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111115202314.GE29840@sgi.com \
    --to=bpm@sgi.com \
    --cc=aelder@sgi.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mitsuo.hayasaka.hu@hitachi.com \
    --cc=xfs-masters@oss.sgi.com \
    --cc=xfs@oss.sgi.com \
    --cc=yrl.pp-manager.tt@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.