From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Cc: Sergey Lapin <slapin@ossfans.org>,
"David S. Miller" <davem@davemloft.net>,
linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [patch -next] 6LoWPAN: double free in lowpan_fragment_xmit()
Date: Wed, 16 Nov 2011 08:21:38 +0000 [thread overview]
Message-ID: <20111116082138.GA10264@elgon.mountain> (raw)
dev_queue_xmit() consumes its own skb, so the call to dev_kfree_skb()
ieee802154/6lowpan.clowpan_fragment_xmits a double free.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
index 602f318..e4ecc1e 100644
--- a/net/ieee802154/6lowpan.c
+++ b/net/ieee802154/6lowpan.c
@@ -980,9 +980,6 @@ lowpan_fragment_xmit(struct sk_buff *skb, u8 *head,
ret = dev_queue_xmit(frag);
- if (ret < 0)
- dev_kfree_skb(frag);
-
return ret;
}
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Cc: Sergey Lapin <slapin@ossfans.org>,
"David S. Miller" <davem@davemloft.net>,
linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [patch -next] 6LoWPAN: double free in lowpan_fragment_xmit()
Date: Wed, 16 Nov 2011 11:21:38 +0300 [thread overview]
Message-ID: <20111116082138.GA10264@elgon.mountain> (raw)
dev_queue_xmit() consumes its own skb, so the call to dev_kfree_skb()
ieee802154/6lowpan.clowpan_fragment_xmits a double free.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
index 602f318..e4ecc1e 100644
--- a/net/ieee802154/6lowpan.c
+++ b/net/ieee802154/6lowpan.c
@@ -980,9 +980,6 @@ lowpan_fragment_xmit(struct sk_buff *skb, u8 *head,
ret = dev_queue_xmit(frag);
- if (ret < 0)
- dev_kfree_skb(frag);
-
return ret;
}
next reply other threads:[~2011-11-16 8:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 8:21 Dan Carpenter [this message]
2011-11-16 8:21 ` [patch -next] 6LoWPAN: double free in lowpan_fragment_xmit() Dan Carpenter
2011-11-16 8:32 ` Dan Carpenter
2011-11-16 8:32 ` Dan Carpenter
2011-11-16 8:36 ` [patch -next v2] " Dan Carpenter
2011-11-16 8:36 ` Dan Carpenter
2011-11-16 8:42 ` Alexander Smirnov
2011-11-16 8:42 ` Alexander Smirnov
2011-11-16 23:14 ` David Miller
2011-11-16 23:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116082138.GA10264@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=davem@davemloft.net \
--cc=dbaryshkov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=slapin@ossfans.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.