From: p-combes@ti.com (Patrick Combes)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH] gpiolib: add irq_wake (power-management) sysfs file
Date: Wed, 16 Nov 2011 18:23:50 +0100 [thread overview]
Message-ID: <20111116172347.GC5847@una0919255> (raw)
In-Reply-To: <20111116143731.GG29986@opensource.wolfsonmicro.com>
On Wed, Nov 16, 2011 at 02:37:31PM +0000, Mark Brown wrote:
> On Wed, Nov 16, 2011 at 03:30:13PM +0100, Patrick Combes wrote:
>
> > > ...this doesn't do anything to stop userspace doing multiple enables and
> > > disables.
>
> > Do you mean there is a need to prevent that?
> > Basically the code above accepts both "1" or "enable" strings to enable the
> > property. I could limit that to "enable" / "disable" if it is confusing.
>
> That's not the problem. The problem is that if you disable it might not
> actually disable the wake if it's previously been enabled multiple times.
You're right; I however wonder if this API should work as 'enable_irq_wake' or
if it should filter multiple enables/disables. I'd have supposed it's a choice
of implementation but based on your comment I understand filtering is the
expected way. I'll modify the function accordingly. Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Patrick Combes <p-combes@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: grant.likely@secretlab.ca, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Hugo Dupras <h-dupras@ti.com>
Subject: Re: [RFC][PATCH] gpiolib: add irq_wake (power-management) sysfs file
Date: Wed, 16 Nov 2011 18:23:50 +0100 [thread overview]
Message-ID: <20111116172347.GC5847@una0919255> (raw)
In-Reply-To: <20111116143731.GG29986@opensource.wolfsonmicro.com>
On Wed, Nov 16, 2011 at 02:37:31PM +0000, Mark Brown wrote:
> On Wed, Nov 16, 2011 at 03:30:13PM +0100, Patrick Combes wrote:
>
> > > ...this doesn't do anything to stop userspace doing multiple enables and
> > > disables.
>
> > Do you mean there is a need to prevent that?
> > Basically the code above accepts both "1" or "enable" strings to enable the
> > property. I could limit that to "enable" / "disable" if it is confusing.
>
> That's not the problem. The problem is that if you disable it might not
> actually disable the wake if it's previously been enabled multiple times.
You're right; I however wonder if this API should work as 'enable_irq_wake' or
if it should filter multiple enables/disables. I'd have supposed it's a choice
of implementation but based on your comment I understand filtering is the
expected way. I'll modify the function accordingly. Thanks
next prev parent reply other threads:[~2011-11-16 17:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 9:40 [RFC][PATCH] gpiolib: add irq_wake (power-management) sysfs file Patrick Combes
2011-11-11 9:40 ` Patrick Combes
2011-11-15 13:16 ` Mark Brown
2011-11-15 13:16 ` Mark Brown
2011-11-15 17:20 ` Russell King - ARM Linux
2011-11-15 17:20 ` Russell King - ARM Linux
2011-11-16 14:39 ` Patrick Combes
2011-11-16 14:39 ` Patrick Combes
2011-11-16 14:30 ` Patrick Combes
2011-11-16 14:30 ` Patrick Combes
2011-11-16 14:37 ` Mark Brown
2011-11-16 14:37 ` Mark Brown
2011-11-16 17:23 ` Patrick Combes [this message]
2011-11-16 17:23 ` Patrick Combes
2011-11-21 7:47 ` Linus Walleij
2011-11-21 7:47 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2011-11-09 16:01 Patrick Combes
2011-11-10 18:50 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116172347.GC5847@una0919255 \
--to=p-combes@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.