From: Thierry Reding <thierry.reding@avionic-design.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid().
Date: Thu, 17 Nov 2011 08:56:58 +0100 [thread overview]
Message-ID: <20111117075658.GA11853@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1321513477-12877-1-git-send-email-thierry.reding@avionic-design.de>
* Thierry Reding wrote:
> Something apparently went wrong when the patch in commit deb5ca8 was
> applied. Commit f75dd58 changed the type of gpt_head to be a pointer and
> correctly adjusted the calls to is_gpt_valid(). But when deb5ca8 got
> applied, the gpt_head was again reverted to &(gpt_head), which was the
> state before deb5ca8.
>
> This commit fixes the passing of gpt_head into is_gpt_valid().
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> ---
> disk/part_efi.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/disk/part_efi.c b/disk/part_efi.c
> index e7f2714..ddf80a7 100644
> --- a/disk/part_efi.c
> +++ b/disk/part_efi.c
> @@ -130,7 +130,7 @@ void print_part_efi(block_dev_desc_t * dev_desc)
> }
> /* This function validates AND fills in the GPT header and PTE */
> if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
> - &(gpt_head), &gpt_pte) != 1) {
> + gpt_head, &gpt_pte) != 1) {
> printf("%s: *** ERROR: Invalid GPT ***\n", __func__);
> return;
> }
> @@ -169,7 +169,7 @@ int get_partition_info_efi(block_dev_desc_t * dev_desc, int part,
>
> /* This function validates AND fills in the GPT header and PTE */
> if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
> - &(gpt_head), &gpt_pte) != 1) {
> + gpt_head, &gpt_pte) != 1) {
> printf("%s: *** ERROR: Invalid GPT ***\n", __func__);
> return -1;
> }
> --
> 1.7.7.3
I had actually set "Doug Anderson <dianders@chromium.org>" on Cc because he
was involved with the initial patch but for some reason he got stripped from
Cc. Does anybody know why this is happening?
It seems like the To: header is unmodified so perhaps I should only be adding
people with --to when sending out patches with "git send-email".
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111117/c608a265/attachment.pgp
next prev parent reply other threads:[~2011-11-17 7:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 7:04 [U-Boot] [PATCH] disk: part_efi: Fix parameters passed to is_gpt_valid() Thierry Reding
2011-11-17 7:56 ` Thierry Reding [this message]
2011-11-17 15:00 ` Stefano Babic
2011-11-17 15:07 ` Thierry Reding
2011-11-17 17:02 ` Tom Warren
2011-11-17 17:48 ` Doug Anderson
2011-11-17 18:33 ` Thierry Reding
2011-11-17 18:31 ` Detlev Zundel
2011-11-17 16:13 ` Stephen Warren
2011-11-17 16:32 ` Thierry Reding
2011-11-17 17:43 ` Premi, Sanjeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117075658.GA11853@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.