From: Joel Becker <jlbec@evilplan.org>
To: Tyler Hicks <tyhicks@canonical.com>
Cc: John Johansen <john.johansen@canonical.com>,
Jan Kara <jack@suse.cz>, Josh Boyer <jwboyer@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Mark Fasheh <mfasheh@suse.com>, Ingo Molnar <mingo@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] vfs: Correctly set the dir i_mutex lockdep class
Date: Thu, 17 Nov 2011 00:35:11 -0800 [thread overview]
Message-ID: <20111117083510.GA7319@noexit.corp.google.com> (raw)
In-Reply-To: <20111110152848.GA5421@boyd>
On Thu, Nov 10, 2011 at 09:28:49AM -0600, Tyler Hicks wrote:
> On 2011-11-10 15:33:19, Jan Kara wrote:
> > On Thu 10-11-11 00:45:00, Tyler Hicks wrote:
> > > This patch removes the negation from the conditional so that the i_mutex
> > > lockdep class is properly set for directory inodes. Special classes are
> > > preserved and directory inodes with unmodified classes are set with
> > > i_mutex_dir_key.
> > Duh, you are right. I wonder how come this did not trigger any lockdep
> > messages during my testing with ocfs2 for which I wrote the patch...
>
> Good question. Adding the ocfs2 maintainers and devel list to cc, as
> this patch is likely to change up their lockdep warnings.
We don't set special classes for dir->i_mutex. We set special
classes on our DLM stuff, and we do it for our system files, but not for
regular directories.
Joel
--
Life's Little Instruction Book #356
"Be there when people need you."
http://www.jlbec.org/
jlbec at evilplan.org
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <jlbec@evilplan.org>
To: Tyler Hicks <tyhicks@canonical.com>
Cc: John Johansen <john.johansen@canonical.com>,
Jan Kara <jack@suse.cz>, Josh Boyer <jwboyer@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Mark Fasheh <mfasheh@suse.com>, Ingo Molnar <mingo@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH] vfs: Correctly set the dir i_mutex lockdep class
Date: Thu, 17 Nov 2011 00:35:11 -0800 [thread overview]
Message-ID: <20111117083510.GA7319@noexit.corp.google.com> (raw)
In-Reply-To: <20111110152848.GA5421@boyd>
On Thu, Nov 10, 2011 at 09:28:49AM -0600, Tyler Hicks wrote:
> On 2011-11-10 15:33:19, Jan Kara wrote:
> > On Thu 10-11-11 00:45:00, Tyler Hicks wrote:
> > > This patch removes the negation from the conditional so that the i_mutex
> > > lockdep class is properly set for directory inodes. Special classes are
> > > preserved and directory inodes with unmodified classes are set with
> > > i_mutex_dir_key.
> > Duh, you are right. I wonder how come this did not trigger any lockdep
> > messages during my testing with ocfs2 for which I wrote the patch...
>
> Good question. Adding the ocfs2 maintainers and devel list to cc, as
> this patch is likely to change up their lockdep warnings.
We don't set special classes for dir->i_mutex. We set special
classes on our DLM stuff, and we do it for our system files, but not for
regular directories.
Joel
--
Life's Little Instruction Book #356
"Be there when people need you."
http://www.jlbec.org/
jlbec@evilplan.org
next prev parent reply other threads:[~2011-11-17 8:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 6:45 [PATCH] vfs: Correctly set the dir i_mutex lockdep class Tyler Hicks
2011-11-10 14:33 ` Jan Kara
2011-11-10 15:28 ` Tyler Hicks
2011-11-17 8:35 ` Joel Becker [this message]
2011-11-17 8:35 ` Joel Becker
2011-12-12 16:02 ` [PATCH][RESEND] " Tyler Hicks
2012-01-20 18:39 ` [PATCH][BUGFIX][RESEND] " Tyler Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117083510.GA7319@noexit.corp.google.com \
--to=jlbec@evilplan.org \
--cc=jack@suse.cz \
--cc=john.johansen@canonical.com \
--cc=jwboyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=mingo@redhat.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=peterz@infradead.org \
--cc=tyhicks@canonical.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.