All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: WuBo <wu.bo@cn.fujitsu.com>
Cc: linux-fsdevel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	xfs@oss.sgi.com
Subject: Re: [PATCH] change fallocate to xfs_io falloc
Date: Thu, 17 Nov 2011 14:50:33 -0600	[thread overview]
Message-ID: <20111117205033.GK29840@sgi.com> (raw)
In-Reply-To: <4EC4989D.9080107@cn.fujitsu.com>

Hey Wu Bo,

On Thu, Nov 17, 2011 at 01:16:13PM +0800, WuBo wrote:
> Thanks to Ben for pointing it that the fallocate maybe uninstall 
> without checking it, and change fallocate to xfs_io as Christoph
> suggested.
> 
> Signed-off-by: Wu Bo <Wu.Bo@cn.fujitsu.com>

Nice!  It works great for me.  ;)

Reviewed-by: Ben Myers <bpm@sgi.com>

Thanks,
	Ben

> ---
>  274 |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/274 b/274
> index b658004..bcf5a11 100755
> --- a/274
> +++ b/274
> @@ -46,6 +46,7 @@ _cleanup()
>  _supported_fs generic
>  _supported_os IRIX Linux
>  _require_scratch
> +_require_xfs_io_falloc
>  
>  echo "------------------------------"
>  echo "preallocation test"
> @@ -67,7 +68,7 @@ then
>  	exit
>  fi
>  
> -fallocate -n -o 4K -l 1M test >/dev/null 2>&1
> +$XFS_IO_PROG -F -f -c 'falloc 4096 1m' test >/dev/null
>  if [ $? -ne 0 ]
>  then
>  	echo "fallocate file err"
> -- 
> 1.7.3.1
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Ben Myers <bpm@sgi.com>
To: WuBo <wu.bo@cn.fujitsu.com>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] change fallocate to xfs_io falloc
Date: Thu, 17 Nov 2011 14:50:33 -0600	[thread overview]
Message-ID: <20111117205033.GK29840@sgi.com> (raw)
In-Reply-To: <4EC4989D.9080107@cn.fujitsu.com>

Hey Wu Bo,

On Thu, Nov 17, 2011 at 01:16:13PM +0800, WuBo wrote:
> Thanks to Ben for pointing it that the fallocate maybe uninstall 
> without checking it, and change fallocate to xfs_io as Christoph
> suggested.
> 
> Signed-off-by: Wu Bo <Wu.Bo@cn.fujitsu.com>

Nice!  It works great for me.  ;)

Reviewed-by: Ben Myers <bpm@sgi.com>

Thanks,
	Ben

> ---
>  274 |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/274 b/274
> index b658004..bcf5a11 100755
> --- a/274
> +++ b/274
> @@ -46,6 +46,7 @@ _cleanup()
>  _supported_fs generic
>  _supported_os IRIX Linux
>  _require_scratch
> +_require_xfs_io_falloc
>  
>  echo "------------------------------"
>  echo "preallocation test"
> @@ -67,7 +68,7 @@ then
>  	exit
>  fi
>  
> -fallocate -n -o 4K -l 1M test >/dev/null 2>&1
> +$XFS_IO_PROG -F -f -c 'falloc 4096 1m' test >/dev/null
>  if [ $? -ne 0 ]
>  then
>  	echo "fallocate file err"
> -- 
> 1.7.3.1
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-11-17 20:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-03  3:05 [PATCH 0/3] xfstests: Add a group of reservation space test WuBo
2011-11-03  3:05 ` WuBo
2011-11-03  3:08 ` [PATCH 1/3] xfstests 264: add a copy and reserve test WuBo
2011-11-03  3:08   ` WuBo
2011-11-03  6:55   ` Christoph Hellwig
2011-11-03  6:55     ` Christoph Hellwig
2011-11-03  8:04     ` WuBo
2011-11-03  8:04       ` WuBo
2011-11-03  3:09 ` [PATCH 2/3] xfstests 265: add a prealloc " WuBo
2011-11-03  3:09   ` WuBo
2011-11-15 18:21   ` Ben Myers
2011-11-15 18:21     ` Ben Myers
2011-11-15 19:08     ` Christoph Hellwig
2011-11-15 19:08       ` Christoph Hellwig
2011-11-16  1:30       ` WuBo
2011-11-16  1:30         ` WuBo
2011-11-03  3:09 ` [PATCH 3/3] xfstests 266: add a write " WuBo
2011-11-03  3:09   ` WuBo
2011-11-17  5:16 ` [PATCH] change fallocate to xfs_io falloc WuBo
2011-11-17  5:16   ` WuBo
2011-11-17 20:50   ` Ben Myers [this message]
2011-11-17 20:50     ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111117205033.GK29840@sgi.com \
    --to=bpm@sgi.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=wu.bo@cn.fujitsu.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.