From: Andrew Morton <akpm@linux-foundation.org>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH] mm: account reaped page cache on inode cache pruning
Date: Thu, 17 Nov 2011 22:52:02 -0800 [thread overview]
Message-ID: <20111117225202.3535aba3.akpm@linux-foundation.org> (raw)
In-Reply-To: <4EC5FE6A.3080003@openvz.org>
On Fri, 18 Nov 2011 10:42:50 +0400 Konstantin Khlebnikov <khlebnikov@openvz.org> wrote:
> Do we really need separate on-stack reclaim_state structure with single field?
> Maybe replace it with single long (or even unsigned int) .reclaimed_pages field on task_struct
> and account reclaimed pages unconditionally.
I don't think it matters a lot - it's either a temporary pointer on the
stack or a permanent space consumption in the task_struct.
The way thing are at present we can easily add new fields if needed. I
don't think we've ever done that though.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH] mm: account reaped page cache on inode cache pruning
Date: Thu, 17 Nov 2011 22:52:02 -0800 [thread overview]
Message-ID: <20111117225202.3535aba3.akpm@linux-foundation.org> (raw)
In-Reply-To: <4EC5FE6A.3080003@openvz.org>
On Fri, 18 Nov 2011 10:42:50 +0400 Konstantin Khlebnikov <khlebnikov@openvz.org> wrote:
> Do we really need separate on-stack reclaim_state structure with single field?
> Maybe replace it with single long (or even unsigned int) .reclaimed_pages field on task_struct
> and account reclaimed pages unconditionally.
I don't think it matters a lot - it's either a temporary pointer on the
stack or a permanent space consumption in the task_struct.
The way thing are at present we can easily add new fields if needed. I
don't think we've ever done that though.
next prev parent reply other threads:[~2011-11-18 6:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 14:47 [PATCH] mm: account reaped page cache on inode cache pruning Konstantin Khlebnikov
2011-11-16 14:47 ` Konstantin Khlebnikov
2011-11-18 0:23 ` Andrew Morton
2011-11-18 0:23 ` Andrew Morton
2011-11-18 6:42 ` Konstantin Khlebnikov
2011-11-18 6:42 ` Konstantin Khlebnikov
2011-11-18 6:52 ` Andrew Morton [this message]
2011-11-18 6:52 ` Andrew Morton
2011-11-18 7:32 ` Konstantin Khlebnikov
2011-11-18 7:32 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117225202.3535aba3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.