All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
To: Peter De Schrijver
	<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Grant Likely
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 08/10] arm/tegra: pinmux tables and definitions for tegra30
Date: Fri, 18 Nov 2011 13:43:24 -0800	[thread overview]
Message-ID: <20111118214324.GD31678@quad.lixom.net> (raw)
In-Reply-To: <1321546766-26770-9-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Hi,


> @@ -667,7 +710,12 @@ void tegra_pinmux_config_pullupdown_table(const struct tegra_pingroup_config *co
>  }
>  
>  static struct of_device_id tegra_pinmux_of_match[] __devinitdata = {
> +#ifdef CONFIG_ARCH_TEGRA_2x_SOC
>  	{ .compatible = "nvidia,tegra20-pinmux", tegra20_pinmux_init },
> +#endif
> +#ifdef CONFIG_ARCH_TEGRA_3x_SOC
> +	{ .compatible = "nvidia,tegra30-pinmux", tegra30_pinmux_init },
> +#endif

Again, provide empty stubs instead of ifdeffing the table.


-Olof

WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/10] arm/tegra: pinmux tables and definitions for tegra30
Date: Fri, 18 Nov 2011 13:43:24 -0800	[thread overview]
Message-ID: <20111118214324.GD31678@quad.lixom.net> (raw)
In-Reply-To: <1321546766-26770-9-git-send-email-pdeschrijver@nvidia.com>

Hi,


> @@ -667,7 +710,12 @@ void tegra_pinmux_config_pullupdown_table(const struct tegra_pingroup_config *co
>  }
>  
>  static struct of_device_id tegra_pinmux_of_match[] __devinitdata = {
> +#ifdef CONFIG_ARCH_TEGRA_2x_SOC
>  	{ .compatible = "nvidia,tegra20-pinmux", tegra20_pinmux_init },
> +#endif
> +#ifdef CONFIG_ARCH_TEGRA_3x_SOC
> +	{ .compatible = "nvidia,tegra30-pinmux", tegra30_pinmux_init },
> +#endif

Again, provide empty stubs instead of ifdeffing the table.


-Olof

WARNING: multiple messages have this Message-ID (diff)
From: Olof Johansson <olof@lixom.net>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
	Rob Herring <rob.herring@calxeda.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Russell King <linux@arm.linux.org.uk>,
	Colin Cross <ccross@android.com>,
	Stephen Warren <swarren@nvidia.com>,
	devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH 08/10] arm/tegra: pinmux tables and definitions for tegra30
Date: Fri, 18 Nov 2011 13:43:24 -0800	[thread overview]
Message-ID: <20111118214324.GD31678@quad.lixom.net> (raw)
In-Reply-To: <1321546766-26770-9-git-send-email-pdeschrijver@nvidia.com>

Hi,


> @@ -667,7 +710,12 @@ void tegra_pinmux_config_pullupdown_table(const struct tegra_pingroup_config *co
>  }
>  
>  static struct of_device_id tegra_pinmux_of_match[] __devinitdata = {
> +#ifdef CONFIG_ARCH_TEGRA_2x_SOC
>  	{ .compatible = "nvidia,tegra20-pinmux", tegra20_pinmux_init },
> +#endif
> +#ifdef CONFIG_ARCH_TEGRA_3x_SOC
> +	{ .compatible = "nvidia,tegra30-pinmux", tegra30_pinmux_init },
> +#endif

Again, provide empty stubs instead of ifdeffing the table.


-Olof


  parent reply	other threads:[~2011-11-18 21:43 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-17 16:19 [PATCH v5 00/10] Add support for tegra30 and cardhu Peter De Schrijver
2011-11-17 16:19 ` Peter De Schrijver
2011-11-17 16:19 ` Peter De Schrijver
2011-11-17 16:19 ` [PATCH 01/10] arm/tegra: initial device tree for tegra30 Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 19:39   ` Stephen Warren
2011-11-17 19:39     ` Stephen Warren
2011-11-17 19:39     ` Stephen Warren
2011-11-18 18:49     ` Olof Johansson
2011-11-18 18:49       ` Olof Johansson
2011-11-18 19:30       ` Rob Herring
2011-11-18 19:30         ` Rob Herring
     [not found]         ` <4EC6B25D.70708-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-11-18 21:48           ` Olof Johansson
2011-11-18 21:48             ` Olof Johansson
2011-11-18 21:48             ` Olof Johansson
2011-11-18 22:03             ` Rob Herring
2011-11-18 22:03               ` Rob Herring
2011-11-17 16:19 ` [PATCH 02/10] arm/tegra: cleanup tegra20 support Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
     [not found] ` <1321546766-26770-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-11-17 16:19   ` [PATCH 03/10] arm/tegra: prepare clock code for multiple tegra variants Peter De Schrijver
2011-11-17 16:19     ` Peter De Schrijver
2011-11-17 16:19     ` Peter De Schrijver
     [not found]     ` <1321546766-26770-4-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-11-18 19:06       ` Olof Johansson
2011-11-18 19:06         ` Olof Johansson
2011-11-18 19:06         ` Olof Johansson
2011-11-18 20:18         ` Stephen Warren
2011-11-18 20:18           ` Stephen Warren
2011-11-18 21:25           ` Olof Johansson
2011-11-18 21:25             ` Olof Johansson
     [not found]             ` <CAOesGMix=CG5s8Ux_fiLKmSqdoVJgm5skm2MBrHg3YrNCyHaUg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-18 21:38               ` Stephen Warren
2011-11-18 21:38                 ` Stephen Warren
2011-11-18 21:38                 ` Stephen Warren
2011-11-21 12:44         ` Peter De Schrijver
2011-11-21 12:44           ` Peter De Schrijver
2011-11-17 16:49   ` [PATCH v5 00/10] Add support for tegra30 and cardhu Peter De Schrijver
2011-11-17 16:49   ` Peter De Schrijver
2011-11-17 16:19 ` [PATCH 04/10] arm/tegra: prepare early init for multiple tegra variants Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 16:55   ` Russell King - ARM Linux
2011-11-17 16:55     ` Russell King - ARM Linux
2011-11-17 16:19 ` [PATCH 05/10] arm/tegra: rename tegra20 pinmux files Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 16:19 ` [PATCH 06/10] arm/tegra: prepare pinmux code for multiple tegra variants Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
     [not found]   ` <1321546766-26770-7-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-11-18 21:41     ` Olof Johansson
2011-11-18 21:41       ` Olof Johansson
2011-11-18 21:41       ` Olof Johansson
     [not found]       ` <20111118214116.GC31678-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2011-11-21 14:29         ` Peter De Schrijver
2011-11-21 14:29           ` Peter De Schrijver
2011-11-21 14:29           ` Peter De Schrijver
     [not found]           ` <20111121142919.GN19069-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2011-11-21 17:24             ` Stephen Warren
2011-11-21 17:24               ` Stephen Warren
2011-11-21 17:24               ` Stephen Warren
2011-11-22 19:01             ` Olof Johansson
2011-11-22 19:01               ` Olof Johansson
2011-11-22 19:01               ` Olof Johansson
2011-11-23  3:22               ` Peter De Schrijver
2011-11-23  3:22                 ` Peter De Schrijver
2011-11-17 16:19 ` [PATCH 07/10] arm/tegra: add new fields to struct tegra_pingroup_desc Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 16:19 ` [PATCH 08/10] arm/tegra: pinmux tables and definitions for tegra30 Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
     [not found]   ` <1321546766-26770-9-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-11-18 21:43     ` Olof Johansson [this message]
2011-11-18 21:43       ` Olof Johansson
2011-11-18 21:43       ` Olof Johansson
     [not found]       ` <20111118214324.GD31678-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2011-11-18 21:51         ` Stephen Warren
2011-11-18 21:51           ` Stephen Warren
2011-11-18 21:51           ` Stephen Warren
2011-11-18 21:56           ` Olof Johansson
2011-11-18 21:56             ` Olof Johansson
2011-11-17 16:19 ` [PATCH 09/10] arm/tegra: implement support " Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 19:50   ` Stephen Warren
2011-11-17 19:50     ` Stephen Warren
2011-11-17 19:50     ` Stephen Warren
2011-11-17 16:19 ` [PATCH 10/10] arm/tegra: add support for tegra30 based board cardhu Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 16:19   ` Peter De Schrijver
2011-11-17 16:49 ` [PATCH v5 00/10] Add support for tegra30 and cardhu Peter De Schrijver
2011-11-17 16:49   ` Peter De Schrijver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111118214324.GD31678@quad.lixom.net \
    --to=olof-nzht3qvonbneowh0uzbu5w@public.gmane.org \
    --cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.