All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] iwlegacy: off by one in iwl3945_hw_build_tx_cmd_rate()
Date: Mon, 21 Nov 2011 08:52:15 +0000	[thread overview]
Message-ID: <20111121085150.GC2787@redhat.com> (raw)
In-Reply-To: <20111120210400.GB7354@elgon.mountain>

On Mon, Nov 21, 2011 at 12:04:00AM +0300, Dan Carpenter wrote:
> We use "rate_index" like this:
> 	rate = iwl3945_rates[rate_index].plcp;
> The iwl3945_rates[] array has IWL_RATE_COUNT_3945 elements so the
> limit here is off by one.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks Dan. I queued patch into iwlegacy github tree on top
of my current changes, otherwise there would be problems with
merging.

Thanks
Stanislaw

WARNING: multiple messages have this Message-ID (diff)
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] iwlegacy: off by one in iwl3945_hw_build_tx_cmd_rate()
Date: Mon, 21 Nov 2011 09:52:15 +0100	[thread overview]
Message-ID: <20111121085150.GC2787@redhat.com> (raw)
In-Reply-To: <20111120210400.GB7354@elgon.mountain>

On Mon, Nov 21, 2011 at 12:04:00AM +0300, Dan Carpenter wrote:
> We use "rate_index" like this:
> 	rate = iwl3945_rates[rate_index].plcp;
> The iwl3945_rates[] array has IWL_RATE_COUNT_3945 elements so the
> limit here is off by one.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks Dan. I queued patch into iwlegacy github tree on top
of my current changes, otherwise there would be problems with
merging.

Thanks
Stanislaw

  reply	other threads:[~2011-11-21  8:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-20 21:04 [patch] iwlegacy: off by one in iwl3945_hw_build_tx_cmd_rate() Dan Carpenter
2011-11-20 21:04 ` Dan Carpenter
2011-11-21  8:52 ` Stanislaw Gruszka [this message]
2011-11-21  8:52   ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111121085150.GC2787@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.