From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
Misael Lopez Cruz <misael.lopez@ti.com>
Subject: Re: [PATCH 2/2] ASoC: sdp4430: Fix Panda support
Date: Mon, 21 Nov 2011 13:38:36 +0000 [thread overview]
Message-ID: <20111121133836.GA22906@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1321881246-24163-3-git-send-email-peter.ujfalusi@ti.com>
On Mon, Nov 21, 2011 at 03:14:06PM +0200, Peter Ujfalusi wrote:
> - if (!machine_is_omap_4430sdp())
> + if (machine_is_omap_4430sdp())
> + snd_soc_sdp4430.name = "OMAP4 SDP";
> + else if (machine_is_omap4_panda())
> + snd_soc_sdp4430.name = "OMAP4 Panda";
> + else
I'm not thrilled by this given that I'd imagine this'll end up like
Beagle and have lots of derivatives. Why not just change the string to
be something generic along the lines of "OMAP4 audio reference design"
rather than the name of a particular board?
next prev parent reply other threads:[~2011-11-21 13:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 13:14 [PATCH 0/2] ASoC: Fix Panda board support Peter Ujfalusi
2011-11-21 13:14 ` [PATCH 1/2] ASoC: sdp4430: No need to announce the loading of the driver Peter Ujfalusi
2011-11-21 13:14 ` [PATCH 2/2] ASoC: sdp4430: Fix Panda support Peter Ujfalusi
2011-11-21 13:38 ` Mark Brown [this message]
2011-11-21 14:17 ` Ujfalusi, Peter
2011-11-21 14:19 ` Mark Brown
2011-11-21 14:29 ` Ujfalusi, Peter
2011-11-21 14:36 ` Mark Brown
2011-11-21 14:17 ` Girdwood, Liam
2011-11-21 13:37 ` [PATCH 0/2] ASoC: Fix Panda board support Ujfalusi, Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121133836.GA22906@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.