All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Ujfalusi, Peter" <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
	Misael Lopez Cruz <misael.lopez@ti.com>
Subject: Re: [PATCH 2/2] ASoC: sdp4430: Fix Panda support
Date: Mon, 21 Nov 2011 14:36:05 +0000	[thread overview]
Message-ID: <20111121143605.GC22906@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAPo=G1zg=rgu84rEBigoUnX+LPDdg13LGwzi9XqVMkYYL5fNbA@mail.gmail.com>

On Mon, Nov 21, 2011 at 04:29:54PM +0200, Ujfalusi, Peter wrote:
> On Mon, Nov 21, 2011 at 4:19 PM, Mark Brown

> > Well, that's rather different to what your patch did - I'd expect your
> > patch would also be avoiding setting up all the not connected stuff on
> > Panda.  Perhaps what's needed is platform data (which can have a DT
> > representation when that comes) which represents the differences and can
> > include the name to use?

> Ultimately this is the plan, but for 3.2 it would have been too big of a change.
> I just happen to had the DMIC support done locally first (will send it soon).
> Just reordered the patches, since we feel that 3.2 kernel would
> deserve fix for the
> Panda audio, and obviously the DMIC will go for 3.3.

I'd suggest just jumping straight to platform data now, making it
mandatory and using that to grab the name.  That'll be more ready for
device tree and make life a bit easier for people carrying patches for
further derivatives.  The platform data can then be extended to support
new features and a device tree binding added for it.

Please also fix the word wrapping in whatever mailer you're using.

  reply	other threads:[~2011-11-21 14:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 13:14 [PATCH 0/2] ASoC: Fix Panda board support Peter Ujfalusi
2011-11-21 13:14 ` [PATCH 1/2] ASoC: sdp4430: No need to announce the loading of the driver Peter Ujfalusi
2011-11-21 13:14 ` [PATCH 2/2] ASoC: sdp4430: Fix Panda support Peter Ujfalusi
2011-11-21 13:38   ` Mark Brown
2011-11-21 14:17     ` Ujfalusi, Peter
2011-11-21 14:19       ` Mark Brown
2011-11-21 14:29         ` Ujfalusi, Peter
2011-11-21 14:36           ` Mark Brown [this message]
2011-11-21 14:17     ` Girdwood, Liam
2011-11-21 13:37 ` [PATCH 0/2] ASoC: Fix Panda board support Ujfalusi, Peter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111121143605.GC22906@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lrg@ti.com \
    --cc=misael.lopez@ti.com \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.