From: John W. Linville <linville@tuxdriver.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH v2] ath9k: Improve ath_tx_aggr_stop to avoid TID stuck in cleanup state.
Date: Mon, 21 Nov 2011 14:34:22 -0500 [thread overview]
Message-ID: <20111121193422.GD7153@tuxdriver.com> (raw)
In-Reply-To: <1321767035-3263-1-git-send-email-mar.kolya@gmail.com>
On Sun, Nov 20, 2011 at 12:30:35AM -0500, Nikolay Martynov wrote:
> From: kolya <mar.kolya@gmail.com>
>
> When tx agg is being stopped TID is flushed using ath_tx_flush_tid. It is possible that ath_tx_flush_tid completelly flushes TID (if all packets in this TID have already been retried). If this happened ath_tx_aggr_stop would leave TID in cleanup state permanently. Fix this by making ath_tx_flush_tid remove AGGR_ADDBA_COMPLETE and AGGR_CLEANUP flags from TID status if TID is empty.
Please follow the suggestions Kalle made about your patch. Please also
include a Signed-off-by line.
John
--
John W. Linville Someday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: Nikolay Martynov <mar.kolya@gmail.com>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net,
rodrigue@qca.qualcomm.com
Subject: Re: [PATCH v2] ath9k: Improve ath_tx_aggr_stop to avoid TID stuck in cleanup state.
Date: Mon, 21 Nov 2011 14:34:22 -0500 [thread overview]
Message-ID: <20111121193422.GD7153@tuxdriver.com> (raw)
In-Reply-To: <1321767035-3263-1-git-send-email-mar.kolya@gmail.com>
On Sun, Nov 20, 2011 at 12:30:35AM -0500, Nikolay Martynov wrote:
> From: kolya <mar.kolya@gmail.com>
>
> When tx agg is being stopped TID is flushed using ath_tx_flush_tid. It is possible that ath_tx_flush_tid completelly flushes TID (if all packets in this TID have already been retried). If this happened ath_tx_aggr_stop would leave TID in cleanup state permanently. Fix this by making ath_tx_flush_tid remove AGGR_ADDBA_COMPLETE and AGGR_CLEANUP flags from TID status if TID is empty.
Please follow the suggestions Kalle made about your patch. Please also
include a Signed-off-by line.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-11-21 19:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 5:30 [ath9k-devel] [PATCH v2] ath9k: Improve ath_tx_aggr_stop to avoid TID stuck in cleanup state Nikolay Martynov
2011-11-20 5:30 ` Nikolay Martynov
2011-11-21 19:34 ` John W. Linville [this message]
2011-11-21 19:34 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121193422.GD7153@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.