From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ath6kl: use a larger buffer for debug output
Date: Mon, 21 Nov 2011 19:58:23 +0000 [thread overview]
Message-ID: <20111121195823.GN29436@mwanda> (raw)
In-Reply-To: <4ECA826F.8010605@qca.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
On Mon, Nov 21, 2011 at 06:55:11PM +0200, Kalle Valo wrote:
> >> len = snprintf(buf, sizeof(buf), "%u %u\n", ar->listen_intvl_t,
> >> ar->listen_intvl_b);
> >> + len = min(sizeof(buf), len);
> >
> > Maybe that should be scnprintf instead then?
>
> Yeah, I agree. And most likely debug.c has even more cases where
> scnprintf() is needed.
>
Yes yes. Obviously. I sent the patch at 5 pm on Friday and lost
track of it for a bit. I'll send a fixed version tomorrow morning.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ath6kl: use a larger buffer for debug output
Date: Mon, 21 Nov 2011 22:58:23 +0300 [thread overview]
Message-ID: <20111121195823.GN29436@mwanda> (raw)
In-Reply-To: <4ECA826F.8010605@qca.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
On Mon, Nov 21, 2011 at 06:55:11PM +0200, Kalle Valo wrote:
> >> len = snprintf(buf, sizeof(buf), "%u %u\n", ar->listen_intvl_t,
> >> ar->listen_intvl_b);
> >> + len = min(sizeof(buf), len);
> >
> > Maybe that should be scnprintf instead then?
>
> Yeah, I agree. And most likely debug.c has even more cases where
> scnprintf() is needed.
>
Yes yes. Obviously. I sent the patch at 5 pm on Friday and lost
track of it for a bit. I'll send a fixed version tomorrow morning.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-21 19:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 14:09 [patch] ath6kl: use a larger buffer for debug output Dan Carpenter
2011-11-18 14:09 ` Dan Carpenter
2011-11-18 14:11 ` Johannes Berg
2011-11-18 14:11 ` Johannes Berg
2011-11-21 16:55 ` Kalle Valo
2011-11-21 16:55 ` Kalle Valo
2011-11-21 19:58 ` Dan Carpenter [this message]
2011-11-21 19:58 ` Dan Carpenter
2011-11-23 6:34 ` [patch v2] " Dan Carpenter
2011-11-23 6:34 ` Dan Carpenter
2011-11-24 12:29 ` Kalle Valo
2011-11-24 12:29 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121195823.GN29436@mwanda \
--to=dan.carpenter@oracle.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.