All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: linux-next: build warning after merge of the wireless-next tree
Date: Tue, 22 Nov 2011 08:56:41 +0100	[thread overview]
Message-ID: <20111122075640.GB2199@redhat.com> (raw)
In-Reply-To: <20111122142502.ca68d0a1640b2a8480d51ad2@canb.auug.org.au>

On Tue, Nov 22, 2011 at 02:25:02PM +1100, Stephen Rothwell wrote:
> After merging the wireless-next tree, today's linux-next build
> (x86_64_allmodconfig) produced this warning:
> 
> drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: data definition has no type or storage class [enabled by default]
> drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
> drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: data definition has no type or storage class [enabled by default]
> drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
> drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: parameter names (without types) in function declaration [enabled by default]
> 
> This indicates that this file needs to include export.h.

I think adding export.h to debug.c should be part of current
wireless-next manual merge (debug.c include old iwl-debugfs.c,
which was modified with export.h). If not, I'm posting patch
with fix in the following email.

Thanks
Stanislaw

  reply	other threads:[~2011-11-22  7:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22  3:25 linux-next: build warning after merge of the wireless-next tree Stephen Rothwell
2011-11-22  7:56 ` Stanislaw Gruszka [this message]
2011-11-22  7:59   ` [PATCH linux-next] iwlegacy: debug.c needs export.h Stanislaw Gruszka
2011-11-22 10:36     ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2013-04-04  1:00 linux-next: build warning after merge of the wireless-next tree Stephen Rothwell
2013-04-04  1:04 ` Stephen Rothwell
2013-04-04  1:17   ` Larry Finger
2013-04-04  2:36     ` Stephen Rothwell
2013-04-04  2:58       ` Larry Finger
2013-04-05  5:46 Stephen Rothwell
2014-09-30  8:46 Stephen Rothwell
2014-09-30 14:41 ` Larry Finger
2022-05-17 10:00 Stephen Rothwell
2022-05-18  4:51 ` Kalle Valo
2022-06-21 10:02 Stephen Rothwell
2023-01-19  5:24 Stephen Rothwell
2023-02-15  4:17 Stephen Rothwell
2023-02-15  4:20 Stephen Rothwell
2023-03-23  3:15 Stephen Rothwell
2023-03-31 11:10 ` Kalle Valo
2023-09-12  5:10 Stephen Rothwell
2023-09-14  2:49 Stephen Rothwell
2024-02-09  3:29 Stephen Rothwell
2024-02-09  7:06 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111122075640.GB2199@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.