From: Mike Snitzer <snitzer@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Jens Axboe <axboe@kernel.dk>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Dave Young <dyoung@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>
Subject: Re: block: initialize request_queue's numa node during allocation
Date: Tue, 22 Nov 2011 17:02:18 -0500 [thread overview]
Message-ID: <20111122220218.GA17543@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1111221342320.2621@chino.kir.corp.google.com>
On Tue, Nov 22 2011 at 4:45pm -0500,
David Rientjes <rientjes@google.com> wrote:
> On Tue, 22 Nov 2011, Mike Snitzer wrote:
>
> > From: Mike Snitzer <snitzer@redhat.com>
> > Subject: block: initialize request_queue's numa node during allocation
> >
> > Set request_queue's node in blk_alloc_queue_node() rather than
> > blk_init_allocated_queue_node(). This avoids blk_throtl_init() using
> > q->node before it is initialized.
> >
> > Rename blk_init_allocated_queue_node() to blk_init_allocated_queue().
> >
> > Signed-off-by: Mike Snitzer <snitzer@redhat.com>
>
> When I debug an issue and suggest a patch to fix it in addition to
> suggesting the possible cleanup for blk_init_allocated_queue_node(), I
> don't expect that you'll just take it and claim it as your own, sheesh.
Sorry I pissed you off. But I'm not that hard up for credit. I was
just looking to make sure proper _code_ changes occurred ;) I didn't
take enough time to fully appreciate the long road you've travelled on
this.
Jens, I'll defer to David to post a proper patch header. David please
claim the patch and its contents as your own in v2. But feel free to
add my Signed-off-by.
Thanks,
Mike
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Jens Axboe <axboe@kernel.dk>, Vivek Goyal <vgoyal@redhat.com>,
Dave Young <dyoung@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kexec@lists.infradead.org
Subject: Re: block: initialize request_queue's numa node during allocation
Date: Tue, 22 Nov 2011 17:02:18 -0500 [thread overview]
Message-ID: <20111122220218.GA17543@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1111221342320.2621@chino.kir.corp.google.com>
On Tue, Nov 22 2011 at 4:45pm -0500,
David Rientjes <rientjes@google.com> wrote:
> On Tue, 22 Nov 2011, Mike Snitzer wrote:
>
> > From: Mike Snitzer <snitzer@redhat.com>
> > Subject: block: initialize request_queue's numa node during allocation
> >
> > Set request_queue's node in blk_alloc_queue_node() rather than
> > blk_init_allocated_queue_node(). This avoids blk_throtl_init() using
> > q->node before it is initialized.
> >
> > Rename blk_init_allocated_queue_node() to blk_init_allocated_queue().
> >
> > Signed-off-by: Mike Snitzer <snitzer@redhat.com>
>
> When I debug an issue and suggest a patch to fix it in addition to
> suggesting the possible cleanup for blk_init_allocated_queue_node(), I
> don't expect that you'll just take it and claim it as your own, sheesh.
Sorry I pissed you off. But I'm not that hard up for credit. I was
just looking to make sure proper _code_ changes occurred ;) I didn't
take enough time to fully appreciate the long road you've travelled on
this.
Jens, I'll defer to David to post a proper patch header. David please
claim the patch and its contents as your own in v2. But feel free to
add my Signed-off-by.
Thanks,
Mike
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Jens Axboe <axboe@kernel.dk>, Vivek Goyal <vgoyal@redhat.com>,
Dave Young <dyoung@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kexec@lists.infradead.org
Subject: Re: block: initialize request_queue's numa node during allocation
Date: Tue, 22 Nov 2011 17:02:18 -0500 [thread overview]
Message-ID: <20111122220218.GA17543@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1111221342320.2621@chino.kir.corp.google.com>
On Tue, Nov 22 2011 at 4:45pm -0500,
David Rientjes <rientjes@google.com> wrote:
> On Tue, 22 Nov 2011, Mike Snitzer wrote:
>
> > From: Mike Snitzer <snitzer@redhat.com>
> > Subject: block: initialize request_queue's numa node during allocation
> >
> > Set request_queue's node in blk_alloc_queue_node() rather than
> > blk_init_allocated_queue_node(). This avoids blk_throtl_init() using
> > q->node before it is initialized.
> >
> > Rename blk_init_allocated_queue_node() to blk_init_allocated_queue().
> >
> > Signed-off-by: Mike Snitzer <snitzer@redhat.com>
>
> When I debug an issue and suggest a patch to fix it in addition to
> suggesting the possible cleanup for blk_init_allocated_queue_node(), I
> don't expect that you'll just take it and claim it as your own, sheesh.
Sorry I pissed you off. But I'm not that hard up for credit. I was
just looking to make sure proper _code_ changes occurred ;) I didn't
take enough time to fully appreciate the long road you've travelled on
this.
Jens, I'll defer to David to post a proper patch header. David please
claim the patch and its contents as your own in v2. But feel free to
add my Signed-off-by.
Thanks,
Mike
next prev parent reply other threads:[~2011-11-22 22:02 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 8:25 BUG: zonelist->_zonerefs == 0x1c08 Dave Young
2011-11-22 8:25 ` Dave Young
2011-11-22 8:25 ` Dave Young
2011-11-22 8:29 ` Dave Young
2011-11-22 8:29 ` Dave Young
2011-11-22 8:29 ` Dave Young
2011-11-22 10:00 ` David Rientjes
2011-11-22 10:00 ` David Rientjes
2011-11-22 10:00 ` David Rientjes
2011-11-22 15:27 ` Vivek Goyal
2011-11-22 15:27 ` Vivek Goyal
2011-11-22 15:27 ` Vivek Goyal
2011-11-22 21:19 ` [PATCH] block: initialize request_queue's numa node during allocation Mike Snitzer
2011-11-22 21:19 ` Mike Snitzer
2011-11-22 21:19 ` Mike Snitzer
2011-11-22 21:32 ` Vivek Goyal
2011-11-22 21:32 ` Vivek Goyal
2011-11-22 21:32 ` Vivek Goyal
2011-11-22 21:45 ` David Rientjes
2011-11-22 21:45 ` David Rientjes
2011-11-22 21:45 ` David Rientjes
2011-11-22 22:02 ` Mike Snitzer [this message]
2011-11-22 22:02 ` Mike Snitzer
2011-11-22 22:02 ` Mike Snitzer
2011-11-23 1:14 ` [patch v2 for-3.2] " David Rientjes
2011-11-23 1:14 ` David Rientjes
2011-11-23 1:14 ` David Rientjes
2011-11-23 1:39 ` Dave Young
2011-11-23 1:39 ` Dave Young
2011-11-23 1:39 ` Dave Young
2011-11-23 9:59 ` Jens Axboe
2011-11-23 9:59 ` Jens Axboe
2011-11-23 9:59 ` Jens Axboe
2011-11-22 22:13 ` Mike Snitzer
2011-11-22 22:13 ` Mike Snitzer
2011-11-22 22:13 ` Mike Snitzer
2011-11-23 1:23 ` BUG: zonelist->_zonerefs == 0x1c08 Dave Young
2011-11-23 1:23 ` Dave Young
2011-11-23 1:23 ` Dave Young
2011-11-23 2:05 ` Dave Young
2011-11-23 2:05 ` Dave Young
2011-11-23 2:05 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122220218.GA17543@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.