From: Greg KH <gregkh@suse.de>
To: Corentin Chary <corentincj@iksaif.net>
Cc: platform-driver-x86@vger.kernel.org,
Matthew Garrett <mjg@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/15] samsung-laptop: ehance SABI support
Date: Tue, 22 Nov 2011 14:18:29 -0800 [thread overview]
Message-ID: <20111122221829.GB24283@suse.de> (raw)
In-Reply-To: <1321999366-23784-6-git-send-email-corentincj@iksaif.net>
On Tue, Nov 22, 2011 at 11:02:36PM +0100, Corentin Chary wrote:
> * SABI command are on 16 bits, not 8
Are you sure about that? I guess this would work, and we rely on the
bits being in the right order so everything works properly?
> * SABI can read/write up to 11 byte of data
It can?
> * There is not real difference between "get" and "set"
> commands, so refactorise the code of both functions
Ah, nice, I always wanted to do that.
> Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
next prev parent reply other threads:[~2011-11-22 22:18 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 22:02 [PATCH 00/15] samsung-laptop updates Corentin Chary
2011-11-22 22:02 ` [PATCH 01/15] samsung-laptop: put all local variables in a single structure Corentin Chary
2011-11-22 22:18 ` Greg KH
2011-11-22 22:02 ` [PATCH 02/15] samsung-laptop: move code into init/exit functions Corentin Chary
2011-11-22 22:19 ` Greg KH
2011-11-23 6:24 ` Corentin Chary
2011-11-22 22:02 ` [PATCH 03/15] samsung-laptop: don't handle backlight if handled by acpi/video Corentin Chary
2011-11-22 22:16 ` Greg KH
2011-11-23 6:58 ` Corentin Chary
2011-11-23 20:30 ` Greg KH
2011-11-23 16:01 ` David Herrmann
2011-11-22 22:02 ` [PATCH 04/15] samsung-laptop: use a sysfs group Corentin Chary
2011-11-22 22:19 ` Greg KH
2011-11-22 22:02 ` [PATCH 05/15] samsung-laptop: ehance SABI support Corentin Chary
2011-11-22 22:18 ` Greg KH [this message]
2011-11-23 6:22 ` Corentin Chary
2011-11-22 22:02 ` [PATCH 06/15] samsung-laptop: add small debugfs interface Corentin Chary
2011-11-22 22:20 ` Greg KH
2011-11-23 6:27 ` Corentin Chary
2011-11-22 22:02 ` [PATCH 07/15] samsung-laptop: remove selftest Corentin Chary
2011-11-22 22:21 ` Greg KH
2011-11-22 22:02 ` [PATCH 08/15] samsung-laptop: add battery life extender support Corentin Chary
2011-11-22 22:21 ` Greg KH
2011-11-23 6:28 ` Corentin Chary
2011-11-23 16:17 ` David Herrmann
2011-11-23 16:54 ` Corentin Chary
2011-11-23 17:10 ` David Herrmann
2011-11-23 18:11 ` Corentin Chary
2011-11-23 20:14 ` David Herrmann
2011-11-22 22:02 ` [PATCH 09/15] samsung-laptop: add usb charge support Corentin Chary
2011-11-22 22:22 ` Greg KH
2011-11-22 22:02 ` [PATCH 10/15] samsung-laptop: cleanup KConfig Corentin Chary
2011-11-22 22:22 ` Greg KH
2011-11-23 16:19 ` David Herrmann
2011-11-22 22:02 ` [PATCH 11/15] samsung-laptop: add keyboard backlight support Corentin Chary
2011-11-22 22:23 ` Greg KH
2011-11-23 6:35 ` Corentin Chary
2011-11-23 16:41 ` David Herrmann
2011-11-23 16:51 ` Corentin Chary
2011-11-24 7:07 ` Corentin Chary
2011-11-25 19:18 ` David Herrmann
2011-11-25 21:41 ` Corentin Chary
2011-11-22 22:02 ` [PATCH 12/15] samsung-laptop: add true rfkill support for swsmi Corentin Chary
2011-11-22 22:24 ` Greg KH
2011-11-23 6:37 ` Corentin Chary
2011-11-23 20:29 ` Greg KH
2011-11-22 22:02 ` [PATCH 13/15] samsung-laptop: make the dmi check less strict Corentin Chary
2011-11-22 22:27 ` Greg KH
2011-11-23 7:17 ` Corentin Chary
2011-11-23 20:30 ` Greg KH
2011-11-22 22:02 ` [PATCH 14/15] samsung-laptop: dump model and version informations Corentin Chary
2011-11-22 22:28 ` Greg KH
2011-11-23 6:37 ` Corentin Chary
2011-11-22 22:02 ` [PATCH 15/15] samsung-laptop: promote myself as maintainer of samsung-laptop Corentin Chary
2011-11-22 22:29 ` Greg KH
2011-11-23 6:38 ` Corentin Chary
2011-11-23 16:46 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122221829.GB24283@suse.de \
--to=gregkh@suse.de \
--cc=corentincj@iksaif.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.