Re: [PATCH 13/15] samsung-laptop: make the dmi check less strict

[Greg KH <gregkh@suse.de>]

On Tue, Nov 22, 2011 at 11:02:44PM +0100, Corentin Chary wrote:
> This enable the driver for everything that look like
> a laptop and is from vendor "SAMSUNG ELECTRONICS CO., LTD.".
> Note that laptop supported by samsung-q10 seem to have a different
> vendor strict.
> 
> Also remove every log output until we know that we have a SABI interface
> (except if the driver is forced to load, or debug is enabled).
> 
> Keeping a whitelist of laptop with a model granularity is something that can't
> work without close vendor cooperation (and we don't have that).
> 
> Signed-off-by: Corentin Chary <corentincj@iksaif.net>

Oh, this is bold.

I would like to see this work, but I would need to see it tested on a
bunch of machines before I trust it.

I guess you now have the acpi video backlight check, which is good, but
again, doesn't work for all devices.

And yeah, a whitelist is tough, especially as the vendor isn't working
with us at all, but I don't want to break machines that don't need this
driver (and there are some, although I thought the newest ones would not
need it, but that might be true.)

Hm, if you can figure out how to get the acpi-video thing working for
some machines properly, I'll support this kind of change.

thanks,

greg k-h