From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Steven Toth <stoth@kernellabs.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] [media] saa7164: fix endian conversion in saa7164_bus_set()
Date: Wed, 23 Nov 2011 07:09:12 +0000 [thread overview]
Message-ID: <20111123070911.GA8561@elgon.mountain> (raw)
The msg->command field is 32 bits, and we should fill it with a call
to cpu_to_le32(). The current code is broken on big endian systems,
and on little endian systems it just truncates the 32 bit value to
16 bits.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This is a static checker bug. I haven't tested it.
diff --git a/drivers/media/video/saa7164/saa7164-bus.c b/drivers/media/video/saa7164/saa7164-bus.c
index 466e1b0..8f853d1 100644
--- a/drivers/media/video/saa7164/saa7164-bus.c
+++ b/drivers/media/video/saa7164/saa7164-bus.c
@@ -149,7 +149,7 @@ int saa7164_bus_set(struct saa7164_dev *dev, struct tmComResInfo* msg,
saa7164_bus_verify(dev);
msg->size = cpu_to_le16(msg->size);
- msg->command = cpu_to_le16(msg->command);
+ msg->command = cpu_to_le32(msg->command);
msg->controlselector = cpu_to_le16(msg->controlselector);
if (msg->size > dev->bus.m_wMaxReqSize) {
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Steven Toth <stoth@kernellabs.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] [media] saa7164: fix endian conversion in saa7164_bus_set()
Date: Wed, 23 Nov 2011 10:09:12 +0300 [thread overview]
Message-ID: <20111123070911.GA8561@elgon.mountain> (raw)
The msg->command field is 32 bits, and we should fill it with a call
to cpu_to_le32(). The current code is broken on big endian systems,
and on little endian systems it just truncates the 32 bit value to
16 bits.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This is a static checker bug. I haven't tested it.
diff --git a/drivers/media/video/saa7164/saa7164-bus.c b/drivers/media/video/saa7164/saa7164-bus.c
index 466e1b0..8f853d1 100644
--- a/drivers/media/video/saa7164/saa7164-bus.c
+++ b/drivers/media/video/saa7164/saa7164-bus.c
@@ -149,7 +149,7 @@ int saa7164_bus_set(struct saa7164_dev *dev, struct tmComResInfo* msg,
saa7164_bus_verify(dev);
msg->size = cpu_to_le16(msg->size);
- msg->command = cpu_to_le16(msg->command);
+ msg->command = cpu_to_le32(msg->command);
msg->controlselector = cpu_to_le16(msg->controlselector);
if (msg->size > dev->bus.m_wMaxReqSize) {
next reply other threads:[~2011-11-23 7:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 7:09 Dan Carpenter [this message]
2011-11-23 7:09 ` [patch] [media] saa7164: fix endian conversion in saa7164_bus_set() Dan Carpenter
2011-11-25 17:50 ` Mauro Carvalho Chehab
2011-11-25 17:50 ` Mauro Carvalho Chehab
2011-11-26 19:02 ` [patch] [media] saa7164: fix endian conversion in Dan Carpenter
2011-11-26 19:02 ` [patch] [media] saa7164: fix endian conversion in saa7164_bus_set() Dan Carpenter
2011-11-28 13:08 ` [patch v2] [media] saa7164: fix endian conversion in Dan Carpenter
2011-11-28 13:08 ` [patch v2] [media] saa7164: fix endian conversion in saa7164_bus_set() Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123070911.GA8561@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=peterhuewe@gmx.de \
--cc=stoth@kernellabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.